diff mbox series

[aws-focal] UBUNTU: [Config] aws: enable FPGA for amd64 also

Message ID 20201006200641.19169-1-kamal@canonical.com
State New
Headers show
Series [aws-focal] UBUNTU: [Config] aws: enable FPGA for amd64 also | expand

Commit Message

Kamal Mostafa Oct. 6, 2020, 8:06 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1898781

AWS F1 (x86_64) instance types need the fpga-mgr module.

Signed-off-by: Kamal Mostafa <kamal@canonical.com>
---
 debian.aws/config/amd64/config.common.amd64 | 1 -
 debian.aws/config/arm64/config.common.arm64 | 1 -
 debian.aws/config/config.common.ubuntu      | 1 +
 3 files changed, 1 insertion(+), 2 deletions(-)

Comments

Stefan Bader Oct. 7, 2020, 8:01 a.m. UTC | #1
On 06.10.20 22:06, Kamal Mostafa wrote:
> BugLink: https://bugs.launchpad.net/bugs/1898781
> 
> AWS F1 (x86_64) instance types need the fpga-mgr module.
> 
> Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
> ---

The bug report should have the standard SRU template filled in (yes, I know its
a small change).

-Stefan

>  debian.aws/config/amd64/config.common.amd64 | 1 -
>  debian.aws/config/arm64/config.common.arm64 | 1 -
>  debian.aws/config/config.common.ubuntu      | 1 +
>  3 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/debian.aws/config/amd64/config.common.amd64 b/debian.aws/config/amd64/config.common.amd64
> index 9826e7744674..21c8e018f806 100644
> --- a/debian.aws/config/amd64/config.common.amd64
> +++ b/debian.aws/config/amd64/config.common.amd64
> @@ -68,7 +68,6 @@ CONFIG_DMA_VIRTUAL_CHANNELS=m
>  # CONFIG_DRM_ETNAVIV is not set
>  # CONFIG_DRM_NOUVEAU is not set
>  # CONFIG_FIREWIRE is not set
> -# CONFIG_FPGA is not set
>  # CONFIG_FUJITSU_ES is not set
>  # CONFIG_GAMEPORT is not set
>  CONFIG_HIBERNATION=y
> diff --git a/debian.aws/config/arm64/config.common.arm64 b/debian.aws/config/arm64/config.common.arm64
> index 8b4928bf1784..2cf4d578aacd 100644
> --- a/debian.aws/config/arm64/config.common.arm64
> +++ b/debian.aws/config/arm64/config.common.arm64
> @@ -68,7 +68,6 @@ CONFIG_DMA_VIRTUAL_CHANNELS=y
>  CONFIG_DRM_ETNAVIV=m
>  CONFIG_DRM_NOUVEAU=m
>  CONFIG_FIREWIRE=m
> -CONFIG_FPGA=m
>  CONFIG_FUJITSU_ES=m
>  CONFIG_GAMEPORT=m
>  # CONFIG_HIBERNATION is not set
> diff --git a/debian.aws/config/config.common.ubuntu b/debian.aws/config/config.common.ubuntu
> index e90c64b8faf5..74249c6eec49 100644
> --- a/debian.aws/config/config.common.ubuntu
> +++ b/debian.aws/config/config.common.ubuntu
> @@ -2815,6 +2815,7 @@ CONFIG_FONT_SUPPORT=y
>  CONFIG_FORCEDETH=m
>  CONFIG_FORCE_MAX_ZONEORDER=13
>  CONFIG_FORTIFY_SOURCE=y
> +CONFIG_FPGA=m
>  CONFIG_FPGA_BRIDGE=m
>  CONFIG_FPGA_DFL=m
>  CONFIG_FPGA_DFL_AFU=m
>
Colin Ian King Oct. 7, 2020, 8:26 a.m. UTC | #2
On 06/10/2020 21:06, Kamal Mostafa wrote:
> BugLink: https://bugs.launchpad.net/bugs/1898781
> 
> AWS F1 (x86_64) instance types need the fpga-mgr module.
> 
> Signed-off-by: Kamal Mostafa <kamal@canonical.com>
> ---
>  debian.aws/config/amd64/config.common.amd64 | 1 -
>  debian.aws/config/arm64/config.common.arm64 | 1 -
>  debian.aws/config/config.common.ubuntu      | 1 +
>  3 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/debian.aws/config/amd64/config.common.amd64 b/debian.aws/config/amd64/config.common.amd64
> index 9826e7744674..21c8e018f806 100644
> --- a/debian.aws/config/amd64/config.common.amd64
> +++ b/debian.aws/config/amd64/config.common.amd64
> @@ -68,7 +68,6 @@ CONFIG_DMA_VIRTUAL_CHANNELS=m
>  # CONFIG_DRM_ETNAVIV is not set
>  # CONFIG_DRM_NOUVEAU is not set
>  # CONFIG_FIREWIRE is not set
> -# CONFIG_FPGA is not set
>  # CONFIG_FUJITSU_ES is not set
>  # CONFIG_GAMEPORT is not set
>  CONFIG_HIBERNATION=y
> diff --git a/debian.aws/config/arm64/config.common.arm64 b/debian.aws/config/arm64/config.common.arm64
> index 8b4928bf1784..2cf4d578aacd 100644
> --- a/debian.aws/config/arm64/config.common.arm64
> +++ b/debian.aws/config/arm64/config.common.arm64
> @@ -68,7 +68,6 @@ CONFIG_DMA_VIRTUAL_CHANNELS=y
>  CONFIG_DRM_ETNAVIV=m
>  CONFIG_DRM_NOUVEAU=m
>  CONFIG_FIREWIRE=m
> -CONFIG_FPGA=m
>  CONFIG_FUJITSU_ES=m
>  CONFIG_GAMEPORT=m
>  # CONFIG_HIBERNATION is not set
> diff --git a/debian.aws/config/config.common.ubuntu b/debian.aws/config/config.common.ubuntu
> index e90c64b8faf5..74249c6eec49 100644
> --- a/debian.aws/config/config.common.ubuntu
> +++ b/debian.aws/config/config.common.ubuntu
> @@ -2815,6 +2815,7 @@ CONFIG_FONT_SUPPORT=y
>  CONFIG_FORCEDETH=m
>  CONFIG_FORCE_MAX_ZONEORDER=13
>  CONFIG_FORTIFY_SOURCE=y
> +CONFIG_FPGA=m
>  CONFIG_FPGA_BRIDGE=m
>  CONFIG_FPGA_DFL=m
>  CONFIG_FPGA_DFL_AFU=m
> 

Looks good to me. Thanks Kamal.

Acked-by: Colin Ian King <colin.king@canonical.com>
Kamal Mostafa Oct. 7, 2020, 7:35 p.m. UTC | #3
On Wed, Oct 7, 2020 at 1:01 AM Stefan Bader <stefan.bader@canonical.com>
wrote:

>
> Acked-by: Stefan Bader <stefan.bader@canonical.com>
>
> The bug report should have the standard SRU template filled in (yes, I
> know its
> a small change).
>
>
Done.

 -Kamal
Ian May Oct. 9, 2020, 6:56 p.m. UTC | #4
Applied to aws-focal  

Thanks!
Ian

On 2020-10-06 13:06:41 , Kamal Mostafa wrote:
> BugLink: https://bugs.launchpad.net/bugs/1898781
> 
> AWS F1 (x86_64) instance types need the fpga-mgr module.
> 
> Signed-off-by: Kamal Mostafa <kamal@canonical.com>
> ---
>  debian.aws/config/amd64/config.common.amd64 | 1 -
>  debian.aws/config/arm64/config.common.arm64 | 1 -
>  debian.aws/config/config.common.ubuntu      | 1 +
>  3 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/debian.aws/config/amd64/config.common.amd64 b/debian.aws/config/amd64/config.common.amd64
> index 9826e7744674..21c8e018f806 100644
> --- a/debian.aws/config/amd64/config.common.amd64
> +++ b/debian.aws/config/amd64/config.common.amd64
> @@ -68,7 +68,6 @@ CONFIG_DMA_VIRTUAL_CHANNELS=m
>  # CONFIG_DRM_ETNAVIV is not set
>  # CONFIG_DRM_NOUVEAU is not set
>  # CONFIG_FIREWIRE is not set
> -# CONFIG_FPGA is not set
>  # CONFIG_FUJITSU_ES is not set
>  # CONFIG_GAMEPORT is not set
>  CONFIG_HIBERNATION=y
> diff --git a/debian.aws/config/arm64/config.common.arm64 b/debian.aws/config/arm64/config.common.arm64
> index 8b4928bf1784..2cf4d578aacd 100644
> --- a/debian.aws/config/arm64/config.common.arm64
> +++ b/debian.aws/config/arm64/config.common.arm64
> @@ -68,7 +68,6 @@ CONFIG_DMA_VIRTUAL_CHANNELS=y
>  CONFIG_DRM_ETNAVIV=m
>  CONFIG_DRM_NOUVEAU=m
>  CONFIG_FIREWIRE=m
> -CONFIG_FPGA=m
>  CONFIG_FUJITSU_ES=m
>  CONFIG_GAMEPORT=m
>  # CONFIG_HIBERNATION is not set
> diff --git a/debian.aws/config/config.common.ubuntu b/debian.aws/config/config.common.ubuntu
> index e90c64b8faf5..74249c6eec49 100644
> --- a/debian.aws/config/config.common.ubuntu
> +++ b/debian.aws/config/config.common.ubuntu
> @@ -2815,6 +2815,7 @@ CONFIG_FONT_SUPPORT=y
>  CONFIG_FORCEDETH=m
>  CONFIG_FORCE_MAX_ZONEORDER=13
>  CONFIG_FORTIFY_SOURCE=y
> +CONFIG_FPGA=m
>  CONFIG_FPGA_BRIDGE=m
>  CONFIG_FPGA_DFL=m
>  CONFIG_FPGA_DFL_AFU=m
> -- 
> 2.17.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
diff mbox series

Patch

diff --git a/debian.aws/config/amd64/config.common.amd64 b/debian.aws/config/amd64/config.common.amd64
index 9826e7744674..21c8e018f806 100644
--- a/debian.aws/config/amd64/config.common.amd64
+++ b/debian.aws/config/amd64/config.common.amd64
@@ -68,7 +68,6 @@  CONFIG_DMA_VIRTUAL_CHANNELS=m
 # CONFIG_DRM_ETNAVIV is not set
 # CONFIG_DRM_NOUVEAU is not set
 # CONFIG_FIREWIRE is not set
-# CONFIG_FPGA is not set
 # CONFIG_FUJITSU_ES is not set
 # CONFIG_GAMEPORT is not set
 CONFIG_HIBERNATION=y
diff --git a/debian.aws/config/arm64/config.common.arm64 b/debian.aws/config/arm64/config.common.arm64
index 8b4928bf1784..2cf4d578aacd 100644
--- a/debian.aws/config/arm64/config.common.arm64
+++ b/debian.aws/config/arm64/config.common.arm64
@@ -68,7 +68,6 @@  CONFIG_DMA_VIRTUAL_CHANNELS=y
 CONFIG_DRM_ETNAVIV=m
 CONFIG_DRM_NOUVEAU=m
 CONFIG_FIREWIRE=m
-CONFIG_FPGA=m
 CONFIG_FUJITSU_ES=m
 CONFIG_GAMEPORT=m
 # CONFIG_HIBERNATION is not set
diff --git a/debian.aws/config/config.common.ubuntu b/debian.aws/config/config.common.ubuntu
index e90c64b8faf5..74249c6eec49 100644
--- a/debian.aws/config/config.common.ubuntu
+++ b/debian.aws/config/config.common.ubuntu
@@ -2815,6 +2815,7 @@  CONFIG_FONT_SUPPORT=y
 CONFIG_FORCEDETH=m
 CONFIG_FORCE_MAX_ZONEORDER=13
 CONFIG_FORTIFY_SOURCE=y
+CONFIG_FPGA=m
 CONFIG_FPGA_BRIDGE=m
 CONFIG_FPGA_DFL=m
 CONFIG_FPGA_DFL_AFU=m