Message ID | 20200619165010.645925-4-seth.forshee@canonical.com |
---|---|
State | New |
Headers | show
Return-Path: <kernel-team-bounces@lists.ubuntu.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49pPtl1q2WzB4C8; Sat, 20 Jun 2020 02:50:23 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from <kernel-team-bounces@lists.ubuntu.com>) id 1jmKDc-0006kN-69; Fri, 19 Jun 2020 16:50:20 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from <seth.forshee@canonical.com>) id 1jmKDZ-0006j3-DE for kernel-team@lists.ubuntu.com; Fri, 19 Jun 2020 16:50:17 +0000 Received: from mail-il1-f197.google.com ([209.85.166.197]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from <seth.forshee@canonical.com>) id 1jmKDZ-0006Je-0l for kernel-team@lists.ubuntu.com; Fri, 19 Jun 2020 16:50:17 +0000 Received: by mail-il1-f197.google.com with SMTP id q24so6862914ili.12 for <kernel-team@lists.ubuntu.com>; Fri, 19 Jun 2020 09:50:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AiOPnvOwqnyUNLD7jFJAgnOTqSxAvEOwg9Op5kONhfo=; b=GJkdgn7I5SRTNbbhTamaw7Y4TeikDQ88V3aS8P1EJxG9Z/+k57lGtdDjF00urcaFFL obbbcxfvV6kC4GSzGN+lMerXLPyFa1qVxJwQKr2a5dcAbP55WWon0Ug6Qrp0OTaWCeQw IwLsZ+LrG0F8cTtdLiP2YxDoo72JciXjKqzsbr99tInGZKseUrUzanAkHDxe+gMmPAGv WYxeVvS/YCJusdfcLs3iTFoLBIblnMYq0xjymvpFqBwnxzzPm0ZR4Zot71PaJ0sP/5i+ 0w8Idq5Z+e71E9zdYTPRo1Ayrv/AHz1LZ1/M8KUawYbrbBb+lM15TZs4EnXRY9nLWtZA Hz0A== X-Gm-Message-State: AOAM5300DgU6ROoMNq1RYQpe1t2kvJjqY9UEVvNIddyV0mkWPhR70bfs hWOwPYTJafodRZ/iy+x3Ag4wMwj0KTFBNhLctBv93LCD5Uzl/q9F8ng68wkQafCLjMkNeW/Vtey CnbaTsSDfHYH8cikKrwg7b6ziow9morsi16MEzmIOLw== X-Received: by 2002:a05:6602:2cc9:: with SMTP id j9mr5246549iow.181.1592585415944; Fri, 19 Jun 2020 09:50:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyflaVbr72q+9wYnprhiiGIr/+rWtumBMbBcoQXPKbWX6pE3/5SpfGaCeT8Kic4kvAAALD7rw== X-Received: by 2002:a05:6602:2cc9:: with SMTP id j9mr5246528iow.181.1592585415642; Fri, 19 Jun 2020 09:50:15 -0700 (PDT) Received: from localhost ([2605:a601:ac0f:820:f090:1573:c2fc:6389]) by smtp.gmail.com with ESMTPSA id c20sm3635985iot.33.2020.06.19.09.50.14 for <kernel-team@lists.ubuntu.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jun 2020 09:50:15 -0700 (PDT) From: Seth Forshee <seth.forshee@canonical.com> To: kernel-team@lists.ubuntu.com Subject: [PATCH v2 03/57][X] Revert "Restrict /dev/mem and /dev/kmem when module loading is restricted" Date: Fri, 19 Jun 2020 11:49:16 -0500 Message-Id: <20200619165010.645925-4-seth.forshee@canonical.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200619165010.645925-1-seth.forshee@canonical.com> References: <20200619165010.645925-1-seth.forshee@canonical.com> MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions <kernel-team.lists.ubuntu.com> List-Unsubscribe: <https://lists.ubuntu.com/mailman/options/kernel-team>, <mailto:kernel-team-request@lists.ubuntu.com?subject=unsubscribe> List-Archive: <https://lists.ubuntu.com/archives/kernel-team> List-Post: <mailto:kernel-team@lists.ubuntu.com> List-Help: <mailto:kernel-team-request@lists.ubuntu.com?subject=help> List-Subscribe: <https://lists.ubuntu.com/mailman/listinfo/kernel-team>, <mailto:kernel-team-request@lists.ubuntu.com?subject=subscribe> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" <kernel-team-bounces@lists.ubuntu.com> |
Series |
Lockdown updates
|
expand
|
diff --git a/drivers/char/mem.c b/drivers/char/mem.c index a59fe7264c39..76997a645da8 100644 --- a/drivers/char/mem.c +++ b/drivers/char/mem.c @@ -188,9 +188,6 @@ static ssize_t write_mem(struct file *file, const char __user *buf, if (p != *ppos) return -EFBIG; - if (secure_modules()) - return -EPERM; - if (!valid_phys_addr_range(p, count)) return -EFAULT; @@ -558,9 +555,6 @@ static ssize_t write_kmem(struct file *file, const char __user *buf, char *kbuf; /* k-addr because vwrite() takes vmlist_lock rwlock */ int err = 0; - if (secure_modules()) - return -EPERM; - if (p < (unsigned long) high_memory) { unsigned long to_write = min_t(unsigned long, count, (unsigned long)high_memory - p);
BugLink: https://bugs.launchpad.net/bugs/1884159 This reverts commit 517d6c3a5c1454115dd705e084a88818df3ad7e2 to backport an updated version. Signed-off-by: Seth Forshee <seth.forshee@canonical.com> --- drivers/char/mem.c | 6 ------ 1 file changed, 6 deletions(-)