From patchwork Fri Jun 19 16:15:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Seth Forshee X-Patchwork-Id: 1313082 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49pP8t5Gp2zB47D; Sat, 20 Jun 2020 02:17:34 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1jmJhp-0002tm-1Z; Fri, 19 Jun 2020 16:17:29 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jmJhA-0002Kx-EY for kernel-team@lists.ubuntu.com; Fri, 19 Jun 2020 16:16:48 +0000 Received: from mail-io1-f69.google.com ([209.85.166.69]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jmJh8-0003b3-TS for kernel-team@lists.ubuntu.com; Fri, 19 Jun 2020 16:16:47 +0000 Received: by mail-io1-f69.google.com with SMTP id f25so255521ioh.7 for ; Fri, 19 Jun 2020 09:16:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=d+chaEpPEvOe7XOrWdcQB4G4HUo1yXAnP7ryyJDse38=; b=NjzrOjGa6Rcc6JrLRWNR9eSTlk4Bt317bA4I2+rOOwVVaYcNNqBhocGNJa0cG2d5Ne N6SciWXuglijdfupKgjT7WW4hIub+TEv2IYOBMU08DyMrMnH98E+u5dHKsg6gqz4odkb lDU4j5k2epowhXpTqyOShhpLeAvRiF7vnsHiftjO3YSqR2c7eGXHBoD+GoxoQa38LS5C S0nkvZxIcTJtbo0YdVN5wGNdT4qoCfTX7zjXO7t/eIMVpf0xMIjMMJG4B8HzH/9cdzmL EvZ5/0kMBWTLSonb4Nc2EyoR6XmfAFbaikECBLaaurDYm7JsfFURRxn/2NS+syfEPH5W +qdA== X-Gm-Message-State: AOAM533kmhmHLBHyAYU/9CtVx4UHg2kyFaCIB2uF/zl0Qg6BHv9LiuxA JKoiz/izA5C6zU4C51JsGeQq2lCeBU9XqSQACIHkHWxRvZONshsq9i7BtGX6YW8kS/wfuBYNc3j m+qVp7Ryt/WhqDvJ8ANEOAKGrsVP0oxuJfbpv63UPAg== X-Received: by 2002:a02:6a1a:: with SMTP id l26mr4553580jac.66.1592583405698; Fri, 19 Jun 2020 09:16:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwo4yfQRO2EQbUdK0E2EwKbuis+t3OZkymjJMqpz6ZYYwiU2N9zrOpb4mIoCA4NlNx4Fslygw== X-Received: by 2002:a02:6a1a:: with SMTP id l26mr4553557jac.66.1592583405415; Fri, 19 Jun 2020 09:16:45 -0700 (PDT) Received: from localhost ([2605:a601:ac0f:820:f090:1573:c2fc:6389]) by smtp.gmail.com with ESMTPSA id o19sm1088187iob.5.2020.06.19.09.16.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jun 2020 09:16:44 -0700 (PDT) From: Seth Forshee To: kernel-team@lists.ubuntu.com Subject: [PATCH v2 18/57][B] Annotate hardware config module parameters in drivers/misc/ Date: Fri, 19 Jun 2020 11:15:42 -0500 Message-Id: <20200619161621.644540-19-seth.forshee@canonical.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200619161621.644540-1-seth.forshee@canonical.com> References: <20200619161621.644540-1-seth.forshee@canonical.com> MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: David Howells BugLink: https://bugs.launchpad.net/bugs/1884159 When the kernel is running in secure boot mode, we lock down the kernel to prevent userspace from modifying the running kernel image. Whilst this includes prohibiting access to things like /dev/mem, it must also prevent access by means of configuring driver modules in such a way as to cause a device to access or modify the kernel image. To this end, annotate module_param* statements that refer to hardware configuration and indicate for future reference what type of parameter they specify. The parameter parser in the core sees this information and can skip such parameters with an error message if the kernel is locked down. The module initialisation then runs as normal, but just sees whatever the default values for those parameters is. Note that we do still need to do the module initialisation because some drivers have viable defaults set in case parameters aren't specified and some drivers support automatic configuration (e.g. PNP or PCI) in addition to manually coded parameters. This patch annotates drivers in drivers/misc/. Suggested-by: Alan Cox Signed-off-by: David Howells Acked-by: Greg Kroah-Hartman cc: Arnd Bergmann (cherry picked from commit 4f1927dcbf79f6c7c153c8ec9beeb17364649f0c) Signed-off-by: Seth Forshee --- drivers/misc/dummy-irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/dummy-irq.c b/drivers/misc/dummy-irq.c index acbbe0390be4..76a1015d5783 100644 --- a/drivers/misc/dummy-irq.c +++ b/drivers/misc/dummy-irq.c @@ -59,6 +59,6 @@ module_exit(dummy_irq_exit); MODULE_LICENSE("GPL"); MODULE_AUTHOR("Jiri Kosina"); -module_param(irq, uint, 0444); +module_param_hw(irq, uint, irq, 0444); MODULE_PARM_DESC(irq, "The IRQ to register for"); MODULE_DESCRIPTION("Dummy IRQ handler driver");