From patchwork Fri Jun 19 16:15:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Seth Forshee X-Patchwork-Id: 1313073 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49pP8F0XdRz9syB; Sat, 20 Jun 2020 02:17:01 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1jmJhF-0002P9-Gf; Fri, 19 Jun 2020 16:16:53 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jmJh2-0002DG-Ar for kernel-team@lists.ubuntu.com; Fri, 19 Jun 2020 16:16:40 +0000 Received: from mail-io1-f72.google.com ([209.85.166.72]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jmJh0-0003aE-Do for kernel-team@lists.ubuntu.com; Fri, 19 Jun 2020 16:16:38 +0000 Received: by mail-io1-f72.google.com with SMTP id l204so7159753ioa.4 for ; Fri, 19 Jun 2020 09:16:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uGMkQ07+7bx1FU5yI2G6Hy0lRKlEMcGlWA8E+bd5ZVA=; b=DyxZLwwVjPhPl3EhzVRQSfpNRvMsmgzR+x6qFwiI80B8ZeC+CuXYf2EM953hvEbKbh qMqqnOxbR13OKpApszDEinJT3bSCOn75p3WbcRxpW9SYydt8dKtO3Q0hKBybD2rP5gmX 97pdy4wViei7kQvYoJ/5U+hdoJAJ5a1C3wh6TNU9Zfz0soEWgTNLYiARDHw6SqkbuxAA Cp+GLNLLSGZIYdJXDrG/4LsvYt0KONLQ9DBQpu0VoTwLrfNjjpImAvK7JKh7HwnnykcR STVrqYuEsIOy1WRW0xVar1zHxfLeS534OnXPJQZZhgylJo5fXoR8Q1Z5B9g05nTxnLsR TjNQ== X-Gm-Message-State: AOAM533EGLEDLcPeUdZ2KQA42ujwiE4Pujfska9yzReULmz+pRKmolbp ans6jsll2A4SZP7J0d4+McPCsumc+q2QuD9ItatozwCCOtDOUk3dCj8mJiVVH97oY0Y8Egcb4wm Z+U935UpUZ/tdsGYDG6abOdcMGY1jmxglpxK0IBY3yA== X-Received: by 2002:a05:6e02:eee:: with SMTP id j14mr4361801ilk.261.1592583397321; Fri, 19 Jun 2020 09:16:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyXoDsxCH8X96+Gqh/eE5GW5hXtt3zfHdP7stY7indSavfLZin2z1lbIz/Amqm1M5c+GteYXw== X-Received: by 2002:a05:6e02:eee:: with SMTP id j14mr4361776ilk.261.1592583396992; Fri, 19 Jun 2020 09:16:36 -0700 (PDT) Received: from localhost ([2605:a601:ac0f:820:f090:1573:c2fc:6389]) by smtp.gmail.com with ESMTPSA id x15sm3178765ilj.78.2020.06.19.09.16.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jun 2020 09:16:36 -0700 (PDT) From: Seth Forshee To: kernel-team@lists.ubuntu.com Subject: [PATCH v2 11/57][B] Annotate hardware config module parameters in drivers/clocksource/ Date: Fri, 19 Jun 2020 11:15:35 -0500 Message-Id: <20200619161621.644540-12-seth.forshee@canonical.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200619161621.644540-1-seth.forshee@canonical.com> References: <20200619161621.644540-1-seth.forshee@canonical.com> MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: David Howells BugLink: https://bugs.launchpad.net/bugs/1884159 When the kernel is running in secure boot mode, we lock down the kernel to prevent userspace from modifying the running kernel image. Whilst this includes prohibiting access to things like /dev/mem, it must also prevent access by means of configuring driver modules in such a way as to cause a device to access or modify the kernel image. To this end, annotate module_param* statements that refer to hardware configuration and indicate for future reference what type of parameter they specify. The parameter parser in the core sees this information and can skip such parameters with an error message if the kernel is locked down. The module initialisation then runs as normal, but just sees whatever the default values for those parameters is. Note that we do still need to do the module initialisation because some drivers have viable defaults set in case parameters aren't specified and some drivers support automatic configuration (e.g. PNP or PCI) in addition to manually coded parameters. This patch annotates drivers in drivers/clocksource/. [Note: With regard to cs5535-clockevt.c, Thomas Gleixner asked whether the timer_irq parameter is required for the driver to work on anything other than arbitrary hardware which has it mapped to 0. Jens Rottmann replied that the parameter defaults to 0, which means: 1. autodetect (=keep IRQ BIOS has set up) 2. if that fails use CONFIG_CS5535_MFGPT_DEFAULT_IRQ (see drivers/misc/cs5535-mfgpt.c: cs5535_mfgpt_set_irq()) Jens further noted that there may not be any systems that have CS5535/36 devices that support EFI and secure boot.] Suggested-by: Alan Cox Signed-off-by: David Howells cc: Daniel Lezcano cc: Thomas Gleixner cc: Jens Rottmann cc: linux-kernel@vger.kernel.org (cherry picked from commit cc9c617557cd0442294138188ac8611659768a10) Signed-off-by: Seth Forshee --- drivers/clocksource/cs5535-clockevt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clocksource/cs5535-clockevt.c b/drivers/clocksource/cs5535-clockevt.c index e1d7373e63e0..1de8cac99a0e 100644 --- a/drivers/clocksource/cs5535-clockevt.c +++ b/drivers/clocksource/cs5535-clockevt.c @@ -22,7 +22,7 @@ #define DRV_NAME "cs5535-clockevt" static int timer_irq; -module_param_named(irq, timer_irq, int, 0644); +module_param_hw_named(irq, timer_irq, int, irq, 0644); MODULE_PARM_DESC(irq, "Which IRQ to use for the clock source MFGPT ticks."); /*