diff mbox series

[1/1,SRU,OEM-5.6] xhci-pci: Allow host runtime PM as default for Intel Tiger Lake xHCI

Message ID 20200512073353.18599-2-koba.ko@canonical.com
State New
Headers show
Series Allow host runtime PM as default for Intel Tiger Lake xHCI | expand

Commit Message

Koba Ko May 12, 2020, 7:33 a.m. UTC
From: Mika Westerberg <mika.westerberg@linux.intel.com>

BugLink: https://bugs.launchpad.net/bugs/1878149

In the same way as Intel Ice Lake TCSS (Type-C Subsystem) the Tiger Lake
TCSS xHCI needs to be runtime suspended whenever possible to allow the
TCSS hardware block to enter D3cold and thus save energy.

Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Link: https://lore.kernel.org/r/20200312144517.1593-10-mathias.nyman@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
(cherry picked from commit 6a7c533d4a1854f54901a065d8c672e890400d8a)
Signed-off-by: Koba Ko <koba.ko@canonical.com>
---
 drivers/usb/host/xhci-pci.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Sultan Alsawaf May 13, 2020, 5:53 p.m. UTC | #1
Acked-by: Sultan Alsawaf <sultan.alsawaf@canonical.com>

On Tue, May 12, 2020 at 03:33:53PM +0800, Koba Ko wrote:
> From: Mika Westerberg <mika.westerberg@linux.intel.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1878149
> 
> In the same way as Intel Ice Lake TCSS (Type-C Subsystem) the Tiger Lake
> TCSS xHCI needs to be runtime suspended whenever possible to allow the
> TCSS hardware block to enter D3cold and thus save energy.
> 
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
> Link: https://lore.kernel.org/r/20200312144517.1593-10-mathias.nyman@linux.intel.com
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> (cherry picked from commit 6a7c533d4a1854f54901a065d8c672e890400d8a)
> Signed-off-by: Koba Ko <koba.ko@canonical.com>
> ---
>  drivers/usb/host/xhci-pci.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> index 1fddc41fa1f3..7f32793626e1 100644
> --- a/drivers/usb/host/xhci-pci.c
> +++ b/drivers/usb/host/xhci-pci.c
> @@ -50,6 +50,7 @@
>  #define PCI_DEVICE_ID_INTEL_TITAN_RIDGE_DD_XHCI		0x15f0
>  #define PCI_DEVICE_ID_INTEL_ICE_LAKE_XHCI		0x8a13
>  #define PCI_DEVICE_ID_INTEL_CML_XHCI			0xa3af
> +#define PCI_DEVICE_ID_INTEL_TIGER_LAKE_XHCI		0x9a13
>  
>  #define PCI_DEVICE_ID_AMD_PROMONTORYA_4			0x43b9
>  #define PCI_DEVICE_ID_AMD_PROMONTORYA_3			0x43ba
> @@ -217,7 +218,8 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
>  	     pdev->device == PCI_DEVICE_ID_INTEL_TITAN_RIDGE_2C_XHCI ||
>  	     pdev->device == PCI_DEVICE_ID_INTEL_TITAN_RIDGE_4C_XHCI ||
>  	     pdev->device == PCI_DEVICE_ID_INTEL_TITAN_RIDGE_DD_XHCI ||
> -	     pdev->device == PCI_DEVICE_ID_INTEL_ICE_LAKE_XHCI))
> +	     pdev->device == PCI_DEVICE_ID_INTEL_ICE_LAKE_XHCI ||
> +	     pdev->device == PCI_DEVICE_ID_INTEL_TIGER_LAKE_XHCI))
>  		xhci->quirks |= XHCI_DEFAULT_PM_RUNTIME_ALLOW;
>  
>  	if (pdev->vendor == PCI_VENDOR_ID_ETRON &&
> -- 
> 2.25.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Timo Aaltonen May 19, 2020, 7:57 a.m. UTC | #2
On 12.5.2020 10.33, Koba Ko wrote:
> From: Mika Westerberg <mika.westerberg@linux.intel.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1878149

applied to oem-5.6-next, thanks
diff mbox series

Patch

diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index 1fddc41fa1f3..7f32793626e1 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -50,6 +50,7 @@ 
 #define PCI_DEVICE_ID_INTEL_TITAN_RIDGE_DD_XHCI		0x15f0
 #define PCI_DEVICE_ID_INTEL_ICE_LAKE_XHCI		0x8a13
 #define PCI_DEVICE_ID_INTEL_CML_XHCI			0xa3af
+#define PCI_DEVICE_ID_INTEL_TIGER_LAKE_XHCI		0x9a13
 
 #define PCI_DEVICE_ID_AMD_PROMONTORYA_4			0x43b9
 #define PCI_DEVICE_ID_AMD_PROMONTORYA_3			0x43ba
@@ -217,7 +218,8 @@  static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
 	     pdev->device == PCI_DEVICE_ID_INTEL_TITAN_RIDGE_2C_XHCI ||
 	     pdev->device == PCI_DEVICE_ID_INTEL_TITAN_RIDGE_4C_XHCI ||
 	     pdev->device == PCI_DEVICE_ID_INTEL_TITAN_RIDGE_DD_XHCI ||
-	     pdev->device == PCI_DEVICE_ID_INTEL_ICE_LAKE_XHCI))
+	     pdev->device == PCI_DEVICE_ID_INTEL_ICE_LAKE_XHCI ||
+	     pdev->device == PCI_DEVICE_ID_INTEL_TIGER_LAKE_XHCI))
 		xhci->quirks |= XHCI_DEFAULT_PM_RUNTIME_ALLOW;
 
 	if (pdev->vendor == PCI_VENDOR_ID_ETRON &&