| Message ID | 20200410104134.483549-2-andrea.righi@canonical.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/1,F] UBUNTU: SAUCE: kselftest/runner: allow to properly deliver signals to tests | expand |
On 10.04.20 12:41, Andrea Righi wrote: > BugLink: https://bugs.launchpad.net/bugs/1872047 > > While running seccomp_bpf, kill_after_ptrace() gets stuck if we run it > via /usr/bin/timeout (that is the default), until the timeout expires. > > This is because /usr/bin/timeout is preventing to properly deliver > signals to ptrace'd children (SIGSYS in this case). > > This problem can be easily reproduced by running: > > $ sudo make TARGETS=seccomp kselftest > ... > > # [ RUN ] TRACE_syscall.skip_a# > not ok 1 selftests: seccomp: seccomp_bpf # TIMEOUT > > The test is hanging at this point until the timeout expires and then it > reports the timeout error. > > Prevent this problem by passing --foreground to /usr/bin/timeout, > allowing to properly deliver signals to children processes. > > Signed-off-by: Andrea Righi <andrea.righi@canonical.com> Thanks for fixing it! Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com> > --- > tools/testing/selftests/kselftest/runner.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/kselftest/runner.sh b/tools/testing/selftests/kselftest/runner.sh > index 2cd3c8def0f6..c348ab34662d 100644 > --- a/tools/testing/selftests/kselftest/runner.sh > +++ b/tools/testing/selftests/kselftest/runner.sh > @@ -33,7 +33,7 @@ tap_timeout() > { > # Make sure tests will time out if utility is available. > if [ -x /usr/bin/timeout ] && [ $kselftest_timeout -gt 0 ] ; then > - /usr/bin/timeout "$kselftest_timeout" "$1" > + /usr/bin/timeout --foreground "$kselftest_timeout" "$1" > else > "$1" > fi >
diff --git a/tools/testing/selftests/kselftest/runner.sh b/tools/testing/selftests/kselftest/runner.sh index 2cd3c8def0f6..c348ab34662d 100644 --- a/tools/testing/selftests/kselftest/runner.sh +++ b/tools/testing/selftests/kselftest/runner.sh @@ -33,7 +33,7 @@ tap_timeout() { # Make sure tests will time out if utility is available. if [ -x /usr/bin/timeout ] && [ $kselftest_timeout -gt 0 ] ; then - /usr/bin/timeout "$kselftest_timeout" "$1" + /usr/bin/timeout --foreground "$kselftest_timeout" "$1" else "$1" fi
BugLink: https://bugs.launchpad.net/bugs/1872047 While running seccomp_bpf, kill_after_ptrace() gets stuck if we run it via /usr/bin/timeout (that is the default), until the timeout expires. This is because /usr/bin/timeout is preventing to properly deliver signals to ptrace'd children (SIGSYS in this case). This problem can be easily reproduced by running: $ sudo make TARGETS=seccomp kselftest ... # [ RUN ] TRACE_syscall.skip_a# not ok 1 selftests: seccomp: seccomp_bpf # TIMEOUT The test is hanging at this point until the timeout expires and then it reports the timeout error. Prevent this problem by passing --foreground to /usr/bin/timeout, allowing to properly deliver signals to children processes. Signed-off-by: Andrea Righi <andrea.righi@canonical.com> --- tools/testing/selftests/kselftest/runner.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)