Message ID | 20200316032650.29141-2-po-hsu.lin@canonical.com |
---|---|
State | New |
Headers | show |
Series | [B,SRU,1/1] selftests: net: reuseport_bpf_numa: don't fail if no numa support | expand |
Another Ack from me :) Thanks Sam On 3/15/20 11:26 PM, Po-Hsu Lin wrote: > From: Anders Roxell <anders.roxell@linaro.org> > > BugLink: https://bugs.launchpad.net/bugs/1812638 > > The reuseport_bpf_numa test case fails there's no numa support. The > test shouldn't fail if there's no support it should be skipped. > > Fixes: 3c2c3c16aaf6 ("reuseport, bpf: add test case for bpf_get_numa_node_id") > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> > Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> > (cherry picked from commit 1a2b80ecc7ad374e9ef6a3de6fdd032d94be2270) > Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com> > --- > tools/testing/selftests/net/reuseport_bpf_numa.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/net/reuseport_bpf_numa.c b/tools/testing/selftests/net/reuseport_bpf_numa.c > index 365c32e..c9f478b 100644 > --- a/tools/testing/selftests/net/reuseport_bpf_numa.c > +++ b/tools/testing/selftests/net/reuseport_bpf_numa.c > @@ -23,6 +23,8 @@ > #include <unistd.h> > #include <numa.h> > > +#include "../kselftest.h" > + > static const int PORT = 8888; > > static void build_rcv_group(int *rcv_fd, size_t len, int family, int proto) > @@ -229,7 +231,7 @@ int main(void) > int *rcv_fd, nodes; > > if (numa_available() < 0) > - error(1, errno, "no numa api support"); > + ksft_exit_skip("no numa api support\n"); > > nodes = numa_max_node() + 1; >
diff --git a/tools/testing/selftests/net/reuseport_bpf_numa.c b/tools/testing/selftests/net/reuseport_bpf_numa.c index 365c32e..c9f478b 100644 --- a/tools/testing/selftests/net/reuseport_bpf_numa.c +++ b/tools/testing/selftests/net/reuseport_bpf_numa.c @@ -23,6 +23,8 @@ #include <unistd.h> #include <numa.h> +#include "../kselftest.h" + static const int PORT = 8888; static void build_rcv_group(int *rcv_fd, size_t len, int family, int proto) @@ -229,7 +231,7 @@ int main(void) int *rcv_fd, nodes; if (numa_available() < 0) - error(1, errno, "no numa api support"); + ksft_exit_skip("no numa api support\n"); nodes = numa_max_node() + 1;