diff mbox series

[SRU,F/E/OEM-B-OSP1/B/OEM-B,v2,1/1] UBUNTU: SAUCE: ALSA: hda/realtek - Fix a regression for mute led on Lenovo Carbon X1

Message ID 20200225041544.5595-2-hui.wang@canonical.com
State Accepted
Headers show
Series alsa/hda/realtek: fix a mute led regression on Lenovo X1 Carbon | expand

Commit Message

Hui Wang Feb. 25, 2020, 4:15 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1864576

Need to chain the THINKPAD_ACPI, otherwise the mute led will not
work.

Fixes: d2cd795c4ece ("ALSA: hda - fixup for the bass speaker on Lenovo Carbon X1 7th gen")
Cc: <stable@vger.kernel.org>
Signed-off-by: Hui Wang <hui.wang@canonical.com>
Link: https://lore.kernel.org/r/20200219052306.24935-1-hui.wang@canonical.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
(cherry picked from commit c37c0ab029569a75fd180edb03d411e7a28a936f
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git)
Signed-off-by: Hui Wang <hui.wang@canonical.com>
---
 sound/pci/hda/patch_realtek.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Po-Hsu Lin Feb. 25, 2020, 4:10 p.m. UTC | #1
Acked-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
Kleber Sacilotto de Souza Feb. 25, 2020, 5:01 p.m. UTC | #2
On 25.02.20 05:15, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1864576
> 
> Need to chain the THINKPAD_ACPI, otherwise the mute led will not
> work.
> 
> Fixes: d2cd795c4ece ("ALSA: hda - fixup for the bass speaker on Lenovo Carbon X1 7th gen")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
> Link: https://lore.kernel.org/r/20200219052306.24935-1-hui.wang@canonical.com
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> (cherry picked from commit c37c0ab029569a75fd180edb03d411e7a28a936f
> git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git)
> Signed-off-by: Hui Wang <hui.wang@canonical.com>

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

> ---
>  sound/pci/hda/patch_realtek.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index bb3a4d5b37d7..bf8f0eb44772 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -6674,6 +6674,8 @@ static const struct hda_fixup alc269_fixups[] = {
>  	[ALC285_FIXUP_SPEAKER2_TO_DAC1] = {
>  		.type = HDA_FIXUP_FUNC,
>  		.v.func = alc285_fixup_speaker2_to_dac1,
> +		.chained = true,
> +		.chain_id = ALC269_FIXUP_THINKPAD_ACPI
>  	},
>  	[ALC256_FIXUP_DELL_INSPIRON_7559_SUBWOOFER] = {
>  		.type = HDA_FIXUP_PINS,
>
diff mbox series

Patch

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index bb3a4d5b37d7..bf8f0eb44772 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6674,6 +6674,8 @@  static const struct hda_fixup alc269_fixups[] = {
 	[ALC285_FIXUP_SPEAKER2_TO_DAC1] = {
 		.type = HDA_FIXUP_FUNC,
 		.v.func = alc285_fixup_speaker2_to_dac1,
+		.chained = true,
+		.chain_id = ALC269_FIXUP_THINKPAD_ACPI
 	},
 	[ALC256_FIXUP_DELL_INSPIRON_7559_SUBWOOFER] = {
 		.type = HDA_FIXUP_PINS,