diff mbox series

[Cosmic,deb-to-snap,master] deb to snap: add nvme and hid modules to initrd for amd64

Message ID 20181123095707.11626-1-jesse.sung@canonical.com
State New
Headers show
Series [Cosmic,deb-to-snap,master] deb to snap: add nvme and hid modules to initrd for amd64 | expand

Commit Message

Wen-chien Jesse Sung Nov. 23, 2018, 9:57 a.m. UTC
BugLink: https://launchpad.net/bugs/1802260

Signed-off-by: Wen-chien Jesse Sung <jesse.sung@canonical.com>
---
 Makefile | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Paolo Pisati Dec. 5, 2018, 8:52 a.m. UTC | #1
Acked-by: Paolo Pisati <paolo.pisati@canonical.com>
On Fri, Nov 23, 2018 at 10:57 AM Wen-chien Jesse Sung
<jesse.sung@canonical.com> wrote:
>
> BugLink: https://launchpad.net/bugs/1802260
>
> Signed-off-by: Wen-chien Jesse Sung <jesse.sung@canonical.com>
> ---
>  Makefile | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index 7e3ee09..5ef8473 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -78,6 +78,11 @@ all:
>         fi
>         mkdir -p chroot/etc/initramfs-tools/conf.d
>         echo "COMPRESS=lzma" >chroot/etc/initramfs-tools/conf.d/ubuntu-core.conf
> +       if [ "$(DPKG_ARCH)" = "amd64" ]; then \
> +         echo "nvme" >> chroot/etc/initramfs-tools/modules; \
> +         echo "usbhid" >> chroot/etc/initramfs-tools/modules; \
> +         echo "hid-generic" >> chroot/etc/initramfs-tools/modules; \
> +       fi
>         $(ENV) chroot chroot apt-get -y update
>         $(ENV) chroot chroot apt-get -y --allow-unauthenticated install initramfs-tools-ubuntu-core linux-firmware xz-utils
>         mount --bind /proc chroot/proc
> --
> 2.19.1
>
>
> --
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Kleber Sacilotto de Souza Dec. 6, 2018, 2:04 p.m. UTC | #2
On 11/23/18 10:57 AM, Wen-chien Jesse Sung wrote:
> BugLink: https://launchpad.net/bugs/1802260
>
> Signed-off-by: Wen-chien Jesse Sung <jesse.sung@canonical.com>

The linux-snap/cosmic repo seems to be not used for any kernel snap
image. Actually we only produce kernel snaps for the LTS releases.

Anyway I'm ack'ing this patch:

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>


Thanks,

Kleber

> ---
>  Makefile | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index 7e3ee09..5ef8473 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -78,6 +78,11 @@ all:
>  	fi
>  	mkdir -p chroot/etc/initramfs-tools/conf.d
>  	echo "COMPRESS=lzma" >chroot/etc/initramfs-tools/conf.d/ubuntu-core.conf
> +	if [ "$(DPKG_ARCH)" = "amd64" ]; then \
> +	  echo "nvme" >> chroot/etc/initramfs-tools/modules; \
> +	  echo "usbhid" >> chroot/etc/initramfs-tools/modules; \
> +	  echo "hid-generic" >> chroot/etc/initramfs-tools/modules; \
> +	fi
>  	$(ENV) chroot chroot apt-get -y update
>  	$(ENV) chroot chroot apt-get -y --allow-unauthenticated install initramfs-tools-ubuntu-core linux-firmware xz-utils
>  	mount --bind /proc chroot/proc
Kleber Sacilotto de Souza Dec. 6, 2018, 2:12 p.m. UTC | #3
On 11/23/18 10:57 AM, Wen-chien Jesse Sung wrote:
> BugLink: https://launchpad.net/bugs/1802260
>
> Signed-off-by: Wen-chien Jesse Sung <jesse.sung@canonical.com>
> ---
>  Makefile | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index 7e3ee09..5ef8473 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -78,6 +78,11 @@ all:
>  	fi
>  	mkdir -p chroot/etc/initramfs-tools/conf.d
>  	echo "COMPRESS=lzma" >chroot/etc/initramfs-tools/conf.d/ubuntu-core.conf
> +	if [ "$(DPKG_ARCH)" = "amd64" ]; then \
> +	  echo "nvme" >> chroot/etc/initramfs-tools/modules; \
> +	  echo "usbhid" >> chroot/etc/initramfs-tools/modules; \
> +	  echo "hid-generic" >> chroot/etc/initramfs-tools/modules; \
> +	fi
>  	$(ENV) chroot chroot apt-get -y update
>  	$(ENV) chroot chroot apt-get -y --allow-unauthenticated install initramfs-tools-ubuntu-core linux-firmware xz-utils
>  	mount --bind /proc chroot/proc

Applied to linux-snap/cosmic/master branch.

Thanks,
Kleber
diff mbox series

Patch

diff --git a/Makefile b/Makefile
index 7e3ee09..5ef8473 100644
--- a/Makefile
+++ b/Makefile
@@ -78,6 +78,11 @@  all:
 	fi
 	mkdir -p chroot/etc/initramfs-tools/conf.d
 	echo "COMPRESS=lzma" >chroot/etc/initramfs-tools/conf.d/ubuntu-core.conf
+	if [ "$(DPKG_ARCH)" = "amd64" ]; then \
+	  echo "nvme" >> chroot/etc/initramfs-tools/modules; \
+	  echo "usbhid" >> chroot/etc/initramfs-tools/modules; \
+	  echo "hid-generic" >> chroot/etc/initramfs-tools/modules; \
+	fi
 	$(ENV) chroot chroot apt-get -y update
 	$(ENV) chroot chroot apt-get -y --allow-unauthenticated install initramfs-tools-ubuntu-core linux-firmware xz-utils
 	mount --bind /proc chroot/proc