diff mbox

[TVXZA] UBUNTU: [Packaging] sort ABI files with C.UTF-8 locale

Message ID 20170822141547.20516-1-cascardo@canonical.com
State New
Headers show

Commit Message

Thadeu Lima de Souza Cascardo Aug. 22, 2017, 2:15 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1712345

Whenever we update the ABI files, the files may be sorted in a different
order, even though their contents are the same. That happens because the
system updating the ABI files may use a different locale than the one
that was used previously.

Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
---
 debian/scripts/misc/getabis | 2 ++
 1 file changed, 2 insertions(+)

Comments

Marcelo Henrique Cerri Aug. 22, 2017, 5:48 p.m. UTC | #1
Acked-by: Marcelo Henrique Cerri <marcelo.cerri@canonical.com>
Colin Ian King Aug. 23, 2017, 10:26 a.m. UTC | #2
On 22/08/17 15:15, Thadeu Lima de Souza Cascardo wrote:
> BugLink: https://bugs.launchpad.net/bugs/1712345
> 
> Whenever we update the ABI files, the files may be sorted in a different
> order, even though their contents are the same. That happens because the
> system updating the ABI files may use a different locale than the one
> that was used previously.
> 
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
> ---
>  debian/scripts/misc/getabis | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/debian/scripts/misc/getabis b/debian/scripts/misc/getabis
> index 2aad5ddf392a..c7a0c5fe2321 100755
> --- a/debian/scripts/misc/getabis
> +++ b/debian/scripts/misc/getabis
> @@ -1,5 +1,7 @@
>  #!/bin/bash
>  
> +export LC_ALL=C.UTF-8
> +
>  if [ "$#" != "2" ]; then
>  	echo "Usage: $0 <release> <revision>" 1>&2
>  	exit 1
> 
Seems very reasonable to me.

Acked-by: Colin Ian King <colin.king@canonical.com>
Kleber Sacilotto de Souza Aug. 23, 2017, 10:33 a.m. UTC | #3
On 08/22/17 16:15, Thadeu Lima de Souza Cascardo wrote:
> BugLink: https://bugs.launchpad.net/bugs/1712345
> 
> Whenever we update the ABI files, the files may be sorted in a different
> order, even though their contents are the same. That happens because the
> system updating the ABI files may use a different locale than the one
> that was used previously.
> 
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
> ---
>  debian/scripts/misc/getabis | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/debian/scripts/misc/getabis b/debian/scripts/misc/getabis
> index 2aad5ddf392a..c7a0c5fe2321 100755
> --- a/debian/scripts/misc/getabis
> +++ b/debian/scripts/misc/getabis
> @@ -1,5 +1,7 @@
>  #!/bin/bash
>  
> +export LC_ALL=C.UTF-8
> +
>  if [ "$#" != "2" ]; then
>  	echo "Usage: $0 <release> <revision>" 1>&2
>  	exit 1
> 

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
Seth Forshee Aug. 23, 2017, 12:45 p.m. UTC | #4
On Tue, Aug 22, 2017 at 11:15:47AM -0300, Thadeu Lima de Souza Cascardo wrote:
> BugLink: https://bugs.launchpad.net/bugs/1712345
> 
> Whenever we update the ABI files, the files may be sorted in a different
> order, even though their contents are the same. That happens because the
> system updating the ABI files may use a different locale than the one
> that was used previously.
> 
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>

Applied to artful/master-next and unstable/master, thanks.
Thadeu Lima de Souza Cascardo Aug. 23, 2017, 2:12 p.m. UTC | #5
Applied to trusty, vivid, xenial and zesty master-next branches.

Thanks.
Cascardo.
diff mbox

Patch

diff --git a/debian/scripts/misc/getabis b/debian/scripts/misc/getabis
index 2aad5ddf392a..c7a0c5fe2321 100755
--- a/debian/scripts/misc/getabis
+++ b/debian/scripts/misc/getabis
@@ -1,5 +1,7 @@ 
 #!/bin/bash
 
+export LC_ALL=C.UTF-8
+
 if [ "$#" != "2" ]; then
 	echo "Usage: $0 <release> <revision>" 1>&2
 	exit 1