diff mbox series

UBUNTU: packaging: arm64: disable building the snapdragon flavour

Message ID 1553070719-16911-2-git-send-email-paolo.pisati@canonical.com
State New
Headers show
Series UBUNTU: packaging: arm64: disable building the snapdragon flavour | expand

Commit Message

Paolo Pisati March 20, 2019, 8:31 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1820868

Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
---
 debian.master/rules.d/arm64.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kleber Sacilotto de Souza April 12, 2019, 4:07 p.m. UTC | #1
On 3/20/19 2:31 AM, Paolo Pisati wrote:
> BugLink: https://bugs.launchpad.net/bugs/1820868
> 
> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
> ---
>  debian.master/rules.d/arm64.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/debian.master/rules.d/arm64.mk b/debian.master/rules.d/arm64.mk
> index 999e4ca8..949b544 100644
> --- a/debian.master/rules.d/arm64.mk
> +++ b/debian.master/rules.d/arm64.mk
> @@ -2,7 +2,7 @@ human_arch	= ARMv8
>  build_arch	= arm64
>  header_arch	= arm64
>  defconfig	= defconfig
> -flavours	= generic snapdragon
> +flavours	= generic
>  build_image	= Image.gz
>  kernel_file	= arch/$(build_arch)/boot/Image.gz
>  install_file	= vmlinuz
> 

We'll probably need some more changes on the debian.master directory,
but I'll send those patches in a separate thread.

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
Stefan Bader April 24, 2019, 8:45 a.m. UTC | #2
On 20.03.19 09:31, Paolo Pisati wrote:
> BugLink: https://bugs.launchpad.net/bugs/1820868
> 
> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
> ---

This kind of confusing nack/unnack in one thread method nearly earned you a
missed cycle.  Once NACKed submit to a new thread in future.

-Stefan

>  debian.master/rules.d/arm64.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/debian.master/rules.d/arm64.mk b/debian.master/rules.d/arm64.mk
> index 999e4ca8..949b544 100644
> --- a/debian.master/rules.d/arm64.mk
> +++ b/debian.master/rules.d/arm64.mk
> @@ -2,7 +2,7 @@ human_arch	= ARMv8
>  build_arch	= arm64
>  header_arch	= arm64
>  defconfig	= defconfig
> -flavours	= generic snapdragon
> +flavours	= generic
>  build_image	= Image.gz
>  kernel_file	= arch/$(build_arch)/boot/Image.gz
>  install_file	= vmlinuz
>
Stefan Bader April 24, 2019, 9:02 a.m. UTC | #3
On 20.03.19 09:31, Paolo Pisati wrote:
> BugLink: https://bugs.launchpad.net/bugs/1820868
> 
> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
> ---
>  debian.master/rules.d/arm64.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/debian.master/rules.d/arm64.mk b/debian.master/rules.d/arm64.mk
> index 999e4ca8..949b544 100644
> --- a/debian.master/rules.d/arm64.mk
> +++ b/debian.master/rules.d/arm64.mk
> @@ -2,7 +2,7 @@ human_arch	= ARMv8
>  build_arch	= arm64
>  header_arch	= arm64
>  defconfig	= defconfig
> -flavours	= generic snapdragon
> +flavours	= generic
>  build_image	= Image.gz
>  kernel_file	= arch/$(build_arch)/boot/Image.gz
>  install_file	= vmlinuz
> 
Applied to bionic/master-next. But really, there were multiple parts to this
which seemed to have been sent through multiple threads with unclear topics. If
this ends up being correct you got just lucky.

-Stefan

-Stefan
diff mbox series

Patch

diff --git a/debian.master/rules.d/arm64.mk b/debian.master/rules.d/arm64.mk
index 999e4ca8..949b544 100644
--- a/debian.master/rules.d/arm64.mk
+++ b/debian.master/rules.d/arm64.mk
@@ -2,7 +2,7 @@  human_arch	= ARMv8
 build_arch	= arm64
 header_arch	= arm64
 defconfig	= defconfig
-flavours	= generic snapdragon
+flavours	= generic
 build_image	= Image.gz
 kernel_file	= arch/$(build_arch)/boot/Image.gz
 install_file	= vmlinuz