diff mbox

[Zesty] openvswitch: Set internal device max mtu to ETH_MAX_MTU.

Message ID 1494603603-28263-1-git-send-email-jesse.sung@canonical.com
State New
Headers show

Commit Message

Wen-chien Jesse Sung May 12, 2017, 3:40 p.m. UTC
From: Jarno Rajahalme <jarno@ovn.org>

BugLink: https://launchpad.net/bugs/1679823

Commit 91572088e3fd ("net: use core MTU range checking in core net
infra") changed the openvswitch internal device to use the core net
infra for controlling the MTU range, but failed to actually set the
max_mtu as described in the commit message, which now defaults to
ETH_DATA_LEN.

This patch fixes this by setting max_mtu to ETH_MAX_MTU after
ether_setup() call.

Fixes: 91572088e3fd ("net: use core MTU range checking in core net infra")
Signed-off-by: Jarno Rajahalme <jarno@ovn.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit 425df17ce3a26d98f76e2b6b0af2acf4aeb0b026)
Signed-off-by: Wen-chien Jesse Sung <jesse.sung@canonical.com>
---
 net/openvswitch/vport-internal_dev.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Stefan Bader May 18, 2017, 9:26 a.m. UTC | #1
On 12.05.2017 17:40, Wen-chien Jesse Sung wrote:
> From: Jarno Rajahalme <jarno@ovn.org>
> 
> BugLink: https://launchpad.net/bugs/1679823
> 
> Commit 91572088e3fd ("net: use core MTU range checking in core net
> infra") changed the openvswitch internal device to use the core net
> infra for controlling the MTU range, but failed to actually set the
> max_mtu as described in the commit message, which now defaults to
> ETH_DATA_LEN.
> 
> This patch fixes this by setting max_mtu to ETH_MAX_MTU after
> ether_setup() call.
> 
> Fixes: 91572088e3fd ("net: use core MTU range checking in core net infra")
> Signed-off-by: Jarno Rajahalme <jarno@ovn.org>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> (cherry picked from commit 425df17ce3a26d98f76e2b6b0af2acf4aeb0b026)

This patch is part of the 4.10.16 upstream stable update.

-Stefan

> Signed-off-by: Wen-chien Jesse Sung <jesse.sung@canonical.com>
> ---
>  net/openvswitch/vport-internal_dev.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/net/openvswitch/vport-internal_dev.c b/net/openvswitch/vport-internal_dev.c
> index d5d6cae..695acd2 100644
> --- a/net/openvswitch/vport-internal_dev.c
> +++ b/net/openvswitch/vport-internal_dev.c
> @@ -151,6 +151,8 @@ static void do_setup(struct net_device *netdev)
>  {
>  	ether_setup(netdev);
>  
> +	netdev->max_mtu = ETH_MAX_MTU;
> +
>  	netdev->netdev_ops = &internal_dev_netdev_ops;
>  
>  	netdev->priv_flags &= ~IFF_TX_SKB_SHARING;
>
diff mbox

Patch

diff --git a/net/openvswitch/vport-internal_dev.c b/net/openvswitch/vport-internal_dev.c
index d5d6cae..695acd2 100644
--- a/net/openvswitch/vport-internal_dev.c
+++ b/net/openvswitch/vport-internal_dev.c
@@ -151,6 +151,8 @@  static void do_setup(struct net_device *netdev)
 {
 	ether_setup(netdev);
 
+	netdev->max_mtu = ETH_MAX_MTU;
+
 	netdev->netdev_ops = &internal_dev_netdev_ops;
 
 	netdev->priv_flags &= ~IFF_TX_SKB_SHARING;