diff mbox

[Vivid,1/2] net: usb: cdc_ncm: Adding Dell DW5812 LTE Verizon Mobile Broadband Card

Message ID 1452666025-15916-1-git-send-email-jesse.sung@canonical.com
State New
Headers show

Commit Message

Wen-chien Jesse Sung Jan. 13, 2016, 6:20 a.m. UTC
From: Daniele Palmas <dnlplm@gmail.com>

BugLink: https://launchpad.net/bugs/1533118

Unlike DW5550, Dell DW5812 is a mobile broadband card with no ARP
capabilities: the patch makes this device to use wwan_noarp_info struct

Signed-off-by: Daniele Palmas <dnlplm@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit 670c0d62ea5d16026adde5f3538b1caaa904a909)
Signed-off-by: Wen-chien Jesse Sung <jesse.sung@canonical.com>
Tested-by: Chris Wayne <chris.wayne@canonical.com>
Reviewed-By: AceLan Kao <acelan.kao@canonical.com>
---
 drivers/net/usb/cdc_ncm.c | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Brad Figg Jan. 13, 2016, 7:56 a.m. UTC | #1
On Wed, Jan 13, 2016 at 02:20:24PM +0800, Wen-chien Jesse Sung wrote:
> From: Daniele Palmas <dnlplm@gmail.com>
> 
> BugLink: https://launchpad.net/bugs/1533118
> 
> Unlike DW5550, Dell DW5812 is a mobile broadband card with no ARP
> capabilities: the patch makes this device to use wwan_noarp_info struct
> 
> Signed-off-by: Daniele Palmas <dnlplm@gmail.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> (cherry picked from commit 670c0d62ea5d16026adde5f3538b1caaa904a909)
> Signed-off-by: Wen-chien Jesse Sung <jesse.sung@canonical.com>
> Tested-by: Chris Wayne <chris.wayne@canonical.com>
> Reviewed-By: AceLan Kao <acelan.kao@canonical.com>
> ---
>  drivers/net/usb/cdc_ncm.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
> index 8067b8f..45b73a0 100644
> --- a/drivers/net/usb/cdc_ncm.c
> +++ b/drivers/net/usb/cdc_ncm.c
> @@ -1552,6 +1552,15 @@ static const struct usb_device_id cdc_devs[] = {
>  	  .driver_info = (unsigned long) &wwan_info,
>  	},
>  
> +	/* DW5812 LTE Verizon Mobile Broadband Card
> +	 * Unlike DW5550 this device requires FLAG_NOARP
> +	 */
> +	{ USB_DEVICE_AND_INTERFACE_INFO(0x413c, 0x81bb,
> +		USB_CLASS_COMM,
> +		USB_CDC_SUBCLASS_NCM, USB_CDC_PROTO_NONE),
> +	  .driver_info = (unsigned long)&wwan_noarp_info,
> +	},
> +
>  	/* Dell branded MBM devices like DW5550 */
>  	{ .match_flags = USB_DEVICE_ID_MATCH_INT_INFO
>  		| USB_DEVICE_ID_MATCH_VENDOR,
> -- 
> 2.5.0
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Clean cherry-pick.

The bug needs to be updated with the fact that these patches have been
tested and work as desired.
Stefan Bader Jan. 13, 2016, 10:22 a.m. UTC | #2
Patches look ok. Just a bit confused why this is Vivid only when the patches are
upstream with 4.4. Should this not go into Wily(4.2), too?

-Stefan
Luis Henriques Jan. 13, 2016, 3:19 p.m. UTC | #3
Both patches have been applied to Vivid master-next branch.

Cheers,
--
Luís
Kamal Mostafa Jan. 13, 2016, 6 p.m. UTC | #4
Both patches have now also been applied to wily/master-next (thanks for
the heads-up, Stefan).
diff mbox

Patch

diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
index 8067b8f..45b73a0 100644
--- a/drivers/net/usb/cdc_ncm.c
+++ b/drivers/net/usb/cdc_ncm.c
@@ -1552,6 +1552,15 @@  static const struct usb_device_id cdc_devs[] = {
 	  .driver_info = (unsigned long) &wwan_info,
 	},
 
+	/* DW5812 LTE Verizon Mobile Broadband Card
+	 * Unlike DW5550 this device requires FLAG_NOARP
+	 */
+	{ USB_DEVICE_AND_INTERFACE_INFO(0x413c, 0x81bb,
+		USB_CLASS_COMM,
+		USB_CDC_SUBCLASS_NCM, USB_CDC_PROTO_NONE),
+	  .driver_info = (unsigned long)&wwan_noarp_info,
+	},
+
 	/* Dell branded MBM devices like DW5550 */
 	{ .match_flags = USB_DEVICE_ID_MATCH_INT_INFO
 		| USB_DEVICE_ID_MATCH_VENDOR,