From patchwork Wed Jul 15 17:02:08 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kamal Mostafa X-Patchwork-Id: 495913 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 17AC91402AE; Thu, 16 Jul 2015 03:02:25 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1ZFQ4X-0006Nv-ED; Wed, 15 Jul 2015 17:02:17 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1ZFQ4R-0006Ng-Pk for kernel-team@lists.ubuntu.com; Wed, 15 Jul 2015 17:02:11 +0000 Received: from 1.general.kamal.us.vpn ([10.172.68.52]) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1ZFQ4Q-0002Yp-PD; Wed, 15 Jul 2015 17:02:11 +0000 Message-ID: <1436979728.32241.9.camel@fourier> Subject: usb: dwc3: DEPCMD/DGCMD patches for stable From: Kamal Mostafa To: Subbaraya Sundeep Bhatta , Felipe Balbi Date: Wed, 15 Jul 2015 10:02:08 -0700 X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Cc: kernel-team , stable@vger.kernel.org X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: kernel-team-bounces@lists.ubuntu.com Hi Felipe and Subbaraya- I understand that you'd like us to hold off on applying these two to the stable kernels: usb: dwc3: gadget: Fix incorrect DEPCMD and DGCMD status macros usb: dwc3: gadget: return error if command sent to DEPCMD register fails What about this one then?: 891b1dc022955d36cf4c0f42d383226a930db7ed usb: dwc3: gadget: return error if command sent to DGCMD register fails Okay to apply that one to stable, or hold it also? -Kamal From 891b1dc022955d36cf4c0f42d383226a930db7ed Mon Sep 17 00:00:00 2001 From: Subbaraya Sundeep Bhatta Date: Thu, 21 May 2015 15:46:47 +0530 Subject: usb: dwc3: gadget: return error if command sent to DGCMD register fails We need to return error to caller if command is not sent to controller succesfully. Signed-off-by: Subbaraya Sundeep Bhatta Fixes: b09bb64239c8 (usb: dwc3: gadget: implement Global Command support) Cc: #v3.5+ Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/gadget.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 8946c32..fcbe120 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -291,6 +291,8 @@ int dwc3_send_gadget_generic_command(struct dwc3 *dwc, unsigned cmd, u32 param) dwc3_trace(trace_dwc3_gadget, "Command Complete --> %d", DWC3_DGCMD_STATUS(reg)); + if (DWC3_DGCMD_STATUS(reg)) + return -EINVAL; return 0; } -- 1.9.1