diff mbox

[1/1,TRUSTY] UBUNTU: SAUCE: DEP8 test to run our regression tests

Message ID 1414164515-6090-2-git-send-email-brad.figg@canonical.com
State New
Headers show

Commit Message

Brad Figg Oct. 24, 2014, 3:28 p.m. UTC
BugLink: http://bugs.launchpad.net/bugs/1385330

Signed-off-by: Brad Figg <brad.figg@canonical.com>
---
 debian/tests/control                 | 8 ++++++--
 debian/tests/ubuntu-regression-suite | 4 ++++
 2 files changed, 10 insertions(+), 2 deletions(-)
 create mode 100755 debian/tests/ubuntu-regression-suite

Comments

dann frazier Oct. 24, 2014, 3:56 p.m. UTC | #1
On Fri, Oct 24, 2014 at 5:28 PM, Brad Figg <brad.figg@canonical.com> wrote:
> BugLink: http://bugs.launchpad.net/bugs/1385330
>
> Signed-off-by: Brad Figg <brad.figg@canonical.com>
> ---
>  debian/tests/control                 | 8 ++++++--
>  debian/tests/ubuntu-regression-suite | 4 ++++
>  2 files changed, 10 insertions(+), 2 deletions(-)
>  create mode 100755 debian/tests/ubuntu-regression-suite
>
> diff --git a/debian/tests/control b/debian/tests/control
> index eb022dc..49f60ee 100644
> --- a/debian/tests/control
> +++ b/debian/tests/control
> @@ -1,3 +1,7 @@
>  Tests: rebuild
> -Depends: build-essential
> -Restrictions: build-needed
> +Depends: @builddeps@, fakeroot
> +Restrictions: allow-stderr
> +
> +Tests: ubuntu-regression-suite
> +Depends: build-essential, gcc-multilib, gdb, git, bzr
> +Restrictions: allow-stderr, isolation-machine, breaks-testbed
> diff --git a/debian/tests/ubuntu-regression-suite b/debian/tests/ubuntu-regression-suite
> new file mode 100755
> index 0000000..233b771
> --- /dev/null
> +++ b/debian/tests/ubuntu-regression-suite
> @@ -0,0 +1,4 @@
> +#!/bin/sh
> +set -e
> +git clone git://kernel.ubuntu.com/ubuntu/kernel-testing

Do we need to autopkgtest-reboot before starting to ensure we're on
the new kernel?
Does it make sense to put these tests in $ADTTMP instead of the top
level of the kernel source tree?

> +kernel-testing/run-dep8-tests

Has the kernel team considered migrating these tests into the package
so that git connectivity is not required during test?

 -dann

> 1.9.1
>
>
> --
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Brad Figg Oct. 24, 2014, 4:14 p.m. UTC | #2
On 10/24/2014 11:56 AM, Dann Frazier wrote:
> On Fri, Oct 24, 2014 at 5:28 PM, Brad Figg <brad.figg@canonical.com> wrote:
>> BugLink: http://bugs.launchpad.net/bugs/1385330
>>
>> Signed-off-by: Brad Figg <brad.figg@canonical.com>
>> ---
>>  debian/tests/control                 | 8 ++++++--
>>  debian/tests/ubuntu-regression-suite | 4 ++++
>>  2 files changed, 10 insertions(+), 2 deletions(-)
>>  create mode 100755 debian/tests/ubuntu-regression-suite
>>
>> diff --git a/debian/tests/control b/debian/tests/control
>> index eb022dc..49f60ee 100644
>> --- a/debian/tests/control
>> +++ b/debian/tests/control
>> @@ -1,3 +1,7 @@
>>  Tests: rebuild
>> -Depends: build-essential
>> -Restrictions: build-needed
>> +Depends: @builddeps@, fakeroot
>> +Restrictions: allow-stderr
>> +
>> +Tests: ubuntu-regression-suite
>> +Depends: build-essential, gcc-multilib, gdb, git, bzr
>> +Restrictions: allow-stderr, isolation-machine, breaks-testbed
>> diff --git a/debian/tests/ubuntu-regression-suite b/debian/tests/ubuntu-regression-suite
>> new file mode 100755
>> index 0000000..233b771
>> --- /dev/null
>> +++ b/debian/tests/ubuntu-regression-suite
>> @@ -0,0 +1,4 @@
>> +#!/bin/sh
>> +set -e
>> +git clone git://kernel.ubuntu.com/ubuntu/kernel-testing
> 
> Do we need to autopkgtest-reboot before starting to ensure we're on
> the new kernel?
> Does it make sense to put these tests in $ADTTMP instead of the top
> level of the kernel source tree?
> 

I've been assured that the new kernel has been installed and "system"
rebooted before the tests are run.

>> +kernel-testing/run-dep8-tests
> 
> Has the kernel team considered migrating these tests into the package
> so that git connectivity is not required during test?
> 

Yes, that has been considered and rejected. Doing it this way gives us
a great deal of flexibility of what gets run as tests and how the output
is examined for failure.

We make use of autotest client tests and want to continue to do so.


>  -dann
> 
>> 1.9.1
>>
>>
>> --
>> kernel-team mailing list
>> kernel-team@lists.ubuntu.com
>> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Brad
Chris J Arges Oct. 24, 2014, 4:44 p.m. UTC | #3
On 10/24/2014 10:28 AM, Brad Figg wrote:
> BugLink: http://bugs.launchpad.net/bugs/1385330
> 
> Signed-off-by: Brad Figg <brad.figg@canonical.com>
> ---
>  debian/tests/control                 | 8 ++++++--
>  debian/tests/ubuntu-regression-suite | 4 ++++
>  2 files changed, 10 insertions(+), 2 deletions(-)
>  create mode 100755 debian/tests/ubuntu-regression-suite
> 

I'll ack assuming you've run this on your local machine using:
http://packaging.ubuntu.com/html/auto-pkg-test.html

--chris

> diff --git a/debian/tests/control b/debian/tests/control
> index eb022dc..49f60ee 100644
> --- a/debian/tests/control
> +++ b/debian/tests/control
> @@ -1,3 +1,7 @@
>  Tests: rebuild
> -Depends: build-essential
> -Restrictions: build-needed
> +Depends: @builddeps@, fakeroot
> +Restrictions: allow-stderr
> +
> +Tests: ubuntu-regression-suite
> +Depends: build-essential, gcc-multilib, gdb, git, bzr
> +Restrictions: allow-stderr, isolation-machine, breaks-testbed
> diff --git a/debian/tests/ubuntu-regression-suite b/debian/tests/ubuntu-regression-suite
> new file mode 100755
> index 0000000..233b771
> --- /dev/null
> +++ b/debian/tests/ubuntu-regression-suite
> @@ -0,0 +1,4 @@
> +#!/bin/sh
> +set -e
> +git clone git://kernel.ubuntu.com/ubuntu/kernel-testing
> +kernel-testing/run-dep8-tests
>
diff mbox

Patch

diff --git a/debian/tests/control b/debian/tests/control
index eb022dc..49f60ee 100644
--- a/debian/tests/control
+++ b/debian/tests/control
@@ -1,3 +1,7 @@ 
 Tests: rebuild
-Depends: build-essential
-Restrictions: build-needed
+Depends: @builddeps@, fakeroot
+Restrictions: allow-stderr
+
+Tests: ubuntu-regression-suite
+Depends: build-essential, gcc-multilib, gdb, git, bzr
+Restrictions: allow-stderr, isolation-machine, breaks-testbed
diff --git a/debian/tests/ubuntu-regression-suite b/debian/tests/ubuntu-regression-suite
new file mode 100755
index 0000000..233b771
--- /dev/null
+++ b/debian/tests/ubuntu-regression-suite
@@ -0,0 +1,4 @@ 
+#!/bin/sh
+set -e
+git clone git://kernel.ubuntu.com/ubuntu/kernel-testing
+kernel-testing/run-dep8-tests