From patchwork Fri Apr 25 05:12:49 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Lee X-Patchwork-Id: 342648 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id AB99714015B; Fri, 25 Apr 2014 15:13:11 +1000 (EST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1WdYRa-0004xq-IT; Fri, 25 Apr 2014 05:13:02 +0000 Received: from mail-pb0-f42.google.com ([209.85.160.42]) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1WdYRU-0004tp-DI for kernel-team@lists.ubuntu.com; Fri, 25 Apr 2014 05:12:56 +0000 Received: by mail-pb0-f42.google.com with SMTP id un15so2791097pbc.1 for ; Thu, 24 Apr 2014 22:12:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id; bh=A/samCScywL8whIep+vPfpLM5AcXwFnaGX6p3LFS9fM=; b=cQI7lwKMkedy1RYM0r7mlpga1OW0NDvzWuWRTyLU0JAclfEjGcYhHu/TJNR2JCn/eH fbavzkWGdjL9arGf7X6EfbBk4O6kyR3kW7gVNYNztKKglL9wRgSTCJXOh2Ywg+adbyMG vENxmCjIHha4nv8S6EwPQNOf07gNKuBo98Vqkloywg4UQj5t4o0j+p6SIppD/Wa2wZa3 6hrM1C4b8G1dGmE+9vN/rbhLtIIgMvYnX2S7dv+NRHC39G/scJ210RpIdcRMkvyXzIbq js1M1iD8pATuo1964MnQM4YlbzryvfptyFLQLvBBKRdi8yMdEDChUx+VNDKTcAwcnGtl W++w== X-Gm-Message-State: ALoCoQnBl3CM0cGBktbLest7iue1hO67VsMGmK+9N+iBGuoEkXDQNqqghRzPplOU/5XP8n+3YVXW X-Received: by 10.66.221.4 with SMTP id qa4mr5239355pac.138.1398402775350; Thu, 24 Apr 2014 22:12:55 -0700 (PDT) Received: from localhost ([116.213.97.190]) by mx.google.com with ESMTPSA id om6sm12938623pbc.43.2014.04.24.22.12.53 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 24 Apr 2014 22:12:54 -0700 (PDT) From: Adam Lee To: kernel-team@lists.ubuntu.com Subject: [Trusty][PATCH] Revert "rtlwifi: rtl8188ee: enable MSI interrupts mode" Date: Fri, 25 Apr 2014 13:12:49 +0800 Message-Id: <1398402769-3005-1-git-send-email-adam.lee@canonical.com> X-Mailer: git-send-email 2.0.0.rc0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: kernel-team-bounces@lists.ubuntu.com BugLink: http://bugs.launchpad.net/bugs/1310512 This reverts commit a076ec451a082f078a4bea28c1342308cb586653. As RealTek's and our testing results, that commit fixed an issue and was safe enough, but users reported it introduced an regression, upstream is trying to figure it out. So, let's fallback first until RTL8188EE's MSI support gets good compatibility.(Code reviewed and tested, revert only that commit is enough.) Signed-off-by: Adam Lee Acked-by: Andy Whitcroft --- drivers/net/wireless/rtlwifi/rtl8188ee/sw.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/rtlwifi/rtl8188ee/sw.c b/drivers/net/wireless/rtlwifi/rtl8188ee/sw.c index 1b4101b..347af1e 100644 --- a/drivers/net/wireless/rtlwifi/rtl8188ee/sw.c +++ b/drivers/net/wireless/rtlwifi/rtl8188ee/sw.c @@ -93,7 +93,6 @@ int rtl88e_init_sw_vars(struct ieee80211_hw *hw) u8 tid; rtl8188ee_bt_reg_init(hw); - rtlpci->msi_support = true; rtlpriv->dm.dm_initialgain_enable = 1; rtlpriv->dm.dm_flag = 0;