| Message ID | 1398402769-3005-1-git-send-email-adam.lee@canonical.com |
|---|---|
| State | New |
| Headers | show |
On Fri, Apr 25, 2014 at 01:12:49PM +0800, Adam Lee wrote: > BugLink: http://bugs.launchpad.net/bugs/1310512 > > This reverts commit a076ec451a082f078a4bea28c1342308cb586653. > > As RealTek's and our testing results, that commit fixed an issue and was > safe enough, but users reported it introduced an regression, upstream is > trying to figure it out. So, let's fallback first until RTL8188EE's MSI > support gets good compatibility.(Code reviewed and tested, revert only > that commit is enough.) > > Signed-off-by: Adam Lee <adam.lee@canonical.com> > --- > drivers/net/wireless/rtlwifi/rtl8188ee/sw.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/wireless/rtlwifi/rtl8188ee/sw.c b/drivers/net/wireless/rtlwifi/rtl8188ee/sw.c > index 1b4101b..347af1e 100644 > --- a/drivers/net/wireless/rtlwifi/rtl8188ee/sw.c > +++ b/drivers/net/wireless/rtlwifi/rtl8188ee/sw.c > @@ -93,7 +93,6 @@ int rtl88e_init_sw_vars(struct ieee80211_hw *hw) > u8 tid; > > rtl8188ee_bt_reg_init(hw); > - rtlpci->msi_support = true; > > rtlpriv->dm.dm_initialgain_enable = 1; > rtlpriv->dm.dm_flag = 0; Seems to be simple, and do what is claimed. Testing in the original bug seems unclear at best. So: Acked-by: Andy Whitcroft <apw@canonical.com> -apw
diff --git a/drivers/net/wireless/rtlwifi/rtl8188ee/sw.c b/drivers/net/wireless/rtlwifi/rtl8188ee/sw.c index 1b4101b..347af1e 100644 --- a/drivers/net/wireless/rtlwifi/rtl8188ee/sw.c +++ b/drivers/net/wireless/rtlwifi/rtl8188ee/sw.c @@ -93,7 +93,6 @@ int rtl88e_init_sw_vars(struct ieee80211_hw *hw) u8 tid; rtl8188ee_bt_reg_init(hw); - rtlpci->msi_support = true; rtlpriv->dm.dm_initialgain_enable = 1; rtlpriv->dm.dm_flag = 0;
BugLink: http://bugs.launchpad.net/bugs/1310512 This reverts commit a076ec451a082f078a4bea28c1342308cb586653. As RealTek's and our testing results, that commit fixed an issue and was safe enough, but users reported it introduced an regression, upstream is trying to figure it out. So, let's fallback first until RTL8188EE's MSI support gets good compatibility.(Code reviewed and tested, revert only that commit is enough.) Signed-off-by: Adam Lee <adam.lee@canonical.com> --- drivers/net/wireless/rtlwifi/rtl8188ee/sw.c | 1 - 1 file changed, 1 deletion(-)