From patchwork Wed Jun 9 08:35:51 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ike Panhc X-Patchwork-Id: 55057 X-Patchwork-Delegate: stefan.bader@canonical.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from chlorine.canonical.com (chlorine.canonical.com [91.189.94.204]) by ozlabs.org (Postfix) with ESMTP id E0C33B7D61 for ; Wed, 9 Jun 2010 18:36:06 +1000 (EST) Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com) by chlorine.canonical.com with esmtp (Exim 4.69) (envelope-from ) id 1OMGlU-0001ot-AM; Wed, 09 Jun 2010 09:36:00 +0100 Received: from adelie.canonical.com ([91.189.90.139]) by chlorine.canonical.com with esmtp (Exim 4.69) (envelope-from ) id 1OMGlT-0001od-4s for kernel-team@lists.ubuntu.com; Wed, 09 Jun 2010 09:35:59 +0100 Received: from hutte.canonical.com ([91.189.90.181]) by adelie.canonical.com with esmtp (Exim 4.69 #1 (Debian)) id 1OMGlR-00060J-T7 for ; Wed, 09 Jun 2010 09:35:58 +0100 Received: from [210.242.151.101] (helo=canonical.com) by hutte.canonical.com with esmtpsa (TLS-1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.69) (envelope-from ) id 1OMGlQ-00059f-Vq for kernel-team@lists.ubuntu.com; Wed, 09 Jun 2010 09:35:57 +0100 From: Ike Panhc To: kernel-team@lists.ubuntu.com Subject: Date: Wed, 9 Jun 2010 16:35:51 +0800 Message-Id: <1276072551-19182-1-git-send-email-ike.pan@canonical.com> X-Mailer: git-send-email 1.7.0.4 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.9 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: kernel-team-bounces@lists.ubuntu.com Errors-To: kernel-team-bounces@lists.ubuntu.com This patch is going to fix the compile error on Hardy netbook-lpia branch after rebase the lastest Hardy master branch. Though CONFIG_LGUEST_GUEST is not set on Hardy master branch, it is still good for a fix if someone want to enable this config with Hardy master branch and compile his own kernel. Please ACK/NAK for Hardy netbook-lpia branch and master branch. ======== 8< ======== The following changes since commit f939e8b6e0f2e9bdc3c7f0fdea1721ab234b7fb1: Ike Panhc (1): UBUNTU: Rebased to 2.6.24-28.70 are available in the git repository at: git://kernel.ubuntu.com/ikepanhc/hardy-kernel/.git fix-netbook-lpia Ike Panhc (1): UBUNTU: SAUCE: Fix compile error on arch/x86/lguest/boot.c arch/x86/lguest/boot.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) ======== 8< ======== From c7919f4207dfe63b28bc1a74b3525d6ddf492996 Mon Sep 17 00:00:00 2001 From: Ike Panhc Date: Wed, 9 Jun 2010 15:33:44 +0800 Subject: [PATCH] UBUNTU: SAUCE: Fix compile error on arch/x86/lguest/boot.c IMPACT: Commit 434e71 'virtio: explicit advertisement of driver features' which add a new inline function virtio_has_feature() in include/linux/virtio_config.h causes compile failed when CONFIG_LGUEST_GUEST=y. In virtio_config.h:91, variable features in 'struct virtio_device' is called for test_bit. Without including linux/virtio.h in arch/x86/lguest/boot.c, when 'CC arch/x86/lguest/boot.c', compiler do not know what is 'struct virtio_device' and return with error. Ubuntu-hardy master branch do not affected because CONFIG_LGUEST_GUEST is not set. FIX: Upstream has the fix with change config from little-endian only to guest endian (commit 72e61e). Since netbook-lpia branch is little-endian only, adding header file for lguest seems a simpler and better solution. This patch is going to add '#include ' before virtio_console.h in arch/x86/lguest/boot.c TEST: Build successfully after this patch added. Signed-off-by: Ike Panhc --- arch/x86/lguest/boot.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/x86/lguest/boot.c b/arch/x86/lguest/boot.c index d6b18e2..bc8e0df 100644 --- a/arch/x86/lguest/boot.c +++ b/arch/x86/lguest/boot.c @@ -55,6 +55,7 @@ #include #include #include +#include #include #include #include