diff mbox

[Upstream] USB: Add ids of SamsungYP-M1 to restrict max sector

Message ID 1270645176-4443-1-git-send-email-surbhi.palande@canonical.com
State Rejected
Delegated to: Stefan Bader
Headers show

Commit Message

Surbhi Palande April 7, 2010, 12:59 p.m. UTC 
This quirk fixes bug 503790 on launchpad where a user complained of having to
manually set the max sectors for a USB thumb drive to make it work. This small
quirk sets the sector size explicitly in the kernel code. This patch is tested
by the reporter of the bug. Do consider merging this for Lucid.

From 13a918b7c5917a702f14eaa938f10194417482ba Mon Sep 17 00:00:00 2001
From: Surbhi Palande <surbhi.palande@canonical.com>
Date: Fri, 19 Mar 2010 15:58:29 +0200
Subject: [PATCH] USB: Add ids of SamsungYP-M1 to restrict max sectors

http://launchpad.net/bugs/503790

The Samsung YP-M1 does not work unless the following is done manually "echo
128 > /sys/block/sdb/device/max_sectors" as root. This quirk fixes having to
do this manually.

BugLink: http://launchpad.net/bugs/lp503790

Signed-off-by: Surbhi Palande <surbhi.palande@canonical.com>
---
 drivers/usb/storage/unusual_devs.h |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

Comments

Leann Ogasawara April 8, 2010, 7:02 p.m. UTC | #1 
On Wed, 2010-04-07 at 15:59 +0300, Surbhi Palande wrote:
> This quirk fixes bug 503790 on launchpad where a user complained of having to
> manually set the max sectors for a USB thumb drive to make it work. This small
> quirk sets the sector size explicitly in the kernel code. This patch is tested
> by the reporter of the bug. Do consider merging this for Lucid.
> 
> From 13a918b7c5917a702f14eaa938f10194417482ba Mon Sep 17 00:00:00 2001
> From: Surbhi Palande <surbhi.palande@canonical.com>
> Date: Fri, 19 Mar 2010 15:58:29 +0200
> Subject: [PATCH] USB: Add ids of SamsungYP-M1 to restrict max sectors
> 
> http://launchpad.net/bugs/503790

Missing "BugLink:" prefix.

> The Samsung YP-M1 does not work unless the following is done manually "echo
> 128 > /sys/block/sdb/device/max_sectors" as root. This quirk fixes having to
> do this manually.
> 
> BugLink: http://launchpad.net/bugs/lp503790

We probably don't need the bug link listed twice in the commit. And this
url is invalid anyways.

> Signed-off-by: Surbhi Palande <surbhi.palande@canonical.com>

Has this been submitted upstream as well?  Seems this should be
something that would also qualify for stable.

Thanks,
Leann

> ---
>  drivers/usb/storage/unusual_devs.h |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
> index f6ab789..6469673 100644
> --- a/drivers/usb/storage/unusual_devs.h
> +++ b/drivers/usb/storage/unusual_devs.h
> @@ -133,6 +133,13 @@ UNUSUAL_DEV(  0x0419, 0xaace, 0x0100, 0x0100,
>  		US_SC_DEVICE, US_PR_DEVICE, NULL,
>  		US_FL_IGNORE_RESIDUE ),
>  
> +/* Reported by Surbhi Palande <surbhi.palande@canonical.com> */
> +UNUSUAL_DEV(  0x04e8, 0x5123, 0x0000, 0x0000,
> +		"Samsung",
> +		"YP-M1",
> +		US_SC_DEVICE, US_PR_DEVICE, NULL,
> +		US_FL_MAX_SECTORS_64),
> +
>  /* Reported by Christian Leber <christian@leber.de> */
>  UNUSUAL_DEV(  0x0419, 0xaaf5, 0x0100, 0x0100,
>  		"TrekStor",
> -- 
> 1.6.3.3
> 
>
Stefan Bader April 12, 2010, 2:11 p.m. UTC | #2 
Surbhi Palande wrote:
> This quirk fixes bug 503790 on launchpad where a user complained of having to
> manually set the max sectors for a USB thumb drive to make it work. This small
> quirk sets the sector size explicitly in the kernel code. This patch is tested
> by the reporter of the bug. Do consider merging this for Lucid.
> 
> From 13a918b7c5917a702f14eaa938f10194417482ba Mon Sep 17 00:00:00 2001
> From: Surbhi Palande <surbhi.palande@canonical.com>
> Date: Fri, 19 Mar 2010 15:58:29 +0200
> Subject: [PATCH] USB: Add ids of SamsungYP-M1 to restrict max sectors
> 
> http://launchpad.net/bugs/503790
> 
> The Samsung YP-M1 does not work unless the following is done manually "echo
> 128 > /sys/block/sdb/device/max_sectors" as root. This quirk fixes having to
> do this manually.
> 
> BugLink: http://launchpad.net/bugs/lp503790
> 
> Signed-off-by: Surbhi Palande <surbhi.palande@canonical.com>
> ---
>  drivers/usb/storage/unusual_devs.h |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
> index f6ab789..6469673 100644
> --- a/drivers/usb/storage/unusual_devs.h
> +++ b/drivers/usb/storage/unusual_devs.h
> @@ -133,6 +133,13 @@ UNUSUAL_DEV(  0x0419, 0xaace, 0x0100, 0x0100,
>  		US_SC_DEVICE, US_PR_DEVICE, NULL,
>  		US_FL_IGNORE_RESIDUE ),
>  

> +/* Reported by Surbhi Palande <surbhi.palande@canonical.com> */

In addition to what Leann said (as you tag the patch upstream, I assume you have
sent it upstream, right? Have you checked to apply it to 2.6.32.y and 2.6.33.y
and if good, added cc: stable@kernel.org?), I also would not put your name here
but José's name as he reported the problem.

> +UNUSUAL_DEV(  0x04e8, 0x5123, 0x0000, 0x0000,
> +		"Samsung",
> +		"YP-M1",
> +		US_SC_DEVICE, US_PR_DEVICE, NULL,
> +		US_FL_MAX_SECTORS_64),
> +
>  /* Reported by Christian Leber <christian@leber.de> */
>  UNUSUAL_DEV(  0x0419, 0xaaf5, 0x0100, 0x0100,
>  		"TrekStor",
Andy Whitcroft April 22, 2010, 6:05 p.m. UTC | #3 
On Wed, Apr 07, 2010 at 03:59:36PM +0300, Surbhi Palande wrote:
> This quirk fixes bug 503790 on launchpad where a user complained of having to
> manually set the max sectors for a USB thumb drive to make it work. This small
> quirk sets the sector size explicitly in the kernel code. This patch is tested
> by the reporter of the bug. Do consider merging this for Lucid.
> 
> From 13a918b7c5917a702f14eaa938f10194417482ba Mon Sep 17 00:00:00 2001
> From: Surbhi Palande <surbhi.palande@canonical.com>
> Date: Fri, 19 Mar 2010 15:58:29 +0200
> Subject: [PATCH] USB: Add ids of SamsungYP-M1 to restrict max sectors
> 
> http://launchpad.net/bugs/503790
> 
> The Samsung YP-M1 does not work unless the following is done manually "echo
> 128 > /sys/block/sdb/device/max_sectors" as root. This quirk fixes having to
> do this manually.
> 
> BugLink: http://launchpad.net/bugs/lp503790
> 
> Signed-off-by: Surbhi Palande <surbhi.palande@canonical.com>
> ---
>  drivers/usb/storage/unusual_devs.h |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
> index f6ab789..6469673 100644
> --- a/drivers/usb/storage/unusual_devs.h
> +++ b/drivers/usb/storage/unusual_devs.h
> @@ -133,6 +133,13 @@ UNUSUAL_DEV(  0x0419, 0xaace, 0x0100, 0x0100,
>  		US_SC_DEVICE, US_PR_DEVICE, NULL,
>  		US_FL_IGNORE_RESIDUE ),
>  
> +/* Reported by Surbhi Palande <surbhi.palande@canonical.com> */
> +UNUSUAL_DEV(  0x04e8, 0x5123, 0x0000, 0x0000,
> +		"Samsung",
> +		"YP-M1",
> +		US_SC_DEVICE, US_PR_DEVICE, NULL,
> +		US_FL_MAX_SECTORS_64),
> +

I thought that these entries were in id order?  Could you confirm and if
so move it to the right place :).

>  /* Reported by Christian Leber <christian@leber.de> */
>  UNUSUAL_DEV(  0x0419, 0xaaf5, 0x0100, 0x0100,
>  		"TrekStor",

-apw
Stefan Bader April 30, 2010, 9:44 a.m. UTC | #4 
Andy Whitcroft wrote:
> On Wed, Apr 07, 2010 at 03:59:36PM +0300, Surbhi Palande wrote:
>> This quirk fixes bug 503790 on launchpad where a user complained of having to
>> manually set the max sectors for a USB thumb drive to make it work. This small
>> quirk sets the sector size explicitly in the kernel code. This patch is tested
>> by the reporter of the bug. Do consider merging this for Lucid.
>>
>> From 13a918b7c5917a702f14eaa938f10194417482ba Mon Sep 17 00:00:00 2001
>> From: Surbhi Palande <surbhi.palande@canonical.com>
>> Date: Fri, 19 Mar 2010 15:58:29 +0200
>> Subject: [PATCH] USB: Add ids of SamsungYP-M1 to restrict max sectors
>>
>> http://launchpad.net/bugs/503790
>>
>> The Samsung YP-M1 does not work unless the following is done manually "echo
>> 128 > /sys/block/sdb/device/max_sectors" as root. This quirk fixes having to
>> do this manually.
>>
>> BugLink: http://launchpad.net/bugs/lp503790
>>
>> Signed-off-by: Surbhi Palande <surbhi.palande@canonical.com>
>> ---
>>  drivers/usb/storage/unusual_devs.h |    7 +++++++
>>  1 files changed, 7 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
>> index f6ab789..6469673 100644
>> --- a/drivers/usb/storage/unusual_devs.h
>> +++ b/drivers/usb/storage/unusual_devs.h
>> @@ -133,6 +133,13 @@ UNUSUAL_DEV(  0x0419, 0xaace, 0x0100, 0x0100,
>>  		US_SC_DEVICE, US_PR_DEVICE, NULL,
>>  		US_FL_IGNORE_RESIDUE ),
>>  
>> +/* Reported by Surbhi Palande <surbhi.palande@canonical.com> */
>> +UNUSUAL_DEV(  0x04e8, 0x5123, 0x0000, 0x0000,
>> +		"Samsung",
>> +		"YP-M1",
>> +		US_SC_DEVICE, US_PR_DEVICE, NULL,
>> +		US_FL_MAX_SECTORS_64),
>> +
> 
> I thought that these entries were in id order?  Could you confirm and if
> so move it to the right place :).
> 

There has not been any response to this. Surbhi, if the other quirks are
ordered, could you resend a patch that inserts it into the right place?

Stefan

>>  /* Reported by Christian Leber <christian@leber.de> */
>>  UNUSUAL_DEV(  0x0419, 0xaaf5, 0x0100, 0x0100,
>>  		"TrekStor",
> 
> -apw
>
Brad Figg Sept. 13, 2010, 5:13 p.m. UTC | #5 
On 04/30/2010 02:44 AM, Stefan Bader wrote:
> Andy Whitcroft wrote:
>> On Wed, Apr 07, 2010 at 03:59:36PM +0300, Surbhi Palande wrote:
>>> This quirk fixes bug 503790 on launchpad where a user complained of having to
>>> manually set the max sectors for a USB thumb drive to make it work. This small
>>> quirk sets the sector size explicitly in the kernel code. This patch is tested
>>> by the reporter of the bug. Do consider merging this for Lucid.
>>>
>>>  From 13a918b7c5917a702f14eaa938f10194417482ba Mon Sep 17 00:00:00 2001
>>> From: Surbhi Palande<surbhi.palande@canonical.com>
>>> Date: Fri, 19 Mar 2010 15:58:29 +0200
>>> Subject: [PATCH] USB: Add ids of SamsungYP-M1 to restrict max sectors
>>>
>>> http://launchpad.net/bugs/503790
>>>
>>> The Samsung YP-M1 does not work unless the following is done manually "echo
>>> 128>  /sys/block/sdb/device/max_sectors" as root. This quirk fixes having to
>>> do this manually.
>>>
>>> BugLink: http://launchpad.net/bugs/lp503790
>>>
>>> Signed-off-by: Surbhi Palande<surbhi.palande@canonical.com>
>>> ---
>>>   drivers/usb/storage/unusual_devs.h |    7 +++++++
>>>   1 files changed, 7 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
>>> index f6ab789..6469673 100644
>>> --- a/drivers/usb/storage/unusual_devs.h
>>> +++ b/drivers/usb/storage/unusual_devs.h
>>> @@ -133,6 +133,13 @@ UNUSUAL_DEV(  0x0419, 0xaace, 0x0100, 0x0100,
>>>   		US_SC_DEVICE, US_PR_DEVICE, NULL,
>>>   		US_FL_IGNORE_RESIDUE ),
>>>
>>> +/* Reported by Surbhi Palande<surbhi.palande@canonical.com>  */
>>> +UNUSUAL_DEV(  0x04e8, 0x5123, 0x0000, 0x0000,
>>> +		"Samsung",
>>> +		"YP-M1",
>>> +		US_SC_DEVICE, US_PR_DEVICE, NULL,
>>> +		US_FL_MAX_SECTORS_64),
>>> +
>>
>> I thought that these entries were in id order?  Could you confirm and if
>> so move it to the right place :).
>>
>
> There has not been any response to this. Surbhi, if the other quirks are
> ordered, could you resend a patch that inserts it into the right place?
>
> Stefan
>
>>>   /* Reported by Christian Leber<christian@leber.de>  */
>>>   UNUSUAL_DEV(  0x0419, 0xaaf5, 0x0100, 0x0100,
>>>   		"TrekStor",
>>
>> -apw
>>
>
>

Surbhi,

Please resubmit this patch if it is still relevant, addressing the issues
others have mentioned.

Brad
Surbhi Palande Sept. 22, 2010, 3:39 p.m. UTC | #6 
Hi,

I have not sent the patch upstream yet. I will rewrite the patch with 
all the corrections and send it upstream and here as well. Thanks a lot 
for the review!

Warm Regards,
Surbhi.

On 09/13/2010 08:13 PM, Brad Figg wrote:
> On 04/30/2010 02:44 AM, Stefan Bader wrote:
>> Andy Whitcroft wrote:
>>> On Wed, Apr 07, 2010 at 03:59:36PM +0300, Surbhi Palande wrote:
>>>> This quirk fixes bug 503790 on launchpad where a user complained of
>>>> having to
>>>> manually set the max sectors for a USB thumb drive to make it work.
>>>> This small
>>>> quirk sets the sector size explicitly in the kernel code. This patch
>>>> is tested
>>>> by the reporter of the bug. Do consider merging this for Lucid.
>>>>
>>>> From 13a918b7c5917a702f14eaa938f10194417482ba Mon Sep 17 00:00:00 2001
>>>> From: Surbhi Palande<surbhi.palande@canonical.com>
>>>> Date: Fri, 19 Mar 2010 15:58:29 +0200
>>>> Subject: [PATCH] USB: Add ids of SamsungYP-M1 to restrict max sectors
>>>>
>>>> http://launchpad.net/bugs/503790
>>>>
>>>> The Samsung YP-M1 does not work unless the following is done
>>>> manually "echo
>>>> 128> /sys/block/sdb/device/max_sectors" as root. This quirk fixes
>>>> having to
>>>> do this manually.
>>>>
>>>> BugLink: http://launchpad.net/bugs/lp503790
>>>>
>>>> Signed-off-by: Surbhi Palande<surbhi.palande@canonical.com>
>>>> ---
>>>> drivers/usb/storage/unusual_devs.h | 7 +++++++
>>>> 1 files changed, 7 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/drivers/usb/storage/unusual_devs.h
>>>> b/drivers/usb/storage/unusual_devs.h
>>>> index f6ab789..6469673 100644
>>>> --- a/drivers/usb/storage/unusual_devs.h
>>>> +++ b/drivers/usb/storage/unusual_devs.h
>>>> @@ -133,6 +133,13 @@ UNUSUAL_DEV( 0x0419, 0xaace, 0x0100, 0x0100,
>>>> US_SC_DEVICE, US_PR_DEVICE, NULL,
>>>> US_FL_IGNORE_RESIDUE ),
>>>>
>>>> +/* Reported by Surbhi Palande<surbhi.palande@canonical.com> */
>>>> +UNUSUAL_DEV( 0x04e8, 0x5123, 0x0000, 0x0000,
>>>> + "Samsung",
>>>> + "YP-M1",
>>>> + US_SC_DEVICE, US_PR_DEVICE, NULL,
>>>> + US_FL_MAX_SECTORS_64),
>>>> +
>>>
>>> I thought that these entries were in id order? Could you confirm and if
>>> so move it to the right place :).
>>>
>>
>> There has not been any response to this. Surbhi, if the other quirks are
>> ordered, could you resend a patch that inserts it into the right place?
>>
>> Stefan
>>
>>>> /* Reported by Christian Leber<christian@leber.de> */
>>>> UNUSUAL_DEV( 0x0419, 0xaaf5, 0x0100, 0x0100,
>>>> "TrekStor",
>>>
>>> -apw
>>>
>>
>>
>
> Surbhi,
>
> Please resubmit this patch if it is still relevant, addressing the issues
> others have mentioned.
>
> Brad
diff mbox

Patch

diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
index f6ab789..6469673 100644
--- a/drivers/usb/storage/unusual_devs.h
+++ b/drivers/usb/storage/unusual_devs.h
@@ -133,6 +133,13 @@  UNUSUAL_DEV(  0x0419, 0xaace, 0x0100, 0x0100,
 		US_SC_DEVICE, US_PR_DEVICE, NULL,
 		US_FL_IGNORE_RESIDUE ),
 
+/* Reported by Surbhi Palande <surbhi.palande@canonical.com> */
+UNUSUAL_DEV(  0x04e8, 0x5123, 0x0000, 0x0000,
+		"Samsung",
+		"YP-M1",
+		US_SC_DEVICE, US_PR_DEVICE, NULL,
+		US_FL_MAX_SECTORS_64),
+
 /* Reported by Christian Leber <christian@leber.de> */
 UNUSUAL_DEV(  0x0419, 0xaaf5, 0x0100, 0x0100,
 		"TrekStor",