From patchwork Mon Feb 1 06:47:25 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerone Young X-Patchwork-Id: 44166 X-Patchwork-Delegate: stefan.bader@canonical.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from chlorine.canonical.com (chlorine.canonical.com [91.189.94.204]) by ozlabs.org (Postfix) with ESMTP id F2AE5B7DE1 for ; Mon, 1 Feb 2010 17:48:00 +1100 (EST) Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com) by chlorine.canonical.com with esmtp (Exim 4.69) (envelope-from ) id 1Nbq4H-0006Xr-Lm; Mon, 01 Feb 2010 06:47:29 +0000 Received: from adelie.canonical.com ([91.189.90.139]) by chlorine.canonical.com with esmtp (Exim 4.69) (envelope-from ) id 1Nbq4G-0006XX-AQ for kernel-team@lists.ubuntu.com; Mon, 01 Feb 2010 06:47:28 +0000 Received: from hutte.canonical.com ([91.189.90.181]) by adelie.canonical.com with esmtp (Exim 4.69 #1 (Debian)) id 1Nbq4G-0007IA-95 for ; Mon, 01 Feb 2010 06:47:28 +0000 Received: from adsl-71-145-133-119.dsl.austtx.sbcglobal.net ([71.145.133.119] helo=[192.168.1.6]) by hutte.canonical.com with esmtpsa (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1Nbq4F-00022j-UF for kernel-team@lists.ubuntu.com; Mon, 01 Feb 2010 06:47:28 +0000 Subject: [SRU] [Karmic] fix volume hotkeys for Dell Studio 1557 From: Jerone Young To: Kernel team list Date: Mon, 01 Feb 2010 00:47:25 -0600 Message-ID: <1265006845.2665.604.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.9 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kernel-team-bounces@lists.ubuntu.com Errors-To: kernel-team-bounces@lists.ubuntu.com Impact: On the Dell Studio 1557 if you press any of the volume keys they will not give a release and press infinitely. https://bugs.launchpad.net/bugs/465250 Fix: Patch attached adds quirk to fix hotkeys for 2.6.31. Though for 2.6.32 & upstream this fix is expected to go into udev. Though Lucid has not pulled in a recent version supporting this functionality. Testcase: Pressing volume keys will not infinitely generate key presses. Fix volume hotkeys for Dell Studio 1157 generating infinite key presses. Signed-off-by: Jerone Young Acked-by: Stefan Bader diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c index 950673f..af1744d 100644 --- a/drivers/input/keyboard/atkbd.c +++ b/drivers/input/keyboard/atkbd.c @@ -857,6 +857,14 @@ static unsigned int atkbd_dell_laptop_forced_release_keys[] = { }; /* + * Dell Studio 1557 does not generate release keys for + * mute, volume up, & volume down + */ +static unsigned int atkdb_dell_studio_1157_force_relase_keys[] = { + 0xa0, 0xae, 0xb0, -1U +}; + +/* * Perform fixup for HP system that doesn't generate release * for its video switch */ @@ -1542,6 +1550,15 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = { .driver_data = atkbd_dell_laptop_forced_release_keys, }, { + .ident = "Dell Stuido 1557", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "Studio 1557"), + }, + .callback = atkbd_setup_forced_release, + .driver_data = atkdb_dell_studio_1157_force_relase_keys, + }, + { .ident = "HP 2133", .matches = { DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),