mbox series

[SRU,J:linux-bluefield,v2,0/1] UBUNTU: SAUCE: mlxbf-tmfifo.c: amend previous patch

Message ID cover.1689880710.git.shihyic@nvidia.com
Headers show
Series UBUNTU: SAUCE: mlxbf-tmfifo.c: amend previous patch | expand

Message

shihyic July 20, 2023, 7:26 p.m. UTC 
BugLink: https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/2028197

SRU Justification:

[Impact]

mlxbf_tmfifo driver does not always schedule work for VIRTIO CONSOLE nottification. The result is with rshim console, the dmesg output would be cut off or simply cat a big text file to stdout.

[Fix]

* Make sure TM_TX_LWM_IRQ bit is set when there is a notification of virtio console event.

[Test Case]

* Compare the output of dmesg from rshim console and ssh session. Make sure both are the same.
* Issue is reproduced w/o fix and compare the same dmesg output from the same as above.

[Regression Potential]

The changes affect only virtio console event handling only and been tested fully.

[Others]
This issue is the same on focal and Jammy.


shihyic (1):
  Amend previous tmfifo patch w/ regard to schedule_work

 drivers/platform/mellanox/mlxbf-tmfifo.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Bartlomiej Zolnierkiewicz July 21, 2023, 9:21 a.m. UTC | #1 
On Thu, Jul 20, 2023 at 9:27 PM shihyic <shihyic@nvidia.com> wrote:
>
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/2028197
>
> SRU Justification:
>
> [Impact]
>
> mlxbf_tmfifo driver does not always schedule work for VIRTIO CONSOLE nottification. The result is with rshim console, the dmesg output would be cut off or simply cat a big text file to stdout.
>
> [Fix]
>
> * Make sure TM_TX_LWM_IRQ bit is set when there is a notification of virtio console event.
>
> [Test Case]
>
> * Compare the output of dmesg from rshim console and ssh session. Make sure both are the same.
> * Issue is reproduced w/o fix and compare the same dmesg output from the same as above.
>
> [Regression Potential]
>
> The changes affect only virtio console event handling only and been tested fully.
>
> [Others]
> This issue is the same on focal and Jammy.
>
>
> shihyic (1):
>   Amend previous tmfifo patch w/ regard to schedule_work
>
>  drivers/platform/mellanox/mlxbf-tmfifo.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>

Rejected for the following reasons:
There is a v3 of this submission.

--
Best regards,
Bartlomiej