mbox series

[SRU,R,0/2] Follow-ups for v6.18.40/v7.1.5 bugs

Message ID 20260827150134.873855-1-alice.munduruca@canonical.com
Headers show
Series Follow-ups for v6.18.40/v7.1.5 bugs | expand

Message

Alice C. Munduruca Aug. 27, 2026, 3:01 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/2165040

[ Impact ]

Due to infrastructural issues, the validation build for LP#2164666 only built tools
on each architecture, not the whole kernel. As a result, a few build failures have snuck
into the tree which need to be resolved. A list of the broken commits is presented below:

 * d14116da71c9 ("accel/amdxdna: Create shared functions for AIE2 and AIE4")
 * f7688a6921ed ("bpf: Take mmap_lock in zap_pages()")

[ Fix ]

Resolute: Backporting and creation of the following fixes:

 * ece3e8980907 (Move to aie2_free_msg_buffer() function from the previous macro to apply a missing hunk)
 * SAUCE PATCH  (Add missing NULL argument to the zap_page_range_single() function)

(This was done prioritarily in a previous submission to quell build failures)

Given that the first commit above also introduces bugs into the kernel, both
of the following commits are also picked.

140cfee588af ("accel/amdxdna: Return ERR_PTR on dma_alloc_noncoherent failure")
432fafdc9a31 ("accel/amdxdna: Fix memory leak in amdxdna_iommu_alloc()")

[ Testing ]

Compile tested on cloud builders, booted on an AMD CPU laptop. Also ran `xrt-smi validate` to ensure no
major regressions.

[ What could go wrong ]

The patches added in this submission are specific to the AMD NPU drivers and can only affect consumers
of that subsystem. Additionally the patches are well tested upstream and were sanity-tested before
submission, with minimal changes to the contents. (`aie.xdna` vs `xdna` in unrelated context)

Felix Gu (1):
  accel/amdxdna: Fix memory leak in amdxdna_iommu_alloc()

Wendy Liang (1):
  accel/amdxdna: Return ERR_PTR on dma_alloc_noncoherent failure

 drivers/accel/amdxdna/aie2_message.c  | 7 ++++++-
 drivers/accel/amdxdna/amdxdna_iommu.c | 4 +++-
 2 files changed, 9 insertions(+), 2 deletions(-)

Comments

Edoardo Canepa Aug. 27, 2026, 3:03 p.m. UTC | #1
Acked-by: Edoardo Canepa <edoardo.canepa@canonical.com>

On 8/27/26 18:01, Alice C. Munduruca via kernel-team wrote:
> BugLink: https://bugs.launchpad.net/bugs/2165040
>
> [ Impact ]
>
> Due to infrastructural issues, the validation build for LP#2164666 only built tools
> on each architecture, not the whole kernel. As a result, a few build failures have snuck
> into the tree which need to be resolved. A list of the broken commits is presented below:
>
>   * d14116da71c9 ("accel/amdxdna: Create shared functions for AIE2 and AIE4")
>   * f7688a6921ed ("bpf: Take mmap_lock in zap_pages()")
>
> [ Fix ]
>
> Resolute: Backporting and creation of the following fixes:
>
>   * ece3e8980907 (Move to aie2_free_msg_buffer() function from the previous macro to apply a missing hunk)
>   * SAUCE PATCH  (Add missing NULL argument to the zap_page_range_single() function)
>
> (This was done prioritarily in a previous submission to quell build failures)
>
> Given that the first commit above also introduces bugs into the kernel, both
> of the following commits are also picked.
>
> 140cfee588af ("accel/amdxdna: Return ERR_PTR on dma_alloc_noncoherent failure")
> 432fafdc9a31 ("accel/amdxdna: Fix memory leak in amdxdna_iommu_alloc()")
>
> [ Testing ]
>
> Compile tested on cloud builders, booted on an AMD CPU laptop. Also ran `xrt-smi validate` to ensure no
> major regressions.
>
> [ What could go wrong ]
>
> The patches added in this submission are specific to the AMD NPU drivers and can only affect consumers
> of that subsystem. Additionally the patches are well tested upstream and were sanity-tested before
> submission, with minimal changes to the contents. (`aie.xdna` vs `xdna` in unrelated context)
>
> Felix Gu (1):
>    accel/amdxdna: Fix memory leak in amdxdna_iommu_alloc()
>
> Wendy Liang (1):
>    accel/amdxdna: Return ERR_PTR on dma_alloc_noncoherent failure
>
>   drivers/accel/amdxdna/aie2_message.c  | 7 ++++++-
>   drivers/accel/amdxdna/amdxdna_iommu.c | 4 +++-
>   2 files changed, 9 insertions(+), 2 deletions(-)
>
Alessio Faina Aug. 27, 2026, 3:14 p.m. UTC | #2
On Thu, Aug 27, 2026 at 11:01:30AM -0400, Alice C. Munduruca via kernel-team wrote:
> BugLink: https://bugs.launchpad.net/bugs/2165040
> 
> [ Impact ]
> 
> Due to infrastructural issues, the validation build for LP#2164666 only built tools
> on each architecture, not the whole kernel. As a result, a few build failures have snuck
> into the tree which need to be resolved. A list of the broken commits is presented below:
> 
>  * d14116da71c9 ("accel/amdxdna: Create shared functions for AIE2 and AIE4")
>  * f7688a6921ed ("bpf: Take mmap_lock in zap_pages()")
> 
> [ Fix ]
> 
> Resolute: Backporting and creation of the following fixes:
> 
>  * ece3e8980907 (Move to aie2_free_msg_buffer() function from the previous macro to apply a missing hunk)
>  * SAUCE PATCH  (Add missing NULL argument to the zap_page_range_single() function)
> 
> (This was done prioritarily in a previous submission to quell build failures)
> 
> Given that the first commit above also introduces bugs into the kernel, both
> of the following commits are also picked.
> 
> 140cfee588af ("accel/amdxdna: Return ERR_PTR on dma_alloc_noncoherent failure")
> 432fafdc9a31 ("accel/amdxdna: Fix memory leak in amdxdna_iommu_alloc()")
> 
> [ Testing ]
> 
> Compile tested on cloud builders, booted on an AMD CPU laptop. Also ran `xrt-smi validate` to ensure no
> major regressions.
> 
> [ What could go wrong ]
> 
> The patches added in this submission are specific to the AMD NPU drivers and can only affect consumers
> of that subsystem. Additionally the patches are well tested upstream and were sanity-tested before
> submission, with minimal changes to the contents. (`aie.xdna` vs `xdna` in unrelated context)
> 
> Felix Gu (1):
>   accel/amdxdna: Fix memory leak in amdxdna_iommu_alloc()
> 
> Wendy Liang (1):
>   accel/amdxdna: Return ERR_PTR on dma_alloc_noncoherent failure
> 
>  drivers/accel/amdxdna/aie2_message.c  | 7 ++++++-
>  drivers/accel/amdxdna/amdxdna_iommu.c | 4 +++-
>  2 files changed, 9 insertions(+), 2 deletions(-)
> 
> -- 
> 2.53.0
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Acked-by: Alessio Faina <alessio.faina@canonical.com>
Edoardo Canepa Aug. 28, 2026, 7:02 p.m. UTC | #3
Applied to R:linux/master-next. Thanks.

On 8/27/26 18:01, Alice C. Munduruca via kernel-team wrote:
> BugLink: https://bugs.launchpad.net/bugs/2165040
>
> [ Impact ]
>
> Due to infrastructural issues, the validation build for LP#2164666 only built tools
> on each architecture, not the whole kernel. As a result, a few build failures have snuck
> into the tree which need to be resolved. A list of the broken commits is presented below:
>
>   * d14116da71c9 ("accel/amdxdna: Create shared functions for AIE2 and AIE4")
>   * f7688a6921ed ("bpf: Take mmap_lock in zap_pages()")
>
> [ Fix ]
>
> Resolute: Backporting and creation of the following fixes:
>
>   * ece3e8980907 (Move to aie2_free_msg_buffer() function from the previous macro to apply a missing hunk)
>   * SAUCE PATCH  (Add missing NULL argument to the zap_page_range_single() function)
>
> (This was done prioritarily in a previous submission to quell build failures)
>
> Given that the first commit above also introduces bugs into the kernel, both
> of the following commits are also picked.
>
> 140cfee588af ("accel/amdxdna: Return ERR_PTR on dma_alloc_noncoherent failure")
> 432fafdc9a31 ("accel/amdxdna: Fix memory leak in amdxdna_iommu_alloc()")
>
> [ Testing ]
>
> Compile tested on cloud builders, booted on an AMD CPU laptop. Also ran `xrt-smi validate` to ensure no
> major regressions.
>
> [ What could go wrong ]
>
> The patches added in this submission are specific to the AMD NPU drivers and can only affect consumers
> of that subsystem. Additionally the patches are well tested upstream and were sanity-tested before
> submission, with minimal changes to the contents. (`aie.xdna` vs `xdna` in unrelated context)
>
> Felix Gu (1):
>    accel/amdxdna: Fix memory leak in amdxdna_iommu_alloc()
>
> Wendy Liang (1):
>    accel/amdxdna: Return ERR_PTR on dma_alloc_noncoherent failure
>
>   drivers/accel/amdxdna/aie2_message.c  | 7 ++++++-
>   drivers/accel/amdxdna/amdxdna_iommu.c | 4 +++-
>   2 files changed, 9 insertions(+), 2 deletions(-)
>