mbox series

[SRU,J:linux-bluefield,v3,0/1] UBUNTU: SOURCE: Add test script and yaml for dpll

Message ID 20240306200848.54030-1-witu@nvidia.com
Headers show
Series UBUNTU: SOURCE: Add test script and yaml for dpll | expand

Message

William Tu March 6, 2024, 8:08 p.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/2056364

Bug 2053155 "Add DPLL and syncE support" requires using a yaml spec
file, dpll.yaml, and a python script, cli.py, to verify the correctness.
ex:
  $ sudo ./tools/net/ynl/cli.py \
    --spec Documentation/netlink/specs/dpll.yaml \
    --dump device-get

Add the missing files that requires to run the cli.py and dpll.yaml.
---
v3: feedback from Bartlomiej
- fix the format, add "UBUNTU: SOURCE:"
- fix author of the patch, "From: Tony Duan..."
- create new buglink page
- rewrite the commit message

Tony Duan (1):
  UBUNTU: SOURCE: Add test script and yaml for dpll

 Documentation/netlink/genetlink.yaml | 330 ++++++++++
 tools/net/ynl/cli.py                 |  77 +++
 tools/net/ynl/lib/__init__.py        |   8 +
 tools/net/ynl/lib/nlspec.py          | 607 +++++++++++++++++++
 tools/net/ynl/lib/ynl.py             | 873 +++++++++++++++++++++++++++
 5 files changed, 1895 insertions(+)
 create mode 100644 Documentation/netlink/genetlink.yaml
 create mode 100644 tools/net/ynl/cli.py
 create mode 100644 tools/net/ynl/lib/__init__.py
 create mode 100644 tools/net/ynl/lib/nlspec.py
 create mode 100644 tools/net/ynl/lib/ynl.py

Comments

Bartlomiej Zolnierkiewicz March 7, 2024, 5:48 p.m. UTC | #1 
On Wed, Mar 6, 2024 at 9:10 PM William Tu <witu@nvidia.com> wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/2056364
>
> Bug 2053155 "Add DPLL and syncE support" requires using a yaml spec
> file, dpll.yaml, and a python script, cli.py, to verify the correctness.
> ex:
>   $ sudo ./tools/net/ynl/cli.py \
>     --spec Documentation/netlink/specs/dpll.yaml \
>     --dump device-get
>
> Add the missing files that requires to run the cli.py and dpll.yaml.
> ---
> v3: feedback from Bartlomiej

Thank you for correcting the submission.

> - fix the format, add "UBUNTU: SOURCE:"

It should be "UBUNTU: SAUCE:" but it can be fixed while applying.

> - fix author of the patch, "From: Tony Duan..."
> - create new buglink page
> - rewrite the commit message

There should also be information in the description about the upstream
version from which files were copied. However, since I've found out
that files match the next-20240208 branch of -next upstream tree this
can also be fixed while applying.

Acked-by: Bartlomiej Zolnierkiewicz <bartlomiej.zolnierkiewicz@canonical.com>

--
Best regards,
Bartlomiej

> Tony Duan (1):
>   UBUNTU: SOURCE: Add test script and yaml for dpll
>
>  Documentation/netlink/genetlink.yaml | 330 ++++++++++
>  tools/net/ynl/cli.py                 |  77 +++
>  tools/net/ynl/lib/__init__.py        |   8 +
>  tools/net/ynl/lib/nlspec.py          | 607 +++++++++++++++++++
>  tools/net/ynl/lib/ynl.py             | 873 +++++++++++++++++++++++++++
>  5 files changed, 1895 insertions(+)
>  create mode 100644 Documentation/netlink/genetlink.yaml
>  create mode 100644 tools/net/ynl/cli.py
>  create mode 100644 tools/net/ynl/lib/__init__.py
>  create mode 100644 tools/net/ynl/lib/nlspec.py
>  create mode 100644 tools/net/ynl/lib/ynl.py
>
Thibault Ferrante March 8, 2024, 5:24 p.m. UTC | #2 
Acked-by: Thibault Ferrante <thibault.ferrante@canonical.com>


On 06-03-2024 21:08, William Tu wrote:
> BugLink: https://bugs.launchpad.net/bugs/2056364
> 
> Bug 2053155 "Add DPLL and syncE support" requires using a yaml spec
> file, dpll.yaml, and a python script, cli.py, to verify the correctness.
> ex:
>    $ sudo ./tools/net/ynl/cli.py \
>      --spec Documentation/netlink/specs/dpll.yaml \
>      --dump device-get
> 
> Add the missing files that requires to run the cli.py and dpll.yaml.
> ---
> v3: feedback from Bartlomiej
> - fix the format, add "UBUNTU: SOURCE:"
> - fix author of the patch, "From: Tony Duan..."
> - create new buglink page
> - rewrite the commit message
> 
> Tony Duan (1):
>    UBUNTU: SOURCE: Add test script and yaml for dpll
> 
>   Documentation/netlink/genetlink.yaml | 330 ++++++++++
>   tools/net/ynl/cli.py                 |  77 +++
>   tools/net/ynl/lib/__init__.py        |   8 +
>   tools/net/ynl/lib/nlspec.py          | 607 +++++++++++++++++++
>   tools/net/ynl/lib/ynl.py             | 873 +++++++++++++++++++++++++++
>   5 files changed, 1895 insertions(+)
>   create mode 100644 Documentation/netlink/genetlink.yaml
>   create mode 100644 tools/net/ynl/cli.py
>   create mode 100644 tools/net/ynl/lib/__init__.py
>   create mode 100644 tools/net/ynl/lib/nlspec.py
>   create mode 100644 tools/net/ynl/lib/ynl.py
> 

--
Thibault
Bartlomiej Zolnierkiewicz March 18, 2024, 3:29 p.m. UTC | #3 
Applied to jammy:linux-bluefield/master-next. Thanks.

[ with "SOURCE" -> "SAUCE" change in the commit title ]

--
Best regards,
Bartlomiej

On Wed, Mar 6, 2024 at 9:10 PM William Tu <witu@nvidia.com> wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/2056364
>
> Bug 2053155 "Add DPLL and syncE support" requires using a yaml spec
> file, dpll.yaml, and a python script, cli.py, to verify the correctness.
> ex:
>   $ sudo ./tools/net/ynl/cli.py \
>     --spec Documentation/netlink/specs/dpll.yaml \
>     --dump device-get
>
> Add the missing files that requires to run the cli.py and dpll.yaml.
> ---
> v3: feedback from Bartlomiej
> - fix the format, add "UBUNTU: SOURCE:"
> - fix author of the patch, "From: Tony Duan..."
> - create new buglink page
> - rewrite the commit message
>
> Tony Duan (1):
>   UBUNTU: SOURCE: Add test script and yaml for dpll
>
>  Documentation/netlink/genetlink.yaml | 330 ++++++++++
>  tools/net/ynl/cli.py                 |  77 +++
>  tools/net/ynl/lib/__init__.py        |   8 +
>  tools/net/ynl/lib/nlspec.py          | 607 +++++++++++++++++++
>  tools/net/ynl/lib/ynl.py             | 873 +++++++++++++++++++++++++++
>  5 files changed, 1895 insertions(+)
>  create mode 100644 Documentation/netlink/genetlink.yaml
>  create mode 100644 tools/net/ynl/cli.py
>  create mode 100644 tools/net/ynl/lib/__init__.py
>  create mode 100644 tools/net/ynl/lib/nlspec.py
>  create mode 100644 tools/net/ynl/lib/ynl.py
>