From patchwork Mon Feb 26 23:02:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Tu X-Patchwork-Id: 1904774 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=185.125.189.65; helo=lists.ubuntu.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=patchwork.ozlabs.org) Received: from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TkGPW1Pn4z1yX0 for ; Tue, 27 Feb 2024 10:03:27 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=lists.ubuntu.com) by lists.ubuntu.com with esmtp (Exim 4.86_2) (envelope-from ) id 1rek0B-0008VI-Fm; Mon, 26 Feb 2024 23:03:15 +0000 Received: from mail-sn1nam02on2062.outbound.protection.outlook.com ([40.107.96.62] helo=NAM02-SN1-obe.outbound.protection.outlook.com) by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1rejzn-0008My-Da for kernel-team@lists.ubuntu.com; Mon, 26 Feb 2024 23:02:51 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AnnfDAqdRzKOd84J9zhM3wKJWZbVNpSZLXpNnEYjTgGsk+XsHW0HDcY6XqY4LIbUdQz88YZhVTSRIIqkT60v+o6eU5hXfEy2BCT5wkuf/GP1bXYZoIV0/Ygdi8GI/KfjXkv1m7WoGOWxVZ/+HeC34+BoWcPkYL0mJ2vxAlwelz+hBBdQEjCLW3A297Hv1l0vmRYbnmRgf53RueG5jfSzRlYZvaX4Mnqoz7yeYMKVnft8jZKHlUmiJHubf5DQmBLY5lTYlig5X1vYdsfgExcJFnjzML09KGHC0UoZpgDQ4P+muUiAOOQ+TzphCU4vl0pIxxakvaOMN9GR1N6OYXHmyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8CtrXYXaWs1TsjbWvv635x2VSpeX8YL9DJKhkscpBE0=; b=VetMqPevK9pt3LtPt4rQiRVNifNC9tlKmeu1KQVKA4bA987FZyByOPLcWBjBejY8Zw806Ol1cwFfu8UgW0tGT/0F/bh+THuXn5gRXYwptv/ZQftux09kN2yIM7p2/n0j7mZrYyqb9s5TzH4+onWP6F1/TRVFewOP6X2OtyNvVt4bRSwrXIWycOXmCw9ud1BXy+gOT4+CvrZtYT/oUJUiVs2tDdDwTtE2gFxXNmpdtbcPucNnXWvNQEXt9yqbyR6a17VP+3z67kHWeDbHS8nxJvljbEQQ8VXu0vmMH2GZw8bSmcKkRvdz2vhfTpsCCRmSEF3ArWRliH6WbmgbZVK5Kg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=lists.ubuntu.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) Received: from BL1PR13CA0077.namprd13.prod.outlook.com (2603:10b6:208:2b8::22) by BL1PR12MB5030.namprd12.prod.outlook.com (2603:10b6:208:313::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.36; Mon, 26 Feb 2024 23:02:45 +0000 Received: from BL6PEPF0001AB54.namprd02.prod.outlook.com (2603:10b6:208:2b8:cafe::f9) by BL1PR13CA0077.outlook.office365.com (2603:10b6:208:2b8::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.24 via Frontend Transport; Mon, 26 Feb 2024 23:02:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by BL6PEPF0001AB54.mail.protection.outlook.com (10.167.241.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.25 via Frontend Transport; Mon, 26 Feb 2024 23:02:45 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 26 Feb 2024 15:02:31 -0800 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Mon, 26 Feb 2024 15:02:31 -0800 Received: from vdi.nvidia.com (10.127.8.14) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server id 15.2.1258.12 via Frontend Transport; Mon, 26 Feb 2024 15:02:31 -0800 From: William Tu To: Subject: [SRU][J:linux-bluefield][PATCH 0/1] net/sched: flower: Add lock protection when remove filter handle Date: Mon, 26 Feb 2024 15:02:29 -0800 Message-ID: <20240226230230.86102-1-witu@nvidia.com> X-Mailer: git-send-email 2.37.1 (Apple Git-137.1) MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB54:EE_|BL1PR12MB5030:EE_ X-MS-Office365-Filtering-Correlation-Id: 86e0523b-900c-4722-6ce7-08dc371f0b63 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DQZV2BwfOVO7UKiqhvWyn5D1y7xwxSenrAwuQPWgAcBEK+Z19UN490FCfW7VMd/t/fQs4M1Q84zog5I85OhDEgpr6E7HQwe9QwAxQMkfYrdB89HPMxScC3A5YyUfhvpSpyQE6jChsAxNSvzMdx5r/z59nWBgEKnVom2w5T9VbhtH24UFYQRPTHsXiUmQIRdP8bvcErT1gcgoGW93Py7kcGFo5zFscIRakP4GFVN6YMH2DYy5XqADZzOPy+G6/1IWXZxhnCyAj6k+WzhZLSaY2G8iJkaltpE8A1I++p4wZFbTqynn9DJmms2i5dS7aGZoELz+clEylDNk3ysGcyny044yGZOitg7+BPu0yhFEOB4CTBV4+rjEYLz0QXMG9uaM3K5C4I8yaBdTrdlX2B987F2SarjVR65Saz/64DkpDfHCPmag176SdOX9+s0IUbu7097VCP8VPQAetoWF29w+WfbgbvLmyGI2EkwlE0plyqGloN59aCCJfMPdqyq8AhKFxOaHnVAyCcr+OxSzYzFV02TmTneDdjlT2LJVcmDuUB3y7huB9R5kbcoqVckzVrb2MzCfcbZTdEJ7/dQJhZI7pUHf10auNE+rzoRbTIK6/CwSzHK717MMqQCB7ySwhKG4EoXJqS+fGjxC51d9FVoz1WgAxKUDB5ToTBVIaHxYXDj5lkRlzDpqupZCTngFQBpPDYK+Ns1DWzVBxOLt74ESNorGRrV06pvq/4PBUso5JAG16XWiknPM8jRn+Bqo7NPfTJVP1GJ92HaHtSM5jjxg5S/VnI4r+WwVR6D2kk6YyIQ= X-Forefront-Antispam-Report: CIP:216.228.118.232; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge1.nvidia.com; CAT:NONE; SFS:(13230031)(36860700004)(82310400014); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2024 23:02:45.2471 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 86e0523b-900c-4722-6ce7-08dc371f0b63 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.232]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB54.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5030 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bodong@nvidia.com, vlad@nvidia.com, paulb@nvidia.com, dann.frazier@canonical.com Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/2055052 * intro As IDR can't protect itself from the concurrent modification, place idr_remove() under the protection of tp->lock. * how to fix need to backport the patch from Jianbo "net/sched: flower: Add lock protection when remove filter handle" https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=1fde0ca3a0de7e9f917668941156959dd5e9108b * reproduce and verification It's hard to reproduce because it is a race condition we found in k8s+ovn deployment. Jianbo Liu (1): net/sched: flower: Add lock protection when remove filter handle net/sched/cls_flower.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) Acked-by: Bartlomiej Zolnierkiewicz