mbox series

[SRU,jammy:linux-aws,0/1] arm64: pauth: don't sign leaf functions

Message ID 20240202212219.200147-1-kevin.becker@canonical.com
Headers show
Series arm64: pauth: don't sign leaf functions | expand

Message

Kevin Becker Feb. 2, 2024, 9:22 p.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/2043811

[Impact]

Amazon sent the following request: From our experiments, we found that not 
signing leaf functions on AWS arm64 Graviton instances helps improve 
application performance. We would like to have the patch 
https://github.com/torvalds/linux/commit/c68cf5285e1896a2b725ec01a1351f08610165b8 
backported to Ubuntu 5.15 AWS kernels. We saw some of these performance 
improvements: NGINX 1%, MySQL 2%, PyTorch 2%

[Test Plan]

Amazon has tested on AWS.

[Regression Potential]

Arm64 binaries may not work correctly.

[Other Info]

SF: #00372369

Kevin Becker (1):
  arm64: pauth: don't sign leaf functions

 arch/arm64/Makefile | 22 ++++++++--------------
 1 file changed, 8 insertions(+), 14 deletions(-)

Comments

Tim Gardner Feb. 6, 2024, 4:41 p.m. UTC | #1 
On 2/2/24 2:22 PM, Kevin Becker wrote:
> BugLink: https://bugs.launchpad.net/bugs/2043811
> 
> [Impact]
> 
> Amazon sent the following request: From our experiments, we found that not
> signing leaf functions on AWS arm64 Graviton instances helps improve
> application performance. We would like to have the patch
> https://github.com/torvalds/linux/commit/c68cf5285e1896a2b725ec01a1351f08610165b8
> backported to Ubuntu 5.15 AWS kernels. We saw some of these performance
> improvements: NGINX 1%, MySQL 2%, PyTorch 2%
> 
> [Test Plan]
> 
> Amazon has tested on AWS.
> 
> [Regression Potential]
> 
> Arm64 binaries may not work correctly.
> 
> [Other Info]
> 
> SF: #00372369
> 
> Kevin Becker (1):
>    arm64: pauth: don't sign leaf functions
> 
>   arch/arm64/Makefile | 22 ++++++++--------------
>   1 file changed, 8 insertions(+), 14 deletions(-)
> 
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Manuel Diewald Feb. 6, 2024, 5:31 p.m. UTC | #2 
On Fri, Feb 02, 2024 at 04:22:18PM -0500, Kevin Becker wrote:
> BugLink: https://bugs.launchpad.net/bugs/2043811
> 
> [Impact]
> 
> Amazon sent the following request: From our experiments, we found that not 
> signing leaf functions on AWS arm64 Graviton instances helps improve 
> application performance. We would like to have the patch 
> https://github.com/torvalds/linux/commit/c68cf5285e1896a2b725ec01a1351f08610165b8 
> backported to Ubuntu 5.15 AWS kernels. We saw some of these performance 
> improvements: NGINX 1%, MySQL 2%, PyTorch 2%
> 
> [Test Plan]
> 
> Amazon has tested on AWS.
> 
> [Regression Potential]
> 
> Arm64 binaries may not work correctly.
> 
> [Other Info]
> 
> SF: #00372369
> 
> Kevin Becker (1):
>   arm64: pauth: don't sign leaf functions
> 
>  arch/arm64/Makefile | 22 ++++++++--------------
>  1 file changed, 8 insertions(+), 14 deletions(-)
> 
> -- 
> 2.40.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

The LP bug targets Lunar, I think this needs to be changed to Jammy.

Acked-by: Manuel Diewald <manuel.diewald@canonical.com>
Tim Gardner Feb. 8, 2024, 7:05 p.m. UTC | #3 
On 2/2/24 2:22 PM, Kevin Becker wrote:
> BugLink: https://bugs.launchpad.net/bugs/2043811
> 
> [Impact]
> 
> Amazon sent the following request: From our experiments, we found that not
> signing leaf functions on AWS arm64 Graviton instances helps improve
> application performance. We would like to have the patch
> https://github.com/torvalds/linux/commit/c68cf5285e1896a2b725ec01a1351f08610165b8
> backported to Ubuntu 5.15 AWS kernels. We saw some of these performance
> improvements: NGINX 1%, MySQL 2%, PyTorch 2%
> 
> [Test Plan]
> 
> Amazon has tested on AWS.
> 
> [Regression Potential]
> 
> Arm64 binaries may not work correctly.
> 
> [Other Info]
> 
> SF: #00372369
> 
> Kevin Becker (1):
>    arm64: pauth: don't sign leaf functions
> 
>   arch/arm64/Makefile | 22 ++++++++--------------
>   1 file changed, 8 insertions(+), 14 deletions(-)
> 
Applied to jammy linux-aws:master-next. Thanks.

-rtg