mbox series

[SRU,M,v2,0/2] Dynamically determine acpi_handle_list size

Message ID 20240123041454.11189-1-ivan.hu@canonical.com
Headers show
Series Dynamically determine acpi_handle_list size | expand

Message

Ivan Hu Jan. 23, 2024, 4:14 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/2049733

[Impact]
ACPI handle list will be dynamic allocated without default fixed size.

[Fix]
Currently the ACPI_MAX_HANDLES is defined fix to 10, and it is not enough for
some platforms that called ACPI _PSL method to get passive cooling device
objects. then will get the error message "Invalid passive threshold", this 
patch change the fixed size with the dynamic handle list size which fixes the
handle reference error.

[Test Case]
check the dmesg to see if there is the error message "Invalid passive threshold"

[Where problems could occur]
Only change the fixed size with the dynamic handle list size. Risk of regression
is low.

[Other Info]
Change of v2:
add the "ACPI: utils: Fix error path in acpi_evaluate_reference()" patch for
fixing the "ACPI: utils: Dynamically determine acpi_handle_list size" issue
and modify the cherrypicked to backported

Rafael J. Wysocki (2):
  ACPI: utils: Dynamically determine acpi_handle_list size
  ACPI: utils: Fix error path in acpi_evaluate_reference()

 drivers/acpi/acpi_lpss.c                      | 10 ++-
 drivers/acpi/scan.c                           |  1 +
 drivers/acpi/thermal.c                        | 29 ++++++---
 drivers/acpi/utils.c                          | 63 ++++++++++++++++++-
 .../platform/surface/surface_acpi_notify.c    | 10 ++-
 include/acpi/acpi_bus.h                       |  9 ++-
 6 files changed, 101 insertions(+), 21 deletions(-)

Comments

Stefan Bader Jan. 23, 2024, 8:22 a.m. UTC | #1
On 23.01.24 05:14, Ivan Hu wrote:
> BugLink: https://bugs.launchpad.net/bugs/2049733
> 
> [Impact]
> ACPI handle list will be dynamic allocated without default fixed size.
> 
> [Fix]
> Currently the ACPI_MAX_HANDLES is defined fix to 10, and it is not enough for
> some platforms that called ACPI _PSL method to get passive cooling device
> objects. then will get the error message "Invalid passive threshold", this
> patch change the fixed size with the dynamic handle list size which fixes the
> handle reference error.
> 
> [Test Case]
> check the dmesg to see if there is the error message "Invalid passive threshold"
> 
> [Where problems could occur]
> Only change the fixed size with the dynamic handle list size. Risk of regression
> is low.
> 
> [Other Info]
> Change of v2:
> add the "ACPI: utils: Fix error path in acpi_evaluate_reference()" patch for
> fixing the "ACPI: utils: Dynamically determine acpi_handle_list size" issue
> and modify the cherrypicked to backported
> 
> Rafael J. Wysocki (2):
>    ACPI: utils: Dynamically determine acpi_handle_list size
>    ACPI: utils: Fix error path in acpi_evaluate_reference()
> 
>   drivers/acpi/acpi_lpss.c                      | 10 ++-
>   drivers/acpi/scan.c                           |  1 +
>   drivers/acpi/thermal.c                        | 29 ++++++---
>   drivers/acpi/utils.c                          | 63 ++++++++++++++++++-
>   .../platform/surface/surface_acpi_notify.c    | 10 ++-
>   include/acpi/acpi_bus.h                       |  9 ++-
>   6 files changed, 101 insertions(+), 21 deletions(-)
> 

Rejected for the following reasons:
- v3 on list

-Stefan