mbox series

[SRU,L,0/4] Ethernet not stable 23.04 (RTL8168/8169) (LP: #2031537)

Message ID 20230911090701.41518-1-juerg.haefliger@canonical.com
Headers show
Series Ethernet not stable 23.04 (RTL8168/8169) (LP: #2031537) | expand

Message

Juerg Haefliger Sept. 11, 2023, 9:06 a.m. UTC
[Impact]

Ethernet is unstable with Realtek RTL8168h/8111h NIC and kernel 6.2 resulting in frequent transmit queue timeouts. Related to ASPM. See 'original description' below.

[Test Case]

Just regular usage for an extended period of time. No transmit queue timeouts with RTL8168h/8111h NICs.

[Where Problems Could Occur]

Modification are isolated to the r8169 driver so only machine where that driver is loaded are affected. Issues could show up as kernel crashes, stack traces, non-fnuctional wired network.


Heiner Kallweit (4):
  r8169: fix ASPM-related problem for chip version 42 and 43
  r8169: revert 2ab19de62d67 ("r8169: remove ASPM restrictions now that
    ASPM is disabled during NAPI poll")
  Revert "r8169: disable ASPM during NAPI poll"
  r8169: fix ASPM-related issues on a number of systems with NIC version
    from RTL8168h

 drivers/net/ethernet/realtek/r8169_main.c | 41 +++++++++++++++++------
 1 file changed, 30 insertions(+), 11 deletions(-)

Comments

Tim Gardner Sept. 11, 2023, 1:07 p.m. UTC | #1
On 9/11/23 3:06 AM, Juerg Haefliger wrote:
> [Impact]
> 
> Ethernet is unstable with Realtek RTL8168h/8111h NIC and kernel 6.2 resulting in frequent transmit queue timeouts. Related to ASPM. See 'original description' below.
> 
> [Test Case]
> 
> Just regular usage for an extended period of time. No transmit queue timeouts with RTL8168h/8111h NICs.
> 
> [Where Problems Could Occur]
> 
> Modification are isolated to the r8169 driver so only machine where that driver is loaded are affected. Issues could show up as kernel crashes, stack traces, non-fnuctional wired network.
> 
> 
> Heiner Kallweit (4):
>    r8169: fix ASPM-related problem for chip version 42 and 43
>    r8169: revert 2ab19de62d67 ("r8169: remove ASPM restrictions now that
>      ASPM is disabled during NAPI poll")
>    Revert "r8169: disable ASPM during NAPI poll"
>    r8169: fix ASPM-related issues on a number of systems with NIC version
>      from RTL8168h
> 
>   drivers/net/ethernet/realtek/r8169_main.c | 41 +++++++++++++++++------
>   1 file changed, 30 insertions(+), 11 deletions(-)
> 
Acked-by: Tim Gardner <tim.gardner@canonical.com>

BugLink is in a  weird place.
Roxana Nicolescu Sept. 19, 2023, 1:34 p.m. UTC | #2
On 11-09-2023 11:06, Juerg Haefliger wrote:
> [Impact]
>
> Ethernet is unstable with Realtek RTL8168h/8111h NIC and kernel 6.2 resulting in frequent transmit queue timeouts. Related to ASPM. See 'original description' below.
>
> [Test Case]
>
> Just regular usage for an extended period of time. No transmit queue timeouts with RTL8168h/8111h NICs.
>
> [Where Problems Could Occur]
>
> Modification are isolated to the r8169 driver so only machine where that driver is loaded are affected. Issues could show up as kernel crashes, stack traces, non-fnuctional wired network.
>
>
> Heiner Kallweit (4):
>    r8169: fix ASPM-related problem for chip version 42 and 43
>    r8169: revert 2ab19de62d67 ("r8169: remove ASPM restrictions now that
>      ASPM is disabled during NAPI poll")
>    Revert "r8169: disable ASPM during NAPI poll"
>    r8169: fix ASPM-related issues on a number of systems with NIC version
>      from RTL8168h
>
>   drivers/net/ethernet/realtek/r8169_main.c | 41 +++++++++++++++++------
>   1 file changed, 30 insertions(+), 11 deletions(-)
>
Acked-by: Roxana Nicolescu <roxana.nicolescu@canonical.com>
Roxana Nicolescu Sept. 20, 2023, 9:15 a.m. UTC | #3
On 11/09/2023 11:06, Juerg Haefliger wrote:
> [Impact]
>
> Ethernet is unstable with Realtek RTL8168h/8111h NIC and kernel 6.2 resulting in frequent transmit queue timeouts. Related to ASPM. See 'original description' below.
>
> [Test Case]
>
> Just regular usage for an extended period of time. No transmit queue timeouts with RTL8168h/8111h NICs.
>
> [Where Problems Could Occur]
>
> Modification are isolated to the r8169 driver so only machine where that driver is loaded are affected. Issues could show up as kernel crashes, stack traces, non-fnuctional wired network.
>
>
> Heiner Kallweit (4):
>    r8169: fix ASPM-related problem for chip version 42 and 43
>    r8169: revert 2ab19de62d67 ("r8169: remove ASPM restrictions now that
>      ASPM is disabled during NAPI poll")
>    Revert "r8169: disable ASPM during NAPI poll"
>    r8169: fix ASPM-related issues on a number of systems with NIC version
>      from RTL8168h
>
>   drivers/net/ethernet/realtek/r8169_main.c | 41 +++++++++++++++++------
>   1 file changed, 30 insertions(+), 11 deletions(-)
>
Applied to lunar:master-next. I put the buglink in the right place. Thanks!