From patchwork Wed Sep 6 07:54:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kai-Heng Feng X-Patchwork-Id: 1830235 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=mZ0Tdjem; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=185.125.189.65; helo=lists.ubuntu.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=patchwork.ozlabs.org) Received: from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RgZRW4Zkmz1yhc for ; Wed, 6 Sep 2023 17:55:19 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=lists.ubuntu.com) by lists.ubuntu.com with esmtp (Exim 4.86_2) (envelope-from ) id 1qdnNU-00055a-N1; Wed, 06 Sep 2023 07:55:08 +0000 Received: from smtp-relay-canonical-1.internal ([10.131.114.174] helo=smtp-relay-canonical-1.canonical.com) by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1qdnNS-00055G-9T for kernel-team@lists.ubuntu.com; Wed, 06 Sep 2023 07:55:06 +0000 Received: from localhost.localdomain (unknown [10.101.196.174]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPSA id 2F9513F704 for ; Wed, 6 Sep 2023 07:55:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1693986906; bh=JeSgGFk/Ci/jhUMyCEde4RGudgzHbVI5RWut2j0UF0U=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=mZ0TdjemE0ord30DMq7cSdcydRqEfjmqsectv8horq8UDQKiR9eqJTrGnPNsHj5nG Lq8n3NDsNorwnub5LFvfr3AufxARxWdqhGmM+Rk957y95bfyHgDtGzwp/zcQRgZQRJ oO8pJK0bjk0MdnHd+FidRSKG9zlc/rnrYimwG66Mg65fhOEgFPvoq+NDXTC1Bb6aXJ +s37eiuSuk/eIedzfODDWjzK2zowvGoMwpOCnwDdmjUtrsFiURsIsQJdVo0WiH7yhK NZBrpuclNu9E+3PCQzXZgL5oEd/qLsm8CnvWCvzZmk+YBsMQuSsBbdH34sCmLzDmyb yi7EoqSgLrtEw== From: Kai-Heng Feng To: kernel-team@lists.ubuntu.com Subject: [SRU] [L/M/Unstable] [PATCH 0/9] Enable ASPM for NVMe behind VMD Date: Wed, 6 Sep 2023 15:54:12 +0800 Message-Id: <20230906075421.357683-1-kai.heng.feng@canonical.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/2034504 [Impact] ASPM of NVMe behind VMD is not enabled when BIOS FADT doesn't allow ASPM to be modified. That causes higher overall power consumption. [Fix] Allow ASPM to be enabled. While at this, remove old cruft that can interfere upstream VMD driver. [Test] Check the value of `/sys/kernel/debug/pmc_core/slp_s0_residency_usec`. Now system can reach deepest power saving state during sleep. [Where problems could occur] Some NVMe may have I/O issue when ASPM is enabled. But for this scenario the issue will also appear when VMD is disabled. David E. Box (3): PCI: vmd: Use PCI_VDEVICE in device list PCI: vmd: Create feature grouping for client products PCI: vmd: Add quirk to configure PCIe ASPM and LTR Kai-Heng Feng (5): Revert "UBUNTU: SAUCE: vmd: fixup bridge ASPM by driver name instead" Revert "UBUNTU: SAUCE: PCI/ASPM: Enable LTR for endpoints behind VMD" Revert "UBUNTU: SAUCE: PCI/ASPM: Enable ASPM for links under VMD domain" UBUNTU: SAUCE: PCI/ASPM: Allow ASPM override over FADT default UBUNTU: SAUCE: PCI: vmd: Mark ASPM override for device behind VMD bridge Michael Bottini (1): PCI/ASPM: Add pci_enable_link_state() drivers/pci/controller/vmd.c | 100 ++++++++++++++++++++++++++--------- drivers/pci/pcie/aspm.c | 54 +++++++++++++++++++ drivers/pci/quirks.c | 68 ------------------------ include/linux/pci.h | 7 +++ 4 files changed, 135 insertions(+), 94 deletions(-) Acked-by: Stefan Bader Acked-by: Tim Gardner