| Message ID | 20230601015128.246426-1-koba.ko@canonical.com |
|---|---|
| Headers | show |
| Series | Fix Monitor lost after replug WD19TBS to SUT port with VGA/DVI to type-C dongle Edit | expand |
On 5/31/23 7:51 PM, Koba Ko wrote: > BugLink: https://bugs.launchpad.net/bugs/2021949 > > [Impact] > Enabling CL1 (Controller Low Power) states during discovery of existing tunnels established by the system firmware can interfere with the operation of those tunnels. > The DisplayPort tunnel establishment timeout of 1.5 seconds can be insufficient for some docking stations, leading to blank displays. > > [Fix] > CL1 states are now not enabled during discovery of existing tunnels. The TMU settings also remain unchanged. > The timeout is increased to 3 seconds to allow more time for the DisplayPort connection manager handshake, fixing the issue of displays remaining blank. > > [Test Cases] > 1. plug docking station on the host > 2. bring up the host and get into desktop. > 3. flip docking station's cable. > 4. check if the external monitor works well > > [Where problems could occur] > Low, If the handshake actually requires even more than 3 seconds in some cases, the timeout may still need to be increased further. > > [Misc] > Jammy needs more patches to enable the thunderbolt CLx and the SRU will be a huge, > so skip Jammy. > > > Mika Westerberg (3): > thunderbolt: Increase timeout of DP OUT adapter handshake > thunderbolt: Do not touch CL state configuration during discovery > thunderbolt: Increase DisplayPort Connection Manager handshake timeout > > drivers/thunderbolt/tb.c | 17 ++++++++++++----- > drivers/thunderbolt/tunnel.c | 11 ++++++----- > 2 files changed, 18 insertions(+), 10 deletions(-) > Acked-by: Tim Gardner <tim.gardner@canonical.com>
On 23/06/01 09:51AM, Koba Ko wrote: > BugLink: https://bugs.launchpad.net/bugs/2021949 > > [Impact] > Enabling CL1 (Controller Low Power) states during discovery of existing tunnels established by the system firmware can interfere with the operation of those tunnels. > The DisplayPort tunnel establishment timeout of 1.5 seconds can be insufficient for some docking stations, leading to blank displays. > > [Fix] > CL1 states are now not enabled during discovery of existing tunnels. The TMU settings also remain unchanged. > The timeout is increased to 3 seconds to allow more time for the DisplayPort connection manager handshake, fixing the issue of displays remaining blank. > > [Test Cases] > 1. plug docking station on the host > 2. bring up the host and get into desktop. > 3. flip docking station's cable. > 4. check if the external monitor works well > > [Where problems could occur] > Low, If the handshake actually requires even more than 3 seconds in some cases, the timeout may still need to be increased further. > > [Misc] > Jammy needs more patches to enable the thunderbolt CLx and the SRU will be a huge, > so skip Jammy. > > > Mika Westerberg (3): > thunderbolt: Increase timeout of DP OUT adapter handshake > thunderbolt: Do not touch CL state configuration during discovery > thunderbolt: Increase DisplayPort Connection Manager handshake timeout > > drivers/thunderbolt/tb.c | 17 ++++++++++++----- > drivers/thunderbolt/tunnel.c | 11 ++++++----- > 2 files changed, 18 insertions(+), 10 deletions(-) > > -- > 2.34.1 Acked-by: Andrei Gherzan <andrei.gherzan@canonical.com>
On Thu, Jun 01, 2023 at 09:51:24AM +0800, Koba Ko wrote: > BugLink: https://bugs.launchpad.net/bugs/2021949 > > [Impact] > Enabling CL1 (Controller Low Power) states during discovery of existing tunnels established by the system firmware can interfere with the operation of those tunnels. > The DisplayPort tunnel establishment timeout of 1.5 seconds can be insufficient for some docking stations, leading to blank displays. > > [Fix] > CL1 states are now not enabled during discovery of existing tunnels. The TMU settings also remain unchanged. > The timeout is increased to 3 seconds to allow more time for the DisplayPort connection manager handshake, fixing the issue of displays remaining blank. > > [Test Cases] > 1. plug docking station on the host > 2. bring up the host and get into desktop. > 3. flip docking station's cable. > 4. check if the external monitor works well > > [Where problems could occur] > Low, If the handshake actually requires even more than 3 seconds in some cases, the timeout may still need to be increased further. > > [Misc] > Jammy needs more patches to enable the thunderbolt CLx and the SRU will be a huge, > so skip Jammy. Patches 2/4 and 3/4 applied to mantic/linux-unstable. Thanks, -Andrea
On 01.06.23 03:51, Koba Ko wrote: > BugLink: https://bugs.launchpad.net/bugs/2021949 > > [Impact] > Enabling CL1 (Controller Low Power) states during discovery of existing tunnels established by the system firmware can interfere with the operation of those tunnels. > The DisplayPort tunnel establishment timeout of 1.5 seconds can be insufficient for some docking stations, leading to blank displays. > > [Fix] > CL1 states are now not enabled during discovery of existing tunnels. The TMU settings also remain unchanged. > The timeout is increased to 3 seconds to allow more time for the DisplayPort connection manager handshake, fixing the issue of displays remaining blank. > > [Test Cases] > 1. plug docking station on the host > 2. bring up the host and get into desktop. > 3. flip docking station's cable. > 4. check if the external monitor works well > > [Where problems could occur] > Low, If the handshake actually requires even more than 3 seconds in some cases, the timeout may still need to be increased further. > > [Misc] > Jammy needs more patches to enable the thunderbolt CLx and the SRU will be a huge, > so skip Jammy. > > > Mika Westerberg (3): > thunderbolt: Increase timeout of DP OUT adapter handshake > thunderbolt: Do not touch CL state configuration during discovery > thunderbolt: Increase DisplayPort Connection Manager handshake timeout > > drivers/thunderbolt/tb.c | 17 ++++++++++++----- > drivers/thunderbolt/tunnel.c | 11 ++++++----- > 2 files changed, 18 insertions(+), 10 deletions(-) > Applied to lunar,kinetic:linux/master-next fixing trailing whitespace on BugLinks and re-ordering kinetic 4/4 to be applied first. For Mantic the reply here states its applied but the bug report had not been updated. I changed the Mantic status to committed.. Thanks. -Stefan