mbox series

[0/2,SRU,jammy:linux-intel-iotg,v2] Raptor Lake: Enable TSN driver

Message ID 20230516195121.10933-1-philip.cox@canonical.com
Headers show
Series Raptor Lake: Enable TSN driver | expand

Message

Philip Cox May 16, 2023, 7:51 p.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/2019222

SRU Justification:

[Impact]
Enable the TSN controller (stmmac) driver on the Intel Raptor Lake platform.

[Fix]
This is a set of commits that will enable the TSN controller on the Intel Raptor Lake platforms.

Many of the original commits requested where already added as part of the general TSN enablement work, so this is adding the remaining patches.

[Test Plan]
I have boot tested these changes on the raptor lake platform, and intel has tested them before handing them to us.  More in-depth testing will be done by our QA Team as well as Intel when an updated kernel image is available.

[Where problems could occur]
This makes some changes to the existing TSN code, so there is a chance functionality may change in it, but the TSN code was only enabled during the last SRU cycle, and there is not an updated image with the TSN enabled kernel the actual impact should be minimal for any regressions. 
 
[v2]
Squashed a patch and it's revert to remove them from the reviewed patchset.

-----

Aravindhan Gunasekaran (1):
  igc: Disable PTM sequences when interface goes down

Michael Sit Wei Hong (1):
  stmmac: intel: Separate ADL-N and RPL-P device ID from TGL

 drivers/net/ethernet/intel/igc/igc_ptp.c      | 50 +++++++++++--------
 .../net/ethernet/stmicro/stmmac/dwmac-intel.c |  2 +-
 2 files changed, 30 insertions(+), 22 deletions(-)

Comments

Tim Gardner May 23, 2023, 12:52 p.m. UTC | #1 
On 5/16/23 1:51 PM, Philip Cox wrote:
> BugLink: https://bugs.launchpad.net/bugs/2019222
> 
> SRU Justification:
> 
> [Impact]
> Enable the TSN controller (stmmac) driver on the Intel Raptor Lake platform.
> 
> [Fix]
> This is a set of commits that will enable the TSN controller on the Intel Raptor Lake platforms.
> 
> Many of the original commits requested where already added as part of the general TSN enablement work, so this is adding the remaining patches.
> 
> [Test Plan]
> I have boot tested these changes on the raptor lake platform, and intel has tested them before handing them to us.  More in-depth testing will be done by our QA Team as well as Intel when an updated kernel image is available.
> 
> [Where problems could occur]
> This makes some changes to the existing TSN code, so there is a chance functionality may change in it, but the TSN code was only enabled during the last SRU cycle, and there is not an updated image with the TSN enabled kernel the actual impact should be minimal for any regressions.
>   
> [v2]
> Squashed a patch and it's revert to remove them from the reviewed patchset.
> 
> -----
> 
> Aravindhan Gunasekaran (1):
>    igc: Disable PTM sequences when interface goes down
> 
> Michael Sit Wei Hong (1):
>    stmmac: intel: Separate ADL-N and RPL-P device ID from TGL
> 
>   drivers/net/ethernet/intel/igc/igc_ptp.c      | 50 +++++++++++--------
>   .../net/ethernet/stmicro/stmmac/dwmac-intel.c |  2 +-
>   2 files changed, 30 insertions(+), 22 deletions(-)
> 
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Philip Cox May 30, 2023, 5:28 p.m. UTC | #2 
On Tue, May 23, 2023 at 8:52 AM Tim Gardner <tim.gardner@canonical.com>
wrote:

> On 5/16/23 1:51 PM, Philip Cox wrote:
> > BugLink: https://bugs.launchpad.net/bugs/2019222
> >
> > SRU Justification:
> >
> > [Impact]
> > Enable the TSN controller (stmmac) driver on the Intel Raptor Lake
> platform.
> >
> > [Fix]
> > This is a set of commits that will enable the TSN controller on the
> Intel Raptor Lake platforms.
> >
> > Many of the original commits requested where already added as part of
> the general TSN enablement work, so this is adding the remaining patches.
> >
> > [Test Plan]
> > I have boot tested these changes on the raptor lake platform, and intel
> has tested them before handing them to us.  More in-depth testing will be
> done by our QA Team as well as Intel when an updated kernel image is
> available.
> >
> > [Where problems could occur]
> > This makes some changes to the existing TSN code, so there is a chance
> functionality may change in it, but the TSN code was only enabled during
> the last SRU cycle, and there is not an updated image with the TSN enabled
> kernel the actual impact should be minimal for any regressions.
> >
> > [v2]
> > Squashed a patch and it's revert to remove them from the reviewed
> patchset.
> >
> > -----
> >
> > Aravindhan Gunasekaran (1):
> >    igc: Disable PTM sequences when interface goes down
> >
> > Michael Sit Wei Hong (1):
> >    stmmac: intel: Separate ADL-N and RPL-P device ID from TGL
> >
> >   drivers/net/ethernet/intel/igc/igc_ptp.c      | 50 +++++++++++--------
> >   .../net/ethernet/stmicro/stmmac/dwmac-intel.c |  2 +-
> >   2 files changed, 30 insertions(+), 22 deletions(-)
> >
> Acked-by: Tim Gardner <tim.gardner@canonical.com>
> --
> -----------
> Tim Gardner
> Canonical, Inc
>
>