mbox series

[K,SRU,0/1] selftests/ftrace: Fix bash specific "==" operator

Message ID 20230330091143.193392-1-po-hsu.lin@canonical.com
Headers show
Series selftests/ftrace: Fix bash specific "==" operator | expand

Message

Po-Hsu Lin March 30, 2023, 9:11 a.m. UTC
== Impact ==
With upstream commit a1d6cd88c "selftests/ftrace: event_triggers: wait
longer for test_event_enable" applied via stable update (LP: #2008832),
ftrace in Kinetic proposed (5.19.0-40.41) is now failing with:

# [28] ftrace - test for function event triggers    [FAIL]
# [57] Meta-selftest: Checkbashisms    [FAIL]
# [97] (instance)  ftrace - test for function event triggers    [FAIL]

The "==" operator fix from 1e6b485c can solve this problem.

== Fix ==
* 1e6b485c selftests/ftrace: Fix bash specific "==" operator

This patch can be cherry-picked into Kinetic.
We have this patch in Focal, Jammy and Lunar already, the one for
Bionic is on it's way. So Kinetic is probably the last bit we need
to fix.

== Testcase ==
Running the kernel selftests/ftracetest, these three test cases should
pass.

== Regression Potential ==
This affects only the selftest suite and only ftrace subtests. Any
change would only be observable there.

Masami Hiramatsu (Google) (1):
  selftests/ftrace: Fix bash specific "==" operator

 tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stefan Bader April 6, 2023, 1:26 p.m. UTC | #1
On 30.03.23 11:11, Po-Hsu Lin wrote:
> == Impact ==
> With upstream commit a1d6cd88c "selftests/ftrace: event_triggers: wait
> longer for test_event_enable" applied via stable update (LP: #2008832),
> ftrace in Kinetic proposed (5.19.0-40.41) is now failing with:
> 
> # [28] ftrace - test for function event triggers    [FAIL]
> # [57] Meta-selftest: Checkbashisms    [FAIL]
> # [97] (instance)  ftrace - test for function event triggers    [FAIL]
> 
> The "==" operator fix from 1e6b485c can solve this problem.
> 
> == Fix ==
> * 1e6b485c selftests/ftrace: Fix bash specific "==" operator
> 
> This patch can be cherry-picked into Kinetic.
> We have this patch in Focal, Jammy and Lunar already, the one for
> Bionic is on it's way. So Kinetic is probably the last bit we need
> to fix.
> 
> == Testcase ==
> Running the kernel selftests/ftracetest, these three test cases should
> pass.
> 
> == Regression Potential ==
> This affects only the selftest suite and only ftrace subtests. Any
> change would only be observable there.
> 
> Masami Hiramatsu (Google) (1):
>    selftests/ftrace: Fix bash specific "==" operator
> 
>   tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied to kinetic:linux/master-next. Thanks.

-Stefan