| Message ID | 20220928204413.3018795-1-kellen.renshaw@canonical.com |
|---|---|
| Headers | show |
| Series | Fix keyboard inoperative on Asus Vivobook S5402ZA | expand |
On 9/28/22 14:44, Kellen Renshaw wrote: > Buglink: https://bugs.launchpad.net/bugs/1990425 > > SRU Justification: > > [Impact] > > * The builtin keyboard on the Asus S5402ZA doesn't work with any currently released kernel. > > [Fix] > > * 6e5cbe7c4b41824e500acbb42411da692d1435f1 ACPI: resource: Add ASUS model S5402ZA to quirks > > * https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=6e5cbe7c4b41824e500acbb42411da692d1435f1 > > * e12dee3736731e24b1e7367f87d66ac0fcd73ce7 ACPI: resource: Skip IRQ override on Asus Vivobook K3402ZA/K3502ZA > > * https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=e12dee3736731e24b1e7367f87d66ac0fcd73ce7 > > * These are from the upstream linux-pm tree, accepted for Linux 6.1, https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/ > > [Test Plan] > > * Install Ubuntu on an Asus S5402ZA and verify that the internal keyboard doesn't work. > > * Install kernel with the above patches. > > * Boot into patched kernel and verify that the internal keyboard now works. > > [Where problems could occur] > > * These patches could cause the keyboard to not work if there are differences in hardware/firmware revisions. > > [Other Info] > > * The patch requires e12dee3736731e24b1e7367f87d66ac0fcd73ce7 for the addition of the quirk mechanism. > > * e12dee373673 includes quirks for the Asus K3402ZA/K3502ZA models. These were tested and accepted by upstream. > See bug below. > > * The patchset has been tested on an Asus S5402ZA with a test kernel and found to work. > > * Upstream bug tracker: https://bugzilla.kernel.org/show_bug.cgi?id=216158 > > > Can this wait until the patches are at least in linux-next ? Once in linux-next they are unlikely to change.
Hello Tim, Certainly! Apologies for getting ahead of myself. Is being in linux-next a prerequisite for patches to be accepted? Thanks, Kellen On Thu, Sep 29, 2022 at 5:40 AM Tim Gardner <tim.gardner@canonical.com> wrote: > > On 9/28/22 14:44, Kellen Renshaw wrote: > > Buglink: https://bugs.launchpad.net/bugs/1990425 > > > > SRU Justification: > > > > [Impact] > > > > * The builtin keyboard on the Asus S5402ZA doesn't work with any currently released kernel. > > > > [Fix] > > > > * 6e5cbe7c4b41824e500acbb42411da692d1435f1 ACPI: resource: Add ASUS model S5402ZA to quirks > > > > * https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=6e5cbe7c4b41824e500acbb42411da692d1435f1 > > > > * e12dee3736731e24b1e7367f87d66ac0fcd73ce7 ACPI: resource: Skip IRQ override on Asus Vivobook K3402ZA/K3502ZA > > > > * https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=e12dee3736731e24b1e7367f87d66ac0fcd73ce7 > > > > * These are from the upstream linux-pm tree, accepted for Linux 6.1, https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/ > > > > [Test Plan] > > > > * Install Ubuntu on an Asus S5402ZA and verify that the internal keyboard doesn't work. > > > > * Install kernel with the above patches. > > > > * Boot into patched kernel and verify that the internal keyboard now works. > > > > [Where problems could occur] > > > > * These patches could cause the keyboard to not work if there are differences in hardware/firmware revisions. > > > > [Other Info] > > > > * The patch requires e12dee3736731e24b1e7367f87d66ac0fcd73ce7 for the addition of the quirk mechanism. > > > > * e12dee373673 includes quirks for the Asus K3402ZA/K3502ZA models. These were tested and accepted by upstream. > > See bug below. > > > > * The patchset has been tested on an Asus S5402ZA with a test kernel and found to work. > > > > * Upstream bug tracker: https://bugzilla.kernel.org/show_bug.cgi?id=216158 > > > > > > > > Can this wait until the patches are at least in linux-next ? Once in > linux-next they are unlikely to change. > > -- > ----------- > Tim Gardner > Canonical, Inc
On 9/29/22 11:58, Kellen Renshaw wrote: > Hello Tim, > > Certainly! Apologies for getting ahead of myself. > > Is being in linux-next a prerequisite for patches to be accepted? > Since Focal and Jammy are both LTS kernels, you have to have a pretty good reason to apply patches from untested provenance sources. Also, it'll keep Stefan off your case :) If they are headed upstream, then you also don't really need to specify 'Unstable' since that kernel should get them organically. rtg > > On Thu, Sep 29, 2022 at 5:40 AM Tim Gardner <tim.gardner@canonical.com> wrote: >> >> On 9/28/22 14:44, Kellen Renshaw wrote: >>> Buglink: https://bugs.launchpad.net/bugs/1990425 >>> >>> SRU Justification: >>> >>> [Impact] >>> >>> * The builtin keyboard on the Asus S5402ZA doesn't work with any currently released kernel. >>> >>> [Fix] >>> >>> * 6e5cbe7c4b41824e500acbb42411da692d1435f1 ACPI: resource: Add ASUS model S5402ZA to quirks >>> >>> * https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=6e5cbe7c4b41824e500acbb42411da692d1435f1 >>> >>> * e12dee3736731e24b1e7367f87d66ac0fcd73ce7 ACPI: resource: Skip IRQ override on Asus Vivobook K3402ZA/K3502ZA >>> >>> * https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=e12dee3736731e24b1e7367f87d66ac0fcd73ce7 >>> >>> * These are from the upstream linux-pm tree, accepted for Linux 6.1, https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/ >>> >>> [Test Plan] >>> >>> * Install Ubuntu on an Asus S5402ZA and verify that the internal keyboard doesn't work. >>> >>> * Install kernel with the above patches. >>> >>> * Boot into patched kernel and verify that the internal keyboard now works. >>> >>> [Where problems could occur] >>> >>> * These patches could cause the keyboard to not work if there are differences in hardware/firmware revisions. >>> >>> [Other Info] >>> >>> * The patch requires e12dee3736731e24b1e7367f87d66ac0fcd73ce7 for the addition of the quirk mechanism. >>> >>> * e12dee373673 includes quirks for the Asus K3402ZA/K3502ZA models. These were tested and accepted by upstream. >>> See bug below. >>> >>> * The patchset has been tested on an Asus S5402ZA with a test kernel and found to work. >>> >>> * Upstream bug tracker: https://bugzilla.kernel.org/show_bug.cgi?id=216158 >>> >>> >>> >> >> Can this wait until the patches are at least in linux-next ? Once in >> linux-next they are unlikely to change. >> >> -- >> ----------- >> Tim Gardner >> Canonical, Inc > > >
On 29.09.22 20:08, Tim Gardner wrote: > On 9/29/22 11:58, Kellen Renshaw wrote: >> Hello Tim, >> >> Certainly! Apologies for getting ahead of myself. >> >> Is being in linux-next a prerequisite for patches to be accepted? >> > > Since Focal and Jammy are both LTS kernels, you have to have a pretty good > reason to apply patches from untested provenance sources. Also, it'll keep > Stefan off your case :) Hey, I am much less biting nowadays. :-P But seriously, yeah for actually any SRU update I/we just started to delay until things are at least in linux-next. That usually is a good indication that things are settled. Quite often there have been subtle changes between appearing in subsystem trees and next. If we have need to really pick up things before we should mark those as SAUCE and check back to replace that with upstream patches. -Stefan > > If they are headed upstream, then you also don't really need to specify > 'Unstable' since that kernel should get them organically. > > rtg > >> >> On Thu, Sep 29, 2022 at 5:40 AM Tim Gardner <tim.gardner@canonical.com> wrote: >>> >>> On 9/28/22 14:44, Kellen Renshaw wrote: >>>> Buglink: https://bugs.launchpad.net/bugs/1990425 >>>> >>>> SRU Justification: >>>> >>>> [Impact] >>>> >>>> * The builtin keyboard on the Asus S5402ZA doesn't work with any currently >>>> released kernel. >>>> >>>> [Fix] >>>> >>>> * 6e5cbe7c4b41824e500acbb42411da692d1435f1 ACPI: resource: Add ASUS model >>>> S5402ZA to quirks >>>> >>>> * >>>> https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=6e5cbe7c4b41824e500acbb42411da692d1435f1 >>>> >>>> >>>> * e12dee3736731e24b1e7367f87d66ac0fcd73ce7 ACPI: resource: Skip IRQ override >>>> on Asus Vivobook K3402ZA/K3502ZA >>>> >>>> * >>>> https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=e12dee3736731e24b1e7367f87d66ac0fcd73ce7 >>>> >>>> >>>> * These are from the upstream linux-pm tree, accepted for Linux 6.1, >>>> https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/ >>>> >>>> [Test Plan] >>>> >>>> * Install Ubuntu on an Asus S5402ZA and verify that the internal keyboard >>>> doesn't work. >>>> >>>> * Install kernel with the above patches. >>>> >>>> * Boot into patched kernel and verify that the internal keyboard now works. >>>> >>>> [Where problems could occur] >>>> >>>> * These patches could cause the keyboard to not work if there are >>>> differences in hardware/firmware revisions. >>>> >>>> [Other Info] >>>> >>>> * The patch requires e12dee3736731e24b1e7367f87d66ac0fcd73ce7 for the >>>> addition of the quirk mechanism. >>>> >>>> * e12dee373673 includes quirks for the Asus K3402ZA/K3502ZA models. These >>>> were tested and accepted by upstream. >>>> See bug below. >>>> >>>> * The patchset has been tested on an Asus S5402ZA with a test kernel and >>>> found to work. >>>> >>>> * Upstream bug tracker: https://bugzilla.kernel.org/show_bug.cgi?id=216158 >>>> >>>> >>>> >>> >>> Can this wait until the patches are at least in linux-next ? Once in >>> linux-next they are unlikely to change. >>> >>> -- >>> ----------- >>> Tim Gardner >>> Canonical, Inc >> >> >> > >
On Fri, Sep 30, 2022 at 12:50 AM Stefan Bader <stefan.bader@canonical.com> wrote: > On 29.09.22 20:08, Tim Gardner wrote: > > On 9/29/22 11:58, Kellen Renshaw wrote: > >> Hello Tim, > >> > >> Certainly! Apologies for getting ahead of myself. > >> > >> Is being in linux-next a prerequisite for patches to be accepted? > >> > > > > Since Focal and Jammy are both LTS kernels, you have to have a pretty > good > > reason to apply patches from untested provenance sources. Also, it'll > keep > > Stefan off your case :) > > Hey, I am much less biting nowadays. :-P But seriously, yeah for actually > any > SRU update I/we just started to delay until things are at least in > linux-next. > That usually is a good indication that things are settled. Quite often > there > have been subtle changes between appearing in subsystem trees and next. If > we > have need to really pick up things before we should mark those as SAUCE > and > check back to replace that with upstream patches. > > -Stefan > Hello Stefan and Tim, Thanks for the clarification and edification! I will wait until it is in linux-next and re-submit. Kellen > > > > If they are headed upstream, then you also don't really need to specify > > 'Unstable' since that kernel should get them organically. > > > > rtg > > > >> > >> On Thu, Sep 29, 2022 at 5:40 AM Tim Gardner <tim.gardner@canonical.com> > wrote: > >>> > >>> On 9/28/22 14:44, Kellen Renshaw wrote: > >>>> Buglink: https://bugs.launchpad.net/bugs/1990425 > >>>> > >>>> SRU Justification: > >>>> > >>>> [Impact] > >>>> > >>>> * The builtin keyboard on the Asus S5402ZA doesn't work with any > currently > >>>> released kernel. > >>>> > >>>> [Fix] > >>>> > >>>> * 6e5cbe7c4b41824e500acbb42411da692d1435f1 ACPI: resource: Add ASUS > model > >>>> S5402ZA to quirks > >>>> > >>>> * > >>>> > https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=6e5cbe7c4b41824e500acbb42411da692d1435f1 > >>>> > >>>> > >>>> * e12dee3736731e24b1e7367f87d66ac0fcd73ce7 ACPI: resource: Skip IRQ > override > >>>> on Asus Vivobook K3402ZA/K3502ZA > >>>> > >>>> * > >>>> > https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=e12dee3736731e24b1e7367f87d66ac0fcd73ce7 > >>>> > >>>> > >>>> * These are from the upstream linux-pm tree, accepted for Linux 6.1, > >>>> https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/ > >>>> > >>>> [Test Plan] > >>>> > >>>> * Install Ubuntu on an Asus S5402ZA and verify that the internal > keyboard > >>>> doesn't work. > >>>> > >>>> * Install kernel with the above patches. > >>>> > >>>> * Boot into patched kernel and verify that the internal keyboard now > works. > >>>> > >>>> [Where problems could occur] > >>>> > >>>> * These patches could cause the keyboard to not work if there are > >>>> differences in hardware/firmware revisions. > >>>> > >>>> [Other Info] > >>>> > >>>> * The patch requires e12dee3736731e24b1e7367f87d66ac0fcd73ce7 for the > >>>> addition of the quirk mechanism. > >>>> > >>>> * e12dee373673 includes quirks for the Asus K3402ZA/K3502ZA models. > These > >>>> were tested and accepted by upstream. > >>>> See bug below. > >>>> > >>>> * The patchset has been tested on an Asus S5402ZA with a test kernel > and > >>>> found to work. > >>>> > >>>> * Upstream bug tracker: > https://bugzilla.kernel.org/show_bug.cgi?id=216158 > >>>> > >>>> > >>>> > >>> > >>> Can this wait until the patches are at least in linux-next ? Once in > >>> linux-next they are unlikely to change. > >>> > >>> -- > >>> ----------- > >>> Tim Gardner > >>> Canonical, Inc > >> > >> > >> > > > > > >
On 30.09.22 19:10, Kellen Renshaw wrote: > On Fri, Sep 30, 2022 at 12:50 AM Stefan Bader <stefan.bader@canonical.com > <mailto:stefan.bader@canonical.com>> wrote: > > On 29.09.22 20:08, Tim Gardner wrote: > > On 9/29/22 11:58, Kellen Renshaw wrote: > >> Hello Tim, > >> > >> Certainly! Apologies for getting ahead of myself. > >> > >> Is being in linux-next a prerequisite for patches to be accepted? > >> > > > > Since Focal and Jammy are both LTS kernels, you have to have a pretty good > > reason to apply patches from untested provenance sources. Also, it'll keep > > Stefan off your case :) > > Hey, I am much less biting nowadays. :-P But seriously, yeah for actually any > SRU update I/we just started to delay until things are at least in linux-next. > That usually is a good indication that things are settled. Quite often there > have been subtle changes between appearing in subsystem trees and next. If we > have need to really pick up things before we should mark those as SAUCE and > check back to replace that with upstream patches. > > -Stefan > > Hello Stefan and Tim, > > Thanks for the clarification and edification! I will wait until it is in > linux-next and re-submit. Hi Kellen, thanks, I am doing the NACK to make it obvious for those just checking the subjects of the thread. Also, just as a reminder to be on the safe side, when you resubmit, it would be best to use the same cover email subject and just add a v2 like "[SRU v2]". Thanks, Stefan > > Kellen > > > > > If they are headed upstream, then you also don't really need to specify > > 'Unstable' since that kernel should get them organically. > > > > rtg > > > >> > >> On Thu, Sep 29, 2022 at 5:40 AM Tim Gardner <tim.gardner@canonical.com > <mailto:tim.gardner@canonical.com>> wrote: > >>> > >>> On 9/28/22 14:44, Kellen Renshaw wrote: > >>>> Buglink: https://bugs.launchpad.net/bugs/1990425 > <https://bugs.launchpad.net/bugs/1990425> > >>>> > >>>> SRU Justification: > >>>> > >>>> [Impact] > >>>> > >>>> * The builtin keyboard on the Asus S5402ZA doesn't work with any > currently > >>>> released kernel. > >>>> > >>>> [Fix] > >>>> > >>>> * 6e5cbe7c4b41824e500acbb42411da692d1435f1 ACPI: resource: Add ASUS model > >>>> S5402ZA to quirks > >>>> > >>>> * > >>>> > https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=6e5cbe7c4b41824e500acbb42411da692d1435f1 > <https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=6e5cbe7c4b41824e500acbb42411da692d1435f1> > > >>>> > >>>> > >>>> * e12dee3736731e24b1e7367f87d66ac0fcd73ce7 ACPI: resource: Skip IRQ > override > >>>> on Asus Vivobook K3402ZA/K3502ZA > >>>> > >>>> * > >>>> > https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=e12dee3736731e24b1e7367f87d66ac0fcd73ce7 > <https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=e12dee3736731e24b1e7367f87d66ac0fcd73ce7> > > >>>> > >>>> > >>>> * These are from the upstream linux-pm tree, accepted for Linux 6.1, > >>>> https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/ > <https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/> > >>>> > >>>> [Test Plan] > >>>> > >>>> * Install Ubuntu on an Asus S5402ZA and verify that the internal keyboard > >>>> doesn't work. > >>>> > >>>> * Install kernel with the above patches. > >>>> > >>>> * Boot into patched kernel and verify that the internal keyboard now > works. > >>>> > >>>> [Where problems could occur] > >>>> > >>>> * These patches could cause the keyboard to not work if there are > >>>> differences in hardware/firmware revisions. > >>>> > >>>> [Other Info] > >>>> > >>>> * The patch requires e12dee3736731e24b1e7367f87d66ac0fcd73ce7 for the > >>>> addition of the quirk mechanism. > >>>> > >>>> * e12dee373673 includes quirks for the Asus K3402ZA/K3502ZA models. These > >>>> were tested and accepted by upstream. > >>>> See bug below. > >>>> > >>>> * The patchset has been tested on an Asus S5402ZA with a test kernel and > >>>> found to work. > >>>> > >>>> * Upstream bug tracker: > https://bugzilla.kernel.org/show_bug.cgi?id=216158 > <https://bugzilla.kernel.org/show_bug.cgi?id=216158> > >>>> > >>>> > >>>> > >>> > >>> Can this wait until the patches are at least in linux-next ? Once in > >>> linux-next they are unlikely to change. > >>> > >>> -- > >>> ----------- > >>> Tim Gardner > >>> Canonical, Inc > >> > >> > >> > > > > > > > > -- > Kellen Renshaw* > *Associate Software Engineer (SEG) > Canonical Ltd. > kellen.renshaw@canonical.com <mailto:kellen.renshaw@canonical.com> > www.canonical.com | www.ubuntu.com