| Message ID | 20220713125649.24063-1-tim.gardner@canonical.com |
|---|---|
| Headers | show |
| Series | Azure: Support multi-MSI | expand |
Acked-by: Bartlomiej Zolnierkiewicz <bartlomiej.zolnierkiewicz@canonical.com> On Wed, Jul 13, 2022 at 2:57 PM Tim Gardner <tim.gardner@canonical.com> wrote: > > BugLink: https://bugs.launchpad.net/bugs/1981577 > > SRU Justification > > [Impact] > > The Hyper-V vPCI driver (pci-hyperv) doesn't work with a PCIe devcie that > supports multiple MSI interrupts (Note: MSI-X has been working fine). Recently > Jeffrey Hugo <quic_jhugo@quicinc.com> made 4 patches to the vPCI driver so > multiple-MSI can work now. Please consider picking up the 4 patches into the > linux-azure kernels for Ubuntu LTS 18.04, 20.04 and 22.04: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=08e61e861a0e47e5e1a3fb78406afd6b0cea6b6d > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=455880dfe292a2bdd3b4ad6a107299fce610e64b > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b4b77778ecc5bfbd4e77de1b2fd5c1dd3c655f1f > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a2bad844a67b1c7740bda63e87453baf63c3a7f7 > > Microsoft is working to bring up a Qualcomm PCIe device to Linux VMs running > on Azure. We need the 4 patches for the device to work on Azure/Hyper-V. > > The 5.4 kernel patches are a mix of cherry picks and backports since cherry picking scaffold > patches would have been too intrusive, whereas for the 5.15 kernel I chose > some scaffolding patches in order to have all clean cherry picks. > > [Test Plan] > > Microsoft tested both 5.4 and 5.15 kernels. > > [Where things could go wrong] > > MSI vectors could be mis-wired or ignored. > > [Other Info] > > SF: #00339521
With the caveat that as Bartlomiej has pointed out, the second patch for focal
should have the test for the other architectures that only appears on the
fourth patch.
Also, I would like to note that those many pre-reqs picked for the jammy kernel
might cause some pain down the road when related changes are added to the base
kernel. At least those are all clean cherry-picks.
Acked-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
On 7/19/22 07:17, Thadeu Lima de Souza Cascardo wrote: > With the caveat that as Bartlomiej has pointed out, the second patch for focal > should have the test for the other architectures that only appears on the > fourth patch. > Yup - I moved that hunk into patch 2. > Also, I would like to note that those many pre-reqs picked for the jammy kernel > might cause some pain down the road when related changes are added to the base > kernel. At least those are all clean cherry-picks. > > Acked-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com> rtg
On 7/13/22 06:56, Tim Gardner wrote: > BugLink: https://bugs.launchpad.net/bugs/1981577 > > SRU Justification > > [Impact] > > The Hyper-V vPCI driver (pci-hyperv) doesn't work with a PCIe devcie that > supports multiple MSI interrupts (Note: MSI-X has been working fine). Recently > Jeffrey Hugo <quic_jhugo@quicinc.com> made 4 patches to the vPCI driver so > multiple-MSI can work now. Please consider picking up the 4 patches into the > linux-azure kernels for Ubuntu LTS 18.04, 20.04 and 22.04: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=08e61e861a0e47e5e1a3fb78406afd6b0cea6b6d > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=455880dfe292a2bdd3b4ad6a107299fce610e64b > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b4b77778ecc5bfbd4e77de1b2fd5c1dd3c655f1f > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a2bad844a67b1c7740bda63e87453baf63c3a7f7 > > Microsoft is working to bring up a Qualcomm PCIe device to Linux VMs running > on Azure. We need the 4 patches for the device to work on Azure/Hyper-V. > > The 5.4 kernel patches are a mix of cherry picks and backports since cherry picking scaffold > patches would have been too intrusive, whereas for the 5.15 kernel I chose > some scaffolding patches in order to have all clean cherry picks. > > [Test Plan] > > Microsoft tested both 5.4 and 5.15 kernels. > > [Where things could go wrong] > > MSI vectors could be mis-wired or ignored. > > [Other Info] > > SF: #00339521 > Applied to f/j linux-azure/master-next. Thanks. -rtg