mbox series

[0/5,jammy/linux-azure] SGX fixes for 5.15 Azure tuned kernel

Message ID 20220622142501.4339-1-tim.gardner@canonical.com
Headers show
Series SGX fixes for 5.15 Azure tuned kernel | expand

Message

Tim Gardner June 22, 2022, 2:24 p.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1979541

SRU Justification

[Impact]

https://lore.kernel.org/linux-sgx/dd7c1402-eeb9-cea5-25c6-ab19e8031991@intel.com/T/ = This
fix introduced a bug and fixed and reverted by series added to 5.19
(https://lore.kernel.org/linux-sgx/cover.1652389823.git.reinette.chatre@intel.com/)

Backport several SGX fixes.

x86/sgx: Ensure no data in PCMD page after truncate
x86/sgx: Fix race between reclaimer and page fault handler
x86/sgx: Obtain backing storage page with enclave mutex held
x86/sgx: Mark PCMD page as dirty when modifying contents
x86/sgx: Disconnect backing page references from dirty status

[Test Plan]

Microsoft tested, "Update from engineer - I was unable to reproduce the softlock issue after the patches were installed"

[Where things could go wrong]

These patches could cause a different soft lockup.

[Other Info]

SF: #00338537

Comments

Bartlomiej Zolnierkiewicz June 23, 2022, 4:14 p.m. UTC | #1 
Acked-by: Bartlomiej Zolnierkiewicz <bartlomiej.zolnierkiewicz@canonical.com>

On Wed, Jun 22, 2022 at 4:26 PM Tim Gardner <tim.gardner@canonical.com> wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/1979541
>
> SRU Justification
>
> [Impact]
>
> https://lore.kernel.org/linux-sgx/dd7c1402-eeb9-cea5-25c6-ab19e8031991@intel.com/T/ = This
> fix introduced a bug and fixed and reverted by series added to 5.19
> (https://lore.kernel.org/linux-sgx/cover.1652389823.git.reinette.chatre@intel.com/)
>
> Backport several SGX fixes.
>
> x86/sgx: Ensure no data in PCMD page after truncate
> x86/sgx: Fix race between reclaimer and page fault handler
> x86/sgx: Obtain backing storage page with enclave mutex held
> x86/sgx: Mark PCMD page as dirty when modifying contents
> x86/sgx: Disconnect backing page references from dirty status
>
> [Test Plan]
>
> Microsoft tested, "Update from engineer - I was unable to reproduce the softlock issue after the patches were installed"
>
> [Where things could go wrong]
>
> These patches could cause a different soft lockup.
>
> [Other Info]
>
> SF: #00338537
Joseph Salisbury June 23, 2022, 5:27 p.m. UTC | #2 
On 6/22/22 10:24, Tim Gardner wrote:
> BugLink: https://bugs.launchpad.net/bugs/1979541
>
> SRU Justification
>
> [Impact]
>
> https://lore.kernel.org/linux-sgx/dd7c1402-eeb9-cea5-25c6-ab19e8031991@intel.com/T/ = This
> fix introduced a bug and fixed and reverted by series added to 5.19
> (https://lore.kernel.org/linux-sgx/cover.1652389823.git.reinette.chatre@intel.com/)
>
> Backport several SGX fixes.
>
> x86/sgx: Ensure no data in PCMD page after truncate
> x86/sgx: Fix race between reclaimer and page fault handler
> x86/sgx: Obtain backing storage page with enclave mutex held
> x86/sgx: Mark PCMD page as dirty when modifying contents
> x86/sgx: Disconnect backing page references from dirty status
>
> [Test Plan]
>
> Microsoft tested, "Update from engineer - I was unable to reproduce the softlock issue after the patches were installed"
>
> [Where things could go wrong]
>
> These patches could cause a different soft lockup.
>
> [Other Info]
>
> SF: #00338537
>
>
Acked-by: Joseph Salisbury <joseph.salisbury@canonical.com>
Tim Gardner June 23, 2022, 5:36 p.m. UTC | #3 
On 6/22/22 08:24, Tim Gardner wrote:
> BugLink: https://bugs.launchpad.net/bugs/1979541
> 
> SRU Justification
> 
> [Impact]
> 
> https://lore.kernel.org/linux-sgx/dd7c1402-eeb9-cea5-25c6-ab19e8031991@intel.com/T/ = This
> fix introduced a bug and fixed and reverted by series added to 5.19
> (https://lore.kernel.org/linux-sgx/cover.1652389823.git.reinette.chatre@intel.com/)
> 
> Backport several SGX fixes.
> 
> x86/sgx: Ensure no data in PCMD page after truncate
> x86/sgx: Fix race between reclaimer and page fault handler
> x86/sgx: Obtain backing storage page with enclave mutex held
> x86/sgx: Mark PCMD page as dirty when modifying contents
> x86/sgx: Disconnect backing page references from dirty status
> 
> [Test Plan]
> 
> Microsoft tested, "Update from engineer - I was unable to reproduce the softlock issue after the patches were installed"
> 
> [Where things could go wrong]
> 
> These patches could cause a different soft lockup.
> 
> [Other Info]
> 
> SF: #00338537
> 
Applied to jammy/linux-azure:master-next. Thanks.

-rtg