| Message ID | 20220602063259.43781-1-koba.ko@canonical.com |
|---|---|
| Headers | show |
| Series | Fix can't boot up after change to vmd | expand |
Koba Ko kirjoitti 2.6.2022 klo 9.32: > BugLink: https://bugs.launchpad.net/bugs/1976587 > > [Impact] > the previous commit has been SRUed that enable CONFIG_INTEL_IOMMU_DEFAULT_ON. > https://bugs.launchpad.net/subiquity/+bug/1937295 > but it would caused the regression with AMD/NVIDIA GPUs. > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1965882 > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1971146 > > [Fix] > Revert the vmd: Revert 2565e5b69c44 ("PCI: vmd: Do not disable MSI-X remapping if interrupt remapping is enabled by IOMMU.") > Assign VMD irq domain before enumeration, irq domain comes from pci driver. > > [Test Case] > 1. In BIOS, change to VMD > 2. Check if SKU could boot-up. > > [Where problems could occur] > it reduce the affected region to only VMD. > > Nirmal Patel (2): > PCI: vmd: Assign VMD IRQ domain before enumeration > PCI: vmd: Revert 2565e5b69c44 ("PCI: vmd: Do not disable MSI-X > remapping if interrupt remapping is enabled by IOMMU.") > > drivers/pci/controller/vmd.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > applied to oem-kernels, thanks oem-5.14 had fuzz and needed manual intervention, though
On 6/2/22 00:32, Koba Ko wrote: > BugLink: https://bugs.launchpad.net/bugs/1976587 > > [Impact] > the previous commit has been SRUed that enable CONFIG_INTEL_IOMMU_DEFAULT_ON. > https://bugs.launchpad.net/subiquity/+bug/1937295 > but it would caused the regression with AMD/NVIDIA GPUs. > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1965882 > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1971146 > > [Fix] > Revert the vmd: Revert 2565e5b69c44 ("PCI: vmd: Do not disable MSI-X remapping if interrupt remapping is enabled by IOMMU.") > Assign VMD irq domain before enumeration, irq domain comes from pci driver. > > [Test Case] > 1. In BIOS, change to VMD > 2. Check if SKU could boot-up. > > [Where problems could occur] > it reduce the affected region to only VMD. > > Nirmal Patel (2): > PCI: vmd: Assign VMD IRQ domain before enumeration > PCI: vmd: Revert 2565e5b69c44 ("PCI: vmd: Do not disable MSI-X > remapping if interrupt remapping is enabled by IOMMU.") > > drivers/pci/controller/vmd.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > Acked-by: Tim Gardner <tim.gardner@canonical.com> Both patches are now in linux-next
Acked-by: Luke Nowakowski-Krijger <luke.nowakowskikrijger@canonical.com> On Wed, Jun 1, 2022 at 11:33 PM Koba Ko <koba.ko@canonical.com> wrote: > BugLink: https://bugs.launchpad.net/bugs/1976587 > > [Impact] > the previous commit has been SRUed that enable > CONFIG_INTEL_IOMMU_DEFAULT_ON. > https://bugs.launchpad.net/subiquity/+bug/1937295 > but it would caused the regression with AMD/NVIDIA GPUs. > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1965882 > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1971146 > > [Fix] > Revert the vmd: Revert 2565e5b69c44 ("PCI: vmd: Do not disable MSI-X > remapping if interrupt remapping is enabled by IOMMU.") > Assign VMD irq domain before enumeration, irq domain comes from pci driver. > > [Test Case] > 1. In BIOS, change to VMD > 2. Check if SKU could boot-up. > > [Where problems could occur] > it reduce the affected region to only VMD. > > Nirmal Patel (2): > PCI: vmd: Assign VMD IRQ domain before enumeration > PCI: vmd: Revert 2565e5b69c44 ("PCI: vmd: Do not disable MSI-X > remapping if interrupt remapping is enabled by IOMMU.") > > drivers/pci/controller/vmd.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > -- > 2.34.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team >
On 02.06.22 08:32, Koba Ko wrote: > BugLink: https://bugs.launchpad.net/bugs/1976587 > > [Impact] > the previous commit has been SRUed that enable CONFIG_INTEL_IOMMU_DEFAULT_ON. > https://bugs.launchpad.net/subiquity/+bug/1937295 > but it would caused the regression with AMD/NVIDIA GPUs. > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1965882 > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1971146 > > [Fix] > Revert the vmd: Revert 2565e5b69c44 ("PCI: vmd: Do not disable MSI-X remapping if interrupt remapping is enabled by IOMMU.") > Assign VMD irq domain before enumeration, irq domain comes from pci driver. > > [Test Case] > 1. In BIOS, change to VMD > 2. Check if SKU could boot-up. > > [Where problems could occur] > it reduce the affected region to only VMD. > > Nirmal Patel (2): > PCI: vmd: Assign VMD IRQ domain before enumeration > PCI: vmd: Revert 2565e5b69c44 ("PCI: vmd: Do not disable MSI-X > remapping if interrupt remapping is enabled by IOMMU.") > > drivers/pci/controller/vmd.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > Applied to jammy:linux/master-next with fixed up (upstream) SHA1 references. Thanks. -Stefan
On Thu, Jun 02, 2022 at 02:32:57PM +0800, Koba Ko wrote: > BugLink: https://bugs.launchpad.net/bugs/1976587 > > [Impact] > the previous commit has been SRUed that enable CONFIG_INTEL_IOMMU_DEFAULT_ON. > https://bugs.launchpad.net/subiquity/+bug/1937295 > but it would caused the regression with AMD/NVIDIA GPUs. > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1965882 > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1971146 > > [Fix] > Revert the vmd: Revert 2565e5b69c44 ("PCI: vmd: Do not disable MSI-X remapping if interrupt remapping is enabled by IOMMU.") > Assign VMD irq domain before enumeration, irq domain comes from pci driver. > > [Test Case] > 1. In BIOS, change to VMD > 2. Check if SKU could boot-up. > > [Where problems could occur] > it reduce the affected region to only VMD. Already applied to kinetic/linux via upstream updates. Thanks, -Andrea
BugLink: https://bugs.launchpad.net/bugs/1976587 [Impact] the previous commit has been SRUed that enable CONFIG_INTEL_IOMMU_DEFAULT_ON. https://bugs.launchpad.net/subiquity/+bug/1937295 but it would caused the regression with AMD/NVIDIA GPUs. https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1965882 https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1971146 [Fix] Revert the vmd: Revert 2565e5b69c44 ("PCI: vmd: Do not disable MSI-X remapping if interrupt remapping is enabled by IOMMU.") Assign VMD irq domain before enumeration, irq domain comes from pci driver. [Test Case] 1. In BIOS, change to VMD 2. Check if SKU could boot-up. [Where problems could occur] it reduce the affected region to only VMD. Nirmal Patel (2): PCI: vmd: Assign VMD IRQ domain before enumeration PCI: vmd: Revert 2565e5b69c44 ("PCI: vmd: Do not disable MSI-X remapping if interrupt remapping is enabled by IOMMU.") drivers/pci/controller/vmd.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)