mbox series

[autotest-client-tests,0/2] ubuntu_boot: Add staging modules exception for raspi kernel

Message ID 20220520095815.901356-1-po-hsu.lin@canonical.com
Headers show
Series ubuntu_boot: Add staging modules exception for raspi kernel | expand

Message

Po-Hsu Lin May 20, 2022, 9:58 a.m. UTC
This patchset will add staging modules exception to the kernel_tainted
test in ubuntu_boot for our raspberry pi kernel.

These modules are:
  * bcm2835_codec
  * bcm2835_isp
  * bcm2835_v4l2
  * bcm2835_mmal_vchiq
  * snd_bcm2835
  * vc_sm_cma

These will cause the following kernel taints on Focal / Jammy raspi
kernels:
  * F - unsigned / staging
  * J - staging (according to Juerg, these should not be signed and
        will be corrected in the future)

Patch tested on F-raspi:
$ sudo ./kernel_taint_test.py
Kernel taint value is 9216
Taint bit value: 10 (staging driver was loaded)
Exception made in test script: bcm2835_codec
Exception made in test script: bcm2835_isp
Exception made in test script: bcm2835_v4l2
Exception made in test script: bcm2835_mmal_vchiq
Exception made in test script: snd_bcm2835
Exception made in test script: vc_sm_cma
*   Staging modules found, but they are expected and OK
Taint bit value: 13 (unsigned module was loaded)
Exception made in test script: bcm2835_codec
Exception made in test script: bcm2835_isp
Exception made in test script: bcm2835_v4l2
Exception made in test script: bcm2835_mmal_vchiq
Exception made in test script: snd_bcm2835
Exception made in test script: vc_sm_cma
*   Unsigned modules found, but they are expected and OK
$ echo $?
0

This can help us to improve the boot-testing result review process.

Po-Hsu Lin (2):
  UBUNTU: SAUCE: ubuntu_boot: use module taint flag to simplify code
  UBUNTU: SAUCE: ubuntu_boot: add exception for staging modules on RPI

 ubuntu_boot/kernel_taint_test.py | 51 ++++++++++++++++++++++----------
 1 file changed, 36 insertions(+), 15 deletions(-)

Comments

Francis Ginther May 26, 2022, 1:53 a.m. UTC | #1
Acked-by: Francis Ginther <francis.ginther@canonical.com>

On Fri, May 20, 2022 at 05:58:13PM +0800, Po-Hsu Lin wrote:
> This patchset will add staging modules exception to the kernel_tainted
> test in ubuntu_boot for our raspberry pi kernel.
> 
> These modules are:
>   * bcm2835_codec
>   * bcm2835_isp
>   * bcm2835_v4l2
>   * bcm2835_mmal_vchiq
>   * snd_bcm2835
>   * vc_sm_cma
> 
> These will cause the following kernel taints on Focal / Jammy raspi
> kernels:
>   * F - unsigned / staging
>   * J - staging (according to Juerg, these should not be signed and
>         will be corrected in the future)
> 
> Patch tested on F-raspi:
> $ sudo ./kernel_taint_test.py
> Kernel taint value is 9216
> Taint bit value: 10 (staging driver was loaded)
> Exception made in test script: bcm2835_codec
> Exception made in test script: bcm2835_isp
> Exception made in test script: bcm2835_v4l2
> Exception made in test script: bcm2835_mmal_vchiq
> Exception made in test script: snd_bcm2835
> Exception made in test script: vc_sm_cma
> *   Staging modules found, but they are expected and OK
> Taint bit value: 13 (unsigned module was loaded)
> Exception made in test script: bcm2835_codec
> Exception made in test script: bcm2835_isp
> Exception made in test script: bcm2835_v4l2
> Exception made in test script: bcm2835_mmal_vchiq
> Exception made in test script: snd_bcm2835
> Exception made in test script: vc_sm_cma
> *   Unsigned modules found, but they are expected and OK
> $ echo $?
> 0
> 
> This can help us to improve the boot-testing result review process.
> 
> Po-Hsu Lin (2):
>   UBUNTU: SAUCE: ubuntu_boot: use module taint flag to simplify code
>   UBUNTU: SAUCE: ubuntu_boot: add exception for staging modules on RPI
> 
>  ubuntu_boot/kernel_taint_test.py | 51 ++++++++++++++++++++++----------
>  1 file changed, 36 insertions(+), 15 deletions(-)
> 
> -- 
> 2.25.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Po-Hsu Lin May 26, 2022, 3:12 a.m. UTC | #2
Applied and pushed.

Thanks
Sam