mbox series

[0/2,SRU,J,OEM-5.14,OEM-5.17] Support Cirrus audio

Message ID 20220415060515.378765-1-acelan.kao@canonical.com
Headers show
Series Support Cirrus audio | expand

Message

AceLan Kao April 15, 2022, 6:05 a.m. UTC
From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>

BugLink: https://bugs.launchpad.net/bugs/1968861

[Impact]
CS8409 needs new configuration for Odin platform

[Fix]
Cirrus provides us 2 patches to add the support which are not in upstream yet
ALSA: hda/cs8409: Add Speaker Playback Switch for Cyborg
ALSA: hda/cs8409: Support new Odin Variants

Below series of patch is required to be applied before these 2.
https://lists.ubuntu.com/archives/kernel-team/2022-April/129223.html

[Test]
Verified on the target machine

[Where problems could occur]
The first commit only affects the new added Odin platform, and the second one
do some modification for other platforms which is hard to know what may lead to.

Stefan Binding (2):
  UBUNTU: SAUCE: ALSA: hda/cs8409: Support new Odin Variants
  UBUNTU: SAUCE: ALSA: hda/cs8409: Add Speaker Playback Switch for
    Cyborg

 sound/pci/hda/patch_cs8409-tables.c | 19 +++++++
 sound/pci/hda/patch_cs8409.c        | 81 ++++++++++++++++++++++++-----
 sound/pci/hda/patch_cs8409.h        |  4 ++
 3 files changed, 90 insertions(+), 14 deletions(-)

Comments

Timo Aaltonen April 22, 2022, 7:15 a.m. UTC | #1
AceLan Kao kirjoitti 15.4.2022 klo 9.05:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1968861
> 
> [Impact]
> CS8409 needs new configuration for Odin platform
> 
> [Fix]
> Cirrus provides us 2 patches to add the support which are not in upstream yet
> ALSA: hda/cs8409: Add Speaker Playback Switch for Cyborg
> ALSA: hda/cs8409: Support new Odin Variants
> 
> Below series of patch is required to be applied before these 2.
> https://lists.ubuntu.com/archives/kernel-team/2022-April/129223.html
> 
> [Test]
> Verified on the target machine
> 
> [Where problems could occur]
> The first commit only affects the new added Odin platform, and the second one
> do some modification for other platforms which is hard to know what may lead to.
> 
> Stefan Binding (2):
>    UBUNTU: SAUCE: ALSA: hda/cs8409: Support new Odin Variants
>    UBUNTU: SAUCE: ALSA: hda/cs8409: Add Speaker Playback Switch for
>      Cyborg
> 
>   sound/pci/hda/patch_cs8409-tables.c | 19 +++++++
>   sound/pci/hda/patch_cs8409.c        | 81 ++++++++++++++++++++++++-----
>   sound/pci/hda/patch_cs8409.h        |  4 ++
>   3 files changed, 90 insertions(+), 14 deletions(-)
> 

applied to oem-5.14, thanks

won't apply to oem-5.17 though
Tim Gardner May 10, 2022, 6:06 p.m. UTC | #2
AceLan - can we wait until these patches are merged upstream before 
applying to Jammy ?

rtg

On 4/15/22 00:05, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1968861
> 
> [Impact]
> CS8409 needs new configuration for Odin platform
> 
> [Fix]
> Cirrus provides us 2 patches to add the support which are not in upstream yet
> ALSA: hda/cs8409: Add Speaker Playback Switch for Cyborg
> ALSA: hda/cs8409: Support new Odin Variants
> 
> Below series of patch is required to be applied before these 2.
> https://lists.ubuntu.com/archives/kernel-team/2022-April/129223.html
> 
> [Test]
> Verified on the target machine
> 
> [Where problems could occur]
> The first commit only affects the new added Odin platform, and the second one
> do some modification for other platforms which is hard to know what may lead to.
> 
> Stefan Binding (2):
>    UBUNTU: SAUCE: ALSA: hda/cs8409: Support new Odin Variants
>    UBUNTU: SAUCE: ALSA: hda/cs8409: Add Speaker Playback Switch for
>      Cyborg
> 
>   sound/pci/hda/patch_cs8409-tables.c | 19 +++++++
>   sound/pci/hda/patch_cs8409.c        | 81 ++++++++++++++++++++++++-----
>   sound/pci/hda/patch_cs8409.h        |  4 ++
>   3 files changed, 90 insertions(+), 14 deletions(-)
>
AceLan Kao May 11, 2022, 6:43 a.m. UTC | #3
Sure, I can submit it for Jammy later.

Tim Gardner <tim.gardner@canonical.com> 於 2022年5月11日 週三 上午2:06寫道:
>
> AceLan - can we wait until these patches are merged upstream before
> applying to Jammy ?
>
> rtg
>
> On 4/15/22 00:05, AceLan Kao wrote:
> > From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> >
> > BugLink: https://bugs.launchpad.net/bugs/1968861
> >
> > [Impact]
> > CS8409 needs new configuration for Odin platform
> >
> > [Fix]
> > Cirrus provides us 2 patches to add the support which are not in upstream yet
> > ALSA: hda/cs8409: Add Speaker Playback Switch for Cyborg
> > ALSA: hda/cs8409: Support new Odin Variants
> >
> > Below series of patch is required to be applied before these 2.
> > https://lists.ubuntu.com/archives/kernel-team/2022-April/129223.html
> >
> > [Test]
> > Verified on the target machine
> >
> > [Where problems could occur]
> > The first commit only affects the new added Odin platform, and the second one
> > do some modification for other platforms which is hard to know what may lead to.
> >
> > Stefan Binding (2):
> >    UBUNTU: SAUCE: ALSA: hda/cs8409: Support new Odin Variants
> >    UBUNTU: SAUCE: ALSA: hda/cs8409: Add Speaker Playback Switch for
> >      Cyborg
> >
> >   sound/pci/hda/patch_cs8409-tables.c | 19 +++++++
> >   sound/pci/hda/patch_cs8409.c        | 81 ++++++++++++++++++++++++-----
> >   sound/pci/hda/patch_cs8409.h        |  4 ++
> >   3 files changed, 90 insertions(+), 14 deletions(-)
> >
>
> --
> -----------
> Tim Gardner
> Canonical, Inc
Stefan Bader May 11, 2022, 7:45 a.m. UTC | #4
On 15.04.22 08:05, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1968861
> 
> [Impact]
> CS8409 needs new configuration for Odin platform
> 
> [Fix]
> Cirrus provides us 2 patches to add the support which are not in upstream yet
> ALSA: hda/cs8409: Add Speaker Playback Switch for Cyborg
> ALSA: hda/cs8409: Support new Odin Variants
> 
> Below series of patch is required to be applied before these 2.
> https://lists.ubuntu.com/archives/kernel-team/2022-April/129223.html
> 
> [Test]
> Verified on the target machine
> 
> [Where problems could occur]
> The first commit only affects the new added Odin platform, and the second one
> do some modification for other platforms which is hard to know what may lead to.
> 
> Stefan Binding (2):
>    UBUNTU: SAUCE: ALSA: hda/cs8409: Support new Odin Variants
>    UBUNTU: SAUCE: ALSA: hda/cs8409: Add Speaker Playback Switch for
>      Cyborg
> 
>   sound/pci/hda/patch_cs8409-tables.c | 19 +++++++
>   sound/pci/hda/patch_cs8409.c        | 81 ++++++++++++++++++++++++-----
>   sound/pci/hda/patch_cs8409.h        |  4 ++
>   3 files changed, 90 insertions(+), 14 deletions(-)
> 

Waiting until submitted as non-SAUCE.

-Stefan
Timo Aaltonen July 5, 2022, 12:44 p.m. UTC | #5
These are upstream now, please re-submit.

AceLan Kao kirjoitti 11.5.2022 klo 9.43:
> Sure, I can submit it for Jammy later.
> 
> Tim Gardner <tim.gardner@canonical.com> 於 2022年5月11日 週三 上午2:06寫道:
>>
>> AceLan - can we wait until these patches are merged upstream before
>> applying to Jammy ?
>>
>> rtg
>>
>> On 4/15/22 00:05, AceLan Kao wrote:
>>> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
>>>
>>> BugLink: https://bugs.launchpad.net/bugs/1968861
>>>
>>> [Impact]
>>> CS8409 needs new configuration for Odin platform
>>>
>>> [Fix]
>>> Cirrus provides us 2 patches to add the support which are not in upstream yet
>>> ALSA: hda/cs8409: Add Speaker Playback Switch for Cyborg
>>> ALSA: hda/cs8409: Support new Odin Variants
>>>
>>> Below series of patch is required to be applied before these 2.
>>> https://lists.ubuntu.com/archives/kernel-team/2022-April/129223.html
>>>
>>> [Test]
>>> Verified on the target machine
>>>
>>> [Where problems could occur]
>>> The first commit only affects the new added Odin platform, and the second one
>>> do some modification for other platforms which is hard to know what may lead to.
>>>
>>> Stefan Binding (2):
>>>     UBUNTU: SAUCE: ALSA: hda/cs8409: Support new Odin Variants
>>>     UBUNTU: SAUCE: ALSA: hda/cs8409: Add Speaker Playback Switch for
>>>       Cyborg
>>>
>>>    sound/pci/hda/patch_cs8409-tables.c | 19 +++++++
>>>    sound/pci/hda/patch_cs8409.c        | 81 ++++++++++++++++++++++++-----
>>>    sound/pci/hda/patch_cs8409.h        |  4 ++
>>>    3 files changed, 90 insertions(+), 14 deletions(-)
>>>
>>
>> --
>> -----------
>> Tim Gardner
>> Canonical, Inc
>
AceLan Kao July 6, 2022, 1:56 a.m. UTC | #6
Thanks, v2 sent
https://lists.ubuntu.com/archives/kernel-team/2022-July/131597.html

Timo Aaltonen <tjaalton@ubuntu.com> 於 2022年7月5日 週二 晚上8:44寫道:
>
>
>
> These are upstream now, please re-submit.
>
> AceLan Kao kirjoitti 11.5.2022 klo 9.43:
> > Sure, I can submit it for Jammy later.
> >
> > Tim Gardner <tim.gardner@canonical.com> 於 2022年5月11日 週三 上午2:06寫道:
> >>
> >> AceLan - can we wait until these patches are merged upstream before
> >> applying to Jammy ?
> >>
> >> rtg
> >>
> >> On 4/15/22 00:05, AceLan Kao wrote:
> >>> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> >>>
> >>> BugLink: https://bugs.launchpad.net/bugs/1968861
> >>>
> >>> [Impact]
> >>> CS8409 needs new configuration for Odin platform
> >>>
> >>> [Fix]
> >>> Cirrus provides us 2 patches to add the support which are not in upstream yet
> >>> ALSA: hda/cs8409: Add Speaker Playback Switch for Cyborg
> >>> ALSA: hda/cs8409: Support new Odin Variants
> >>>
> >>> Below series of patch is required to be applied before these 2.
> >>> https://lists.ubuntu.com/archives/kernel-team/2022-April/129223.html
> >>>
> >>> [Test]
> >>> Verified on the target machine
> >>>
> >>> [Where problems could occur]
> >>> The first commit only affects the new added Odin platform, and the second one
> >>> do some modification for other platforms which is hard to know what may lead to.
> >>>
> >>> Stefan Binding (2):
> >>>     UBUNTU: SAUCE: ALSA: hda/cs8409: Support new Odin Variants
> >>>     UBUNTU: SAUCE: ALSA: hda/cs8409: Add Speaker Playback Switch for
> >>>       Cyborg
> >>>
> >>>    sound/pci/hda/patch_cs8409-tables.c | 19 +++++++
> >>>    sound/pci/hda/patch_cs8409.c        | 81 ++++++++++++++++++++++++-----
> >>>    sound/pci/hda/patch_cs8409.h        |  4 ++
> >>>    3 files changed, 90 insertions(+), 14 deletions(-)
> >>>
> >>
> >> --
> >> -----------
> >> Tim Gardner
> >> Canonical, Inc
> >
>
>
> --
> t