mbox series

[SRU,J/U/OEM-5.14,0/6] Support different Cirrus audio codec configurations on Dell laptops

Message ID 20220406061352.966815-1-chris.chiu@canonical.com
Headers show
Series Support different Cirrus audio codec configurations on Dell laptops | expand

Message

Chris Chiu April 6, 2022, 6:13 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1967988

[Impact]
On Dell's platform, Warlock/Bullseye Laptops have a mono DMIC, Cyborg and
some Warlock variants uses a stereo DMIC. They are not correctly mapped
to the corresponding configurations so the microphone function are not
working as expected.

[Fix]
Cirrus upstream new FIXUPs to support different microphone configurations
on different Dell laptop variants.

[Test Case]
1. Go to Audio Settings
2. Make sure the microphone is correctly detected and responds to audio input.
3. Issue command "arecord record_file" and check the record_file is consistent 
   with audio input.

[Where problems could occur]
Risk should be Low. The patches come from Cirrus and the configurations
are mapped based on the audio codec's SSIDs for different Dell variants.  

Stefan Binding (5):
  ALSA: hda/cs8409: Fix Warlock to use mono mic configuration
  ALSA: hda/cs8409: Re-order quirk table into ascending order
  ALSA: hda/cs8409: Fix Full Scale Volume setting for all variants
  ALSA: hda/cs8409: Support new Warlock MLK Variants
  ALSA: hda/cs8409: Disable HSBIAS_SENSE_EN for Cyborg

Vitaly Rodionov (1):
  ALSA: hda/cs8409: Add new Dolphin HW variants

 sound/pci/hda/patch_cs8409-tables.c | 68 +++++++++++++++++++++--------
 sound/pci/hda/patch_cs8409.c        | 47 +++++++++++---------
 sound/pci/hda/patch_cs8409.h        |  5 +++
 3 files changed, 83 insertions(+), 37 deletions(-)

Comments

Tim Gardner April 6, 2022, 12:45 p.m. UTC | #1
Acked-by: Tim Gardner <tim.gardner@canonical.com>

On 4/6/22 00:13, Chris Chiu wrote:
> BugLink: https://bugs.launchpad.net/bugs/1967988
> 
> [Impact]
> On Dell's platform, Warlock/Bullseye Laptops have a mono DMIC, Cyborg and
> some Warlock variants uses a stereo DMIC. They are not correctly mapped
> to the corresponding configurations so the microphone function are not
> working as expected.
> 
> [Fix]
> Cirrus upstream new FIXUPs to support different microphone configurations
> on different Dell laptop variants.
> 
> [Test Case]
> 1. Go to Audio Settings
> 2. Make sure the microphone is correctly detected and responds to audio input.
> 3. Issue command "arecord record_file" and check the record_file is consistent
>     with audio input.
> 
> [Where problems could occur]
> Risk should be Low. The patches come from Cirrus and the configurations
> are mapped based on the audio codec's SSIDs for different Dell variants.
> 
> Stefan Binding (5):
>    ALSA: hda/cs8409: Fix Warlock to use mono mic configuration
>    ALSA: hda/cs8409: Re-order quirk table into ascending order
>    ALSA: hda/cs8409: Fix Full Scale Volume setting for all variants
>    ALSA: hda/cs8409: Support new Warlock MLK Variants
>    ALSA: hda/cs8409: Disable HSBIAS_SENSE_EN for Cyborg
> 
> Vitaly Rodionov (1):
>    ALSA: hda/cs8409: Add new Dolphin HW variants
> 
>   sound/pci/hda/patch_cs8409-tables.c | 68 +++++++++++++++++++++--------
>   sound/pci/hda/patch_cs8409.c        | 47 +++++++++++---------
>   sound/pci/hda/patch_cs8409.h        |  5 +++
>   3 files changed, 83 insertions(+), 37 deletions(-)
>
Paolo Pisati April 14, 2022, 1:22 p.m. UTC | #2
On Wed, Apr 06, 2022 at 02:13:46PM +0800, Chris Chiu wrote:
> BugLink: https://bugs.launchpad.net/bugs/1967988
Timo Aaltonen April 19, 2022, 1:42 p.m. UTC | #3
Chris Chiu kirjoitti 6.4.2022 klo 9.13:
> BugLink: https://bugs.launchpad.net/bugs/1967988
> 
> [Impact]
> On Dell's platform, Warlock/Bullseye Laptops have a mono DMIC, Cyborg and
> some Warlock variants uses a stereo DMIC. They are not correctly mapped
> to the corresponding configurations so the microphone function are not
> working as expected.
> 
> [Fix]
> Cirrus upstream new FIXUPs to support different microphone configurations
> on different Dell laptop variants.
> 
> [Test Case]
> 1. Go to Audio Settings
> 2. Make sure the microphone is correctly detected and responds to audio input.
> 3. Issue command "arecord record_file" and check the record_file is consistent
>     with audio input.
> 
> [Where problems could occur]
> Risk should be Low. The patches come from Cirrus and the configurations
> are mapped based on the audio codec's SSIDs for different Dell variants.
> 
> Stefan Binding (5):
>    ALSA: hda/cs8409: Fix Warlock to use mono mic configuration
>    ALSA: hda/cs8409: Re-order quirk table into ascending order
>    ALSA: hda/cs8409: Fix Full Scale Volume setting for all variants
>    ALSA: hda/cs8409: Support new Warlock MLK Variants
>    ALSA: hda/cs8409: Disable HSBIAS_SENSE_EN for Cyborg
> 
> Vitaly Rodionov (1):
>    ALSA: hda/cs8409: Add new Dolphin HW variants
> 
>   sound/pci/hda/patch_cs8409-tables.c | 68 +++++++++++++++++++++--------
>   sound/pci/hda/patch_cs8409.c        | 47 +++++++++++---------
>   sound/pci/hda/patch_cs8409.h        |  5 +++
>   3 files changed, 83 insertions(+), 37 deletions(-)
> 

applied to oem-5.14, thanks
Timo Aaltonen May 13, 2022, 6:25 p.m. UTC | #4
Chris Chiu kirjoitti 6.4.2022 klo 9.13:
> BugLink: https://bugs.launchpad.net/bugs/1967988
> 
> [Impact]
> On Dell's platform, Warlock/Bullseye Laptops have a mono DMIC, Cyborg and
> some Warlock variants uses a stereo DMIC. They are not correctly mapped
> to the corresponding configurations so the microphone function are not
> working as expected.
> 
> [Fix]
> Cirrus upstream new FIXUPs to support different microphone configurations
> on different Dell laptop variants.
> 
> [Test Case]
> 1. Go to Audio Settings
> 2. Make sure the microphone is correctly detected and responds to audio input.
> 3. Issue command "arecord record_file" and check the record_file is consistent
>     with audio input.
> 
> [Where problems could occur]
> Risk should be Low. The patches come from Cirrus and the configurations
> are mapped based on the audio codec's SSIDs for different Dell variants.
> 
> Stefan Binding (5):
>    ALSA: hda/cs8409: Fix Warlock to use mono mic configuration
>    ALSA: hda/cs8409: Re-order quirk table into ascending order
>    ALSA: hda/cs8409: Fix Full Scale Volume setting for all variants
>    ALSA: hda/cs8409: Support new Warlock MLK Variants
>    ALSA: hda/cs8409: Disable HSBIAS_SENSE_EN for Cyborg
> 
> Vitaly Rodionov (1):
>    ALSA: hda/cs8409: Add new Dolphin HW variants
> 
>   sound/pci/hda/patch_cs8409-tables.c | 68 +++++++++++++++++++++--------
>   sound/pci/hda/patch_cs8409.c        | 47 +++++++++++---------
>   sound/pci/hda/patch_cs8409.h        |  5 +++
>   3 files changed, 83 insertions(+), 37 deletions(-)
> 

this was supposed to get in oem-5.17 too, so applied there, and fixed 
the subject of the last patch