mbox series

[SRU,J/OEM-5.14,0/9] Add proper runtime PM support to Realtek PCIe cardreader

Message ID 20220304065526.25213-1-kai.heng.feng@canonical.com
Headers show
Series Add proper runtime PM support to Realtek PCIe cardreader | expand

Message

Kai-Heng Feng March 4, 2022, 6:55 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1963615

[Impact]
New generations of Realtek PCIe card reader cannot detect card insertion
when the device is in PCI D3.

[Fix]
Rework the runtime PM flow and add chip specific support.

[Test]
With the series applied, the device can detect card insertion when it's
in PCI D3.

[Where problems could occur]
System wide power management with less usage like hibernation, kexec
reboot, etc. are not tested extensively. So these cases may be affected.

Kai-Heng Feng (5):
  mmc: rtsx: Use pm_runtime_{get,put}() to handle runtime PM
  misc: rtsx: Rework runtime power management flow
  misc: rtsx: Cleanup power management ops
  misc: rtsx: Quiesce rts5249 on system suspend
  mmc: rtsx: Let MMC core handle runtime PM

Ricky WU (2):
  misc: rtsx: rts522a rts5228 rts5261 support Runtime PM
  mmc: rtsx: add 74 Clocks in power on flow

Tom Rix (1):
  misc: rtsx: conditionally build rtsx_pm_power_saving()

Ulf Hansson (1):
  mmc: rtsx: Fix build errors/warnings for unused variable

 drivers/misc/cardreader/rtl8411.c  |   2 +-
 drivers/misc/cardreader/rts5209.c  |   2 +-
 drivers/misc/cardreader/rts5227.c  |  47 ++++++
 drivers/misc/cardreader/rts5228.c  |  23 ++-
 drivers/misc/cardreader/rts5229.c  |   2 +-
 drivers/misc/cardreader/rts5249.c  |  31 +++-
 drivers/misc/cardreader/rts5261.c  |  35 ++++-
 drivers/misc/cardreader/rtsx_pcr.c | 228 +++++++++++------------------
 drivers/misc/cardreader/rtsx_pcr.h |   3 +
 drivers/mmc/host/rtsx_pci_sdmmc.c  |  49 ++++---
 include/linux/rtsx_pci.h           |   5 +-
 11 files changed, 248 insertions(+), 179 deletions(-)

Comments

Tim Gardner March 4, 2022, 12:34 p.m. UTC | #1
Acked-by: Tim Gardner <tim.gardner@canonical.com>

On 3/3/22 23:55, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1963615
> 
> [Impact]
> New generations of Realtek PCIe card reader cannot detect card insertion
> when the device is in PCI D3.
> 
> [Fix]
> Rework the runtime PM flow and add chip specific support.
> 
> [Test]
> With the series applied, the device can detect card insertion when it's
> in PCI D3.
> 
> [Where problems could occur]
> System wide power management with less usage like hibernation, kexec
> reboot, etc. are not tested extensively. So these cases may be affected.
> 
> Kai-Heng Feng (5):
>    mmc: rtsx: Use pm_runtime_{get,put}() to handle runtime PM
>    misc: rtsx: Rework runtime power management flow
>    misc: rtsx: Cleanup power management ops
>    misc: rtsx: Quiesce rts5249 on system suspend
>    mmc: rtsx: Let MMC core handle runtime PM
> 
> Ricky WU (2):
>    misc: rtsx: rts522a rts5228 rts5261 support Runtime PM
>    mmc: rtsx: add 74 Clocks in power on flow
> 
> Tom Rix (1):
>    misc: rtsx: conditionally build rtsx_pm_power_saving()
> 
> Ulf Hansson (1):
>    mmc: rtsx: Fix build errors/warnings for unused variable
> 
>   drivers/misc/cardreader/rtl8411.c  |   2 +-
>   drivers/misc/cardreader/rts5209.c  |   2 +-
>   drivers/misc/cardreader/rts5227.c  |  47 ++++++
>   drivers/misc/cardreader/rts5228.c  |  23 ++-
>   drivers/misc/cardreader/rts5229.c  |   2 +-
>   drivers/misc/cardreader/rts5249.c  |  31 +++-
>   drivers/misc/cardreader/rts5261.c  |  35 ++++-
>   drivers/misc/cardreader/rtsx_pcr.c | 228 +++++++++++------------------
>   drivers/misc/cardreader/rtsx_pcr.h |   3 +
>   drivers/mmc/host/rtsx_pci_sdmmc.c  |  49 ++++---
>   include/linux/rtsx_pci.h           |   5 +-
>   11 files changed, 248 insertions(+), 179 deletions(-)
>
Paolo Pisati March 9, 2022, 10:50 a.m. UTC | #2
On Fri, Mar 04, 2022 at 02:55:17PM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1963615
Timo Aaltonen March 14, 2022, 12:12 p.m. UTC | #3
Kai-Heng Feng kirjoitti 4.3.2022 klo 8.55:
> BugLink: https://bugs.launchpad.net/bugs/1963615
> 
> [Impact]
> New generations of Realtek PCIe card reader cannot detect card insertion
> when the device is in PCI D3.
> 
> [Fix]
> Rework the runtime PM flow and add chip specific support.
> 
> [Test]
> With the series applied, the device can detect card insertion when it's
> in PCI D3.
> 
> [Where problems could occur]
> System wide power management with less usage like hibernation, kexec
> reboot, etc. are not tested extensively. So these cases may be affected.
> 
> Kai-Heng Feng (5):
>    mmc: rtsx: Use pm_runtime_{get,put}() to handle runtime PM
>    misc: rtsx: Rework runtime power management flow
>    misc: rtsx: Cleanup power management ops
>    misc: rtsx: Quiesce rts5249 on system suspend
>    mmc: rtsx: Let MMC core handle runtime PM
> 
> Ricky WU (2):
>    misc: rtsx: rts522a rts5228 rts5261 support Runtime PM
>    mmc: rtsx: add 74 Clocks in power on flow
> 
> Tom Rix (1):
>    misc: rtsx: conditionally build rtsx_pm_power_saving()
> 
> Ulf Hansson (1):
>    mmc: rtsx: Fix build errors/warnings for unused variable
> 
>   drivers/misc/cardreader/rtl8411.c  |   2 +-
>   drivers/misc/cardreader/rts5209.c  |   2 +-
>   drivers/misc/cardreader/rts5227.c  |  47 ++++++
>   drivers/misc/cardreader/rts5228.c  |  23 ++-
>   drivers/misc/cardreader/rts5229.c  |   2 +-
>   drivers/misc/cardreader/rts5249.c  |  31 +++-
>   drivers/misc/cardreader/rts5261.c  |  35 ++++-
>   drivers/misc/cardreader/rtsx_pcr.c | 228 +++++++++++------------------
>   drivers/misc/cardreader/rtsx_pcr.h |   3 +
>   drivers/mmc/host/rtsx_pci_sdmmc.c  |  49 ++++---
>   include/linux/rtsx_pci.h           |   5 +-
>   11 files changed, 248 insertions(+), 179 deletions(-)
> 

applied to oem-5.14, thanks