mbox series

[SRU,J/Unstable/OEM-5.14,0/1] Fix USB3 detection on HP dock

Message ID 20211221032039.65655-1-kai.heng.feng@canonical.com
Headers show
Series Fix USB3 detection on HP dock | expand

Message

Kai-Heng Feng Dec. 21, 2021, 3:20 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1955443

[Impact]
Hotplug a USB3 device to HP dock can go undetected.

[Fix]
Add a delay for USB3 hub resume routine so the link has enough time to
transit to U0.

[Test]
After the patch is applied, the dock can always detect USB3 devices.

[Where problems could occur]
A non-noticeable delay was added, so no basically no impact.

Kai-Heng Feng (1):
  usb: hub: Add delay for SuperSpeed hub resume to let links transit to
    U0

 drivers/usb/core/hub.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Joseph Salisbury Dec. 21, 2021, 5:46 p.m. UTC | #1 
Acked-by: Joseph Salisbury <joseph.salisbury@canonical.com>

On 12/20/21 22:20, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1955443
>
> [Impact]
> Hotplug a USB3 device to HP dock can go undetected.
>
> [Fix]
> Add a delay for USB3 hub resume routine so the link has enough time to
> transit to U0.
>
> [Test]
> After the patch is applied, the dock can always detect USB3 devices.
>
> [Where problems could occur]
> A non-noticeable delay was added, so no basically no impact.
>
> Kai-Heng Feng (1):
>    usb: hub: Add delay for SuperSpeed hub resume to let links transit to
>      U0
>
>   drivers/usb/core/hub.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
Andrea Righi Jan. 4, 2022, 9:01 a.m. UTC | #2 
On Tue, Dec 21, 2021 at 11:20:38AM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1955443
> 
> [Impact]
> Hotplug a USB3 device to HP dock can go undetected.
> 
> [Fix]
> Add a delay for USB3 hub resume routine so the link has enough time to
> transit to U0.
> 
> [Test]
> After the patch is applied, the dock can always detect USB3 devices.
> 
> [Where problems could occur]
> A non-noticeable delay was added, so no basically no impact.

Applied to jammy:linux.

Thanks,
-Andrea
Timo Aaltonen Jan. 17, 2022, 10:27 a.m. UTC | #3 
On 21.12.2021 5.20, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1955443
> 
> [Impact]
> Hotplug a USB3 device to HP dock can go undetected.
> 
> [Fix]
> Add a delay for USB3 hub resume routine so the link has enough time to
> transit to U0.
> 
> [Test]
> After the patch is applied, the dock can always detect USB3 devices.
> 
> [Where problems could occur]
> A non-noticeable delay was added, so no basically no impact.
> 
> Kai-Heng Feng (1):
>    usb: hub: Add delay for SuperSpeed hub resume to let links transit to
>      U0
> 
>   drivers/usb/core/hub.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 

applied to oem-5.14, thanks