mbox series

[SRU,I/J/OEM-5.13/OEM-5.14,0/1] RTL8152: Add MAC passthrough support for more Lenovo docks

Message ID 20211122040924.29123-1-aaron.ma@canonical.com
Headers show
Series RTL8152: Add MAC passthrough support for more Lenovo docks | expand

Message

Aaron Ma Nov. 22, 2021, 4:09 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1951767

[Impact]
MAC pass through is not working on new TBT and USB-C docks.

[Fix]
Enable MAC pass through based on Lenovo USB hub.

[Test]
Tested on Lenovo TBT4 and TBT3 dock, MAC pass through works well.

[Where problems could occur]
The Realtek USB ethernet in Lenovo USB hub will mess the MAC address.

Aaron Ma (1):
  net: usb: r8152: Add MAC passthrough support for more Lenovo Docks

 drivers/net/usb/r8152.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

Comments

Stefan Bader Nov. 23, 2021, 7:58 a.m. UTC | #1 
On 22.11.21 05:09, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/1951767
> 
> [Impact]
> MAC pass through is not working on new TBT and USB-C docks.
> 
> [Fix]
> Enable MAC pass through based on Lenovo USB hub.
> 
> [Test]
> Tested on Lenovo TBT4 and TBT3 dock, MAC pass through works well.
> 
> [Where problems could occur]
> The Realtek USB ethernet in Lenovo USB hub will mess the MAC address.
> 
> Aaron Ma (1):
>    net: usb: r8152: Add MAC passthrough support for more Lenovo Docks
> 
>   drivers/net/usb/r8152.c | 9 +++------
>   1 file changed, 3 insertions(+), 6 deletions(-)
> 
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Kleber Sacilotto de Souza Nov. 23, 2021, 11:10 a.m. UTC | #2 
On 22.11.21 05:09, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/1951767
> 
> [Impact]
> MAC pass through is not working on new TBT and USB-C docks.
> 
> [Fix]
> Enable MAC pass through based on Lenovo USB hub.
> 
> [Test]
> Tested on Lenovo TBT4 and TBT3 dock, MAC pass through works well.
> 
> [Where problems could occur]
> The Realtek USB ethernet in Lenovo USB hub will mess the MAC address.
> 
> Aaron Ma (1):
>    net: usb: r8152: Add MAC passthrough support for more Lenovo Docks
> 
>   drivers/net/usb/r8152.c | 9 +++------
>   1 file changed, 3 insertions(+), 6 deletions(-)
> 

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

Thanks
Kleber Sacilotto de Souza Nov. 25, 2021, 11:19 a.m. UTC | #3 
On 22.11.21 05:09, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/1951767
>
> [Impact]
> MAC pass through is not working on new TBT and USB-C docks.
>
> [Fix]
> Enable MAC pass through based on Lenovo USB hub.
>
> [Test]
> Tested on Lenovo TBT4 and TBT3 dock, MAC pass through works well.
>
> [Where problems could occur]
> The Realtek USB ethernet in Lenovo USB hub will mess the MAC address.
>
> Aaron Ma (1):
>    net: usb: r8152: Add MAC passthrough support for more Lenovo Docks
>
>   drivers/net/usb/r8152.c | 9 +++------
>   1 file changed, 3 insertions(+), 6 deletions(-)
>

Applied to impish:linux.

Thanks,
Kleber
Andrea Righi Nov. 26, 2021, 7:38 a.m. UTC | #4 
On Mon, Nov 22, 2021 at 12:09:23PM +0800, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/1951767
> 
> [Impact]
> MAC pass through is not working on new TBT and USB-C docks.
> 
> [Fix]
> Enable MAC pass through based on Lenovo USB hub.
> 
> [Test]
> Tested on Lenovo TBT4 and TBT3 dock, MAC pass through works well.
> 
> [Where problems could occur]
> The Realtek USB ethernet in Lenovo USB hub will mess the MAC address.

Applied to Jammy/5.15.

Thanks,
-Andrea
Timo Aaltonen Dec. 2, 2021, 12:55 p.m. UTC | #5 
On 22.11.2021 6.09, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/1951767
> 
> [Impact]
> MAC pass through is not working on new TBT and USB-C docks.
> 
> [Fix]
> Enable MAC pass through based on Lenovo USB hub.
> 
> [Test]
> Tested on Lenovo TBT4 and TBT3 dock, MAC pass through works well.
> 
> [Where problems could occur]
> The Realtek USB ethernet in Lenovo USB hub will mess the MAC address.
> 
> Aaron Ma (1):
>    net: usb: r8152: Add MAC passthrough support for more Lenovo Docks
> 
>   drivers/net/usb/r8152.c | 9 +++------
>   1 file changed, 3 insertions(+), 6 deletions(-)
> 

applied to both oem-5.13 & 5.14, thanks