mbox series

[I/H/OEM-5.10,0/4] Mute/Mic mute LEDs and right speaker are not work on HP platforms

Message ID 20210615175920.20241-1-jeremy.szu@canonical.com
Headers show
Series Mute/Mic mute LEDs and right speaker are not work on HP platforms | expand

Message

Jeremy Szu June 15, 2021, 5:59 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1932055

[Impact]
The mic mute/audio mute LEDS are not work on
1) HP Elite Dragonfly G2 Notebook PC
2) HP EliteBook x360 1040 G8 Notebook PC
3) HP EliteBook 840 Aero G8 Notebook PC
4) HP ZBook Power 15.6 inch G8 Mobile Workstation PC
The right channel of internal speaker doesn't work on
1) HP Elite Dragonfly G2 Notebook PC
2) HP EliteBook x360 1040 G8 Notebook PC

[Fix]
These four platforms need specific quirk for different hardware layout.
Thus, add the quirks for them.

[Test]
After applying the quirk, the LEDs/speaker are work good on
1) HP Elite Dragonfly G2 Notebook PC
2) HP EliteBook x360 1040 G8 Notebook PC
3) HP EliteBook 840 Aero G8 Notebook PC
4) HP ZBook Power 15.6 inch G8 Mobile Workstation PC

[Where problems could occur]
If HP ships the different system boards design with the same subsystem ID of audio codec which is using different GPIO pins (different layout), then the quirk will not work (LEDs/speaker will not work when muting audio-output or microphone).

Jeremy Szu (4):
  ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Elite
    Dragonfly G2
  ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP EliteBook
    x360 1040 G8
  ALSA: hda/realtek: fix mute/micmute LEDs for HP EliteBook 840 Aero G8
  ALSA: hda/realtek: fix mute/micmute LEDs for HP ZBook Power G8

 sound/pci/hda/patch_realtek.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Tim Gardner June 16, 2021, 11:43 a.m. UTC | #1
Acked-by: Tim Gardner <tim.gardner@canonical.com>

On 6/15/21 11:59 AM, Jeremy Szu wrote:
> BugLink: https://bugs.launchpad.net/bugs/1932055
> 
> [Impact]
> The mic mute/audio mute LEDS are not work on
> 1) HP Elite Dragonfly G2 Notebook PC
> 2) HP EliteBook x360 1040 G8 Notebook PC
> 3) HP EliteBook 840 Aero G8 Notebook PC
> 4) HP ZBook Power 15.6 inch G8 Mobile Workstation PC
> The right channel of internal speaker doesn't work on
> 1) HP Elite Dragonfly G2 Notebook PC
> 2) HP EliteBook x360 1040 G8 Notebook PC
> 
> [Fix]
> These four platforms need specific quirk for different hardware layout.
> Thus, add the quirks for them.
> 
> [Test]
> After applying the quirk, the LEDs/speaker are work good on
> 1) HP Elite Dragonfly G2 Notebook PC
> 2) HP EliteBook x360 1040 G8 Notebook PC
> 3) HP EliteBook 840 Aero G8 Notebook PC
> 4) HP ZBook Power 15.6 inch G8 Mobile Workstation PC
> 
> [Where problems could occur]
> If HP ships the different system boards design with the same subsystem ID of audio codec which is using different GPIO pins (different layout), then the quirk will not work (LEDs/speaker will not work when muting audio-output or microphone).
> 
> Jeremy Szu (4):
>    ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Elite
>      Dragonfly G2
>    ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP EliteBook
>      x360 1040 G8
>    ALSA: hda/realtek: fix mute/micmute LEDs for HP EliteBook 840 Aero G8
>    ALSA: hda/realtek: fix mute/micmute LEDs for HP ZBook Power G8
> 
>   sound/pci/hda/patch_realtek.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
Timo Aaltonen June 16, 2021, 1:29 p.m. UTC | #2
On 15.6.2021 20.59, Jeremy Szu wrote:
> BugLink: https://bugs.launchpad.net/bugs/1932055
> 
> [Impact]
> The mic mute/audio mute LEDS are not work on
> 1) HP Elite Dragonfly G2 Notebook PC
> 2) HP EliteBook x360 1040 G8 Notebook PC
> 3) HP EliteBook 840 Aero G8 Notebook PC
> 4) HP ZBook Power 15.6 inch G8 Mobile Workstation PC
> The right channel of internal speaker doesn't work on
> 1) HP Elite Dragonfly G2 Notebook PC
> 2) HP EliteBook x360 1040 G8 Notebook PC
> 
> [Fix]
> These four platforms need specific quirk for different hardware layout.
> Thus, add the quirks for them.
> 
> [Test]
> After applying the quirk, the LEDs/speaker are work good on
> 1) HP Elite Dragonfly G2 Notebook PC
> 2) HP EliteBook x360 1040 G8 Notebook PC
> 3) HP EliteBook 840 Aero G8 Notebook PC
> 4) HP ZBook Power 15.6 inch G8 Mobile Workstation PC
> 
> [Where problems could occur]
> If HP ships the different system boards design with the same subsystem ID of audio codec which is using different GPIO pins (different layout), then the quirk will not work (LEDs/speaker will not work when muting audio-output or microphone).
> 
> Jeremy Szu (4):
>    ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Elite
>      Dragonfly G2
>    ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP EliteBook
>      x360 1040 G8
>    ALSA: hda/realtek: fix mute/micmute LEDs for HP EliteBook 840 Aero G8
>    ALSA: hda/realtek: fix mute/micmute LEDs for HP ZBook Power G8
> 
>   sound/pci/hda/patch_realtek.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 

applied to oem-5.10, thanks
Stefan Bader June 18, 2021, 8:05 a.m. UTC | #3
On 15.06.21 19:59, Jeremy Szu wrote:
> BugLink: https://bugs.launchpad.net/bugs/1932055
> 
> [Impact]
> The mic mute/audio mute LEDS are not work on
> 1) HP Elite Dragonfly G2 Notebook PC
> 2) HP EliteBook x360 1040 G8 Notebook PC
> 3) HP EliteBook 840 Aero G8 Notebook PC
> 4) HP ZBook Power 15.6 inch G8 Mobile Workstation PC
> The right channel of internal speaker doesn't work on
> 1) HP Elite Dragonfly G2 Notebook PC
> 2) HP EliteBook x360 1040 G8 Notebook PC
> 
> [Fix]
> These four platforms need specific quirk for different hardware layout.
> Thus, add the quirks for them.
> 
> [Test]
> After applying the quirk, the LEDs/speaker are work good on
> 1) HP Elite Dragonfly G2 Notebook PC
> 2) HP EliteBook x360 1040 G8 Notebook PC
> 3) HP EliteBook 840 Aero G8 Notebook PC
> 4) HP ZBook Power 15.6 inch G8 Mobile Workstation PC
> 
> [Where problems could occur]
> If HP ships the different system boards design with the same subsystem ID of audio codec which is using different GPIO pins (different layout), then the quirk will not work (LEDs/speaker will not work when muting audio-output or microphone).
> 
> Jeremy Szu (4):
>    ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Elite
>      Dragonfly G2
>    ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP EliteBook
>      x360 1040 G8
>    ALSA: hda/realtek: fix mute/micmute LEDs for HP EliteBook 840 Aero G8
>    ALSA: hda/realtek: fix mute/micmute LEDs for HP ZBook Power G8
> 
>   sound/pci/hda/patch_realtek.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Stefan Bader June 18, 2021, 9:31 a.m. UTC | #4
On 15.06.21 19:59, Jeremy Szu wrote:
> BugLink: https://bugs.launchpad.net/bugs/1932055
> 
> [Impact]
> The mic mute/audio mute LEDS are not work on
> 1) HP Elite Dragonfly G2 Notebook PC
> 2) HP EliteBook x360 1040 G8 Notebook PC
> 3) HP EliteBook 840 Aero G8 Notebook PC
> 4) HP ZBook Power 15.6 inch G8 Mobile Workstation PC
> The right channel of internal speaker doesn't work on
> 1) HP Elite Dragonfly G2 Notebook PC
> 2) HP EliteBook x360 1040 G8 Notebook PC
> 
> [Fix]
> These four platforms need specific quirk for different hardware layout.
> Thus, add the quirks for them.
> 
> [Test]
> After applying the quirk, the LEDs/speaker are work good on
> 1) HP Elite Dragonfly G2 Notebook PC
> 2) HP EliteBook x360 1040 G8 Notebook PC
> 3) HP EliteBook 840 Aero G8 Notebook PC
> 4) HP ZBook Power 15.6 inch G8 Mobile Workstation PC
> 
> [Where problems could occur]
> If HP ships the different system boards design with the same subsystem ID of audio codec which is using different GPIO pins (different layout), then the quirk will not work (LEDs/speaker will not work when muting audio-output or microphone).
> 
> Jeremy Szu (4):
>    ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Elite
>      Dragonfly G2
>    ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP EliteBook
>      x360 1040 G8
>    ALSA: hda/realtek: fix mute/micmute LEDs for HP EliteBook 840 Aero G8
>    ALSA: hda/realtek: fix mute/micmute LEDs for HP ZBook Power G8
> 
>   sound/pci/hda/patch_realtek.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
Applied to hirsute:linux. Thanks.

-Stefan