| Message ID | 20210610103519.3554-1-njavali@marvell.com |
|---|---|
| Headers | show |
| Series | qla2xxx: bug fixes | expand |
Acked-by: Tim Gardner <tim.gardner@canonical.com> I found all 4 patches to be clean cherry-picks. On 6/10/21 4:35 AM, Nilesh Javali wrote: > BugLink: https://bugs.launchpad.net/bugs/1860724 > > SRU Justification: > > [Impact] > > * On Ubuntu 20.04, NVMe Target will not get discovered in N2N > * configuration. The discovery was failing because Initiator was > * trying FC PRLI instead of NVMe PRLI. > > [Fix] > > * The driver code changes to handle NVMe N2N configuration and send PRLI > * based on the target. > > [Test Plan] > > * Load driver in NVMe N2N configuration and NVMe devices should be > * discovered by an Initiator. > > [Where problems could occur] > > * NVMe N2N configuration. > > [Other Info] > > * The bug is with inbox qla2xxx driver and needs update. > * All the qla2xxx driver bug fixes are part of upstream kernel. > * The repo used is, > * https://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/focal > * The base-commit used to apply these bug fixes is at the bottom. > > v4: > - Rebase patches on top of master-next branch > - Run sanity to verify N2N NVMe device discovery > > v3: > - Updated cherry picked and backported commit details for each patch > - Updated subject line to remove pull request > - Add v3 and v2 change list to cover letter > > v2: > - Added SRU justification to cover letter > - Updated subject line of each patch > - Added mainline commit details for each patch > > Arun Easi (1): > scsi: qla2xxx: Fix point-to-point (N2N) device discovery issue > > Quinn Tran (2): > scsi: qla2xxx: Serialize fc_port alloc in N2N > scsi: qla2xxx: Set Nport ID for N2N > > Quinn Trann (1): > scsi: qla2xxx: Fix N2N and NVMe connect retry failure > > drivers/scsi/qla2xxx/qla_def.h | 2 + > drivers/scsi/qla2xxx/qla_init.c | 72 ++++++++++++++++++++++++--------- > drivers/scsi/qla2xxx/qla_mbx.c | 48 +++++++++++----------- > drivers/scsi/qla2xxx/qla_os.c | 7 ++-- > 4 files changed, 84 insertions(+), 45 deletions(-) > > > base-commit: 45aa2f44ef787278d8972e35e8a3affc6402bd62 >
On Thu, Jun 10, 2021 at 9:04 AM Tim Gardner <tim.gardner@canonical.com> wrote: > > Acked-by: Tim Gardner <tim.gardner@canonical.com> > > I found all 4 patches to be clean cherry-picks. > > On 6/10/21 4:35 AM, Nilesh Javali wrote: > > BugLink: https://bugs.launchpad.net/bugs/1860724 > > > > SRU Justification: > > > > [Impact] > > > > * On Ubuntu 20.04, NVMe Target will not get discovered in N2N > > * configuration. The discovery was failing because Initiator was > > * trying FC PRLI instead of NVMe PRLI. > > > > [Fix] > > > > * The driver code changes to handle NVMe N2N configuration and send PRLI > > * based on the target. > > > > [Test Plan] > > > > * Load driver in NVMe N2N configuration and NVMe devices should be > > * discovered by an Initiator. > > > > [Where problems could occur] > > > > * NVMe N2N configuration. > > > > [Other Info] > > > > * The bug is with inbox qla2xxx driver and needs update. > > * All the qla2xxx driver bug fixes are part of upstream kernel. > > * The repo used is, > > * https://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/focal > > * The base-commit used to apply these bug fixes is at the bottom. > > > > v4: > > - Rebase patches on top of master-next branch > > - Run sanity to verify N2N NVMe device discovery > > > > v3: > > - Updated cherry picked and backported commit details for each patch > > - Updated subject line to remove pull request > > - Add v3 and v2 change list to cover letter > > > > v2: > > - Added SRU justification to cover letter > > - Updated subject line of each patch > > - Added mainline commit details for each patch > > > > Arun Easi (1): > > scsi: qla2xxx: Fix point-to-point (N2N) device discovery issue > > > > Quinn Tran (2): > > scsi: qla2xxx: Serialize fc_port alloc in N2N > > scsi: qla2xxx: Set Nport ID for N2N > > > > Quinn Trann (1): > > scsi: qla2xxx: Fix N2N and NVMe connect retry failure > > > > drivers/scsi/qla2xxx/qla_def.h | 2 + > > drivers/scsi/qla2xxx/qla_init.c | 72 ++++++++++++++++++++++++--------- > > drivers/scsi/qla2xxx/qla_mbx.c | 48 +++++++++++----------- > > drivers/scsi/qla2xxx/qla_os.c | 7 ++-- > > 4 files changed, 84 insertions(+), 45 deletions(-) > > > > > > base-commit: 45aa2f44ef787278d8972e35e8a3affc6402bd62 > > > > -- > ----------- > Tim Gardner > Canonical, Inc Thanks Nilesh for the patches, and Tim for the review! Tim, in case all patches are clean cherry-picks, guess we can edit the "backported from" to "cherry pick from" when applying, right? So Nilesh is not required to resend again... That said, the patches look good to me: Acked-by: Guilherme G. Piccoli <gpiccoli@canonical.com>
Applied to focal:linux with cherry-pick fixes. -rtg On 6/10/21 8:01 AM, Guilherme Piccoli wrote: > On Thu, Jun 10, 2021 at 9:04 AM Tim Gardner <tim.gardner@canonical.com> wrote: >> >> Acked-by: Tim Gardner <tim.gardner@canonical.com> >> >> I found all 4 patches to be clean cherry-picks. >> >> On 6/10/21 4:35 AM, Nilesh Javali wrote: >>> BugLink: https://bugs.launchpad.net/bugs/1860724 >>> >>> SRU Justification: >>> >>> [Impact] >>> >>> * On Ubuntu 20.04, NVMe Target will not get discovered in N2N >>> * configuration. The discovery was failing because Initiator was >>> * trying FC PRLI instead of NVMe PRLI. >>> >>> [Fix] >>> >>> * The driver code changes to handle NVMe N2N configuration and send PRLI >>> * based on the target. >>> >>> [Test Plan] >>> >>> * Load driver in NVMe N2N configuration and NVMe devices should be >>> * discovered by an Initiator. >>> >>> [Where problems could occur] >>> >>> * NVMe N2N configuration. >>> >>> [Other Info] >>> >>> * The bug is with inbox qla2xxx driver and needs update. >>> * All the qla2xxx driver bug fixes are part of upstream kernel. >>> * The repo used is, >>> * https://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/focal >>> * The base-commit used to apply these bug fixes is at the bottom. >>> >>> v4: >>> - Rebase patches on top of master-next branch >>> - Run sanity to verify N2N NVMe device discovery >>> >>> v3: >>> - Updated cherry picked and backported commit details for each patch >>> - Updated subject line to remove pull request >>> - Add v3 and v2 change list to cover letter >>> >>> v2: >>> - Added SRU justification to cover letter >>> - Updated subject line of each patch >>> - Added mainline commit details for each patch >>> >>> Arun Easi (1): >>> scsi: qla2xxx: Fix point-to-point (N2N) device discovery issue >>> >>> Quinn Tran (2): >>> scsi: qla2xxx: Serialize fc_port alloc in N2N >>> scsi: qla2xxx: Set Nport ID for N2N >>> >>> Quinn Trann (1): >>> scsi: qla2xxx: Fix N2N and NVMe connect retry failure >>> >>> drivers/scsi/qla2xxx/qla_def.h | 2 + >>> drivers/scsi/qla2xxx/qla_init.c | 72 ++++++++++++++++++++++++--------- >>> drivers/scsi/qla2xxx/qla_mbx.c | 48 +++++++++++----------- >>> drivers/scsi/qla2xxx/qla_os.c | 7 ++-- >>> 4 files changed, 84 insertions(+), 45 deletions(-) >>> >>> >>> base-commit: 45aa2f44ef787278d8972e35e8a3affc6402bd62 >>> >> >> -- >> ----------- >> Tim Gardner >> Canonical, Inc > > Thanks Nilesh for the patches, and Tim for the review! > Tim, in case all patches are clean cherry-picks, guess we can edit the > "backported from" to "cherry pick from" when applying, right? > So Nilesh is not required to resend again... > > That said, the patches look good to me: > Acked-by: Guilherme G. Piccoli <gpiccoli@canonical.com> >