| Message ID | 20210527142158.16171-1-tim.gardner@canonical.com |
|---|---|
| Headers | show |
| Series | cifs: On cifs_reconnect, resolve the hostname again | expand |
On 27/05/2021 11:21, Tim Gardner wrote: > v2 - Added an LP BugLink. > > BugLink: https://bugs.launchpad.net/bugs/1929831 > > Microsoft has asked to have commit commit 4e456b30f78c429b183db420e23b26cde7e03a78 applied. > A customer is reporting difficulties, though details are quite sparse. > The first 2 patches are scaffolding to make the backport simpler. > > [Impact] > > CIFS reconnects fail. > > [Test Plan] > > A test kernel made available to Microsoft has been verified to fix the problem. > > [Where problems could occur] > > This could perturb CIFS connections in new and different ways. > > [Other Info] > > PPA: https://launchpad.net/~timg-tpi/+archive/ubuntu/cifs-reconnect-sf00309672 > SF: https://canonical.my.salesforce.com/5004K000005pQNG > > Hey Tim, the patches look good to me so is the backport. The only thing I noticed is that, for patch 2, we have this small fix: git.kernel.org/linus/0bf1bafb17df Should we include it here as well? It's unfortunate that this fix doesn't contain a Fixes tag, not sure why... Let me know your thoughts - if we're leaving this small fix out, I can ACK this series. Cheers, Guilherme
On 5/27/21 8:37 AM, Guilherme G. Piccoli wrote: > > > On 27/05/2021 11:21, Tim Gardner wrote: >> v2 - Added an LP BugLink. >> >> BugLink: https://bugs.launchpad.net/bugs/1929831 >> >> Microsoft has asked to have commit commit 4e456b30f78c429b183db420e23b26cde7e03a78 applied. >> A customer is reporting difficulties, though details are quite sparse. >> The first 2 patches are scaffolding to make the backport simpler. >> >> [Impact] >> >> CIFS reconnects fail. >> >> [Test Plan] >> >> A test kernel made available to Microsoft has been verified to fix the problem. >> >> [Where problems could occur] >> >> This could perturb CIFS connections in new and different ways. >> >> [Other Info] >> >> PPA: https://launchpad.net/~timg-tpi/+archive/ubuntu/cifs-reconnect-sf00309672 >> SF: https://canonical.my.salesforce.com/5004K000005pQNG >> >> > > Hey Tim, the patches look good to me so is the backport. > The only thing I noticed is that, for patch 2, we have this small fix: > git.kernel.org/linus/0bf1bafb17df > > Should we include it here as well? It's unfortunate that this fix > doesn't contain a Fixes tag, not sure why... > > Let me know your thoughts - if we're leaving this small fix out, I can > ACK this series. Seems like we should include that patch as well. v3 on the way.
v3 on the way On 5/27/21 8:21 AM, Tim Gardner wrote: > v2 - Added an LP BugLink. > > BugLink: https://bugs.launchpad.net/bugs/1929831 > > Microsoft has asked to have commit commit 4e456b30f78c429b183db420e23b26cde7e03a78 applied. > A customer is reporting difficulties, though details are quite sparse. > The first 2 patches are scaffolding to make the backport simpler. > > [Impact] > > CIFS reconnects fail. > > [Test Plan] > > A test kernel made available to Microsoft has been verified to fix the problem. > > [Where problems could occur] > > This could perturb CIFS connections in new and different ways. > > [Other Info] > > PPA: https://launchpad.net/~timg-tpi/+archive/ubuntu/cifs-reconnect-sf00309672 > SF: https://canonical.my.salesforce.com/5004K000005pQNG >
Thank you Tim!