| Message ID | 20210426035418.2006578-1-vicamo.yang@canonical.com |
|---|---|
| Headers | show |
| Series | Fix CS8409 crack sound on Bullseye | expand |
Acked-by: Tim Gardner <tim.gardner@canonical.com> Self contained, affects only one specific bit of HW. On 4/25/21 9:54 PM, You-Sheng Yang wrote: > BugLink: https://bugs.launchpad.net/bugs/1924997 > > [Impact] > > On a few CS8409 installed platforms, there are crack sounds when playing > audio with output volume set to 100%. > > [Fix] > > The hardware is not capable of generating smooth audio output at the > maximum volume that codec chip can be configured. A fix proposed to lower > the maximum output volume using CS8409 equalizer. > > [Test Case] > > Use GNOME Settings / Sound Settings, set volume to 100%, play test > audio for both right and left channels; set volume back to 70%, and > repeat the same to compare to differences. While we don't have acoustic > lab to perform precise measurements, the result was confirmed by > partner. > > [Where problems could occur] > > This is to add a preconfigured, equalizer driver default values. This > will introduce non-uniformed frequency response in comparison to that in > the hardware preset. The net effect observable to general users is a > lower maximum output volume. For those Hi-Fi users, audio output always > takes additional calibration via extra software like ALSAEqual and/or > hardware. > > [Other Info] > > By SRU we skipped a couple of refactoring changes in asound upstream > tree, so additional changes to the original patch are required to > backport. > > Stefan Binding (1): > UBUNTU: SAUCE: ALSA: hda/cirrus: Use CS8409 Equalizer to fix abnormal > sounds on Bullseye > > sound/pci/hda/patch_cirrus.c | 33 +++++++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) >
On Mon, Apr 26, 2021 at 11:54:17AM +0800, You-Sheng Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1924997
On 26.04.21 05:54, You-Sheng Yang wrote: > BugLink: https://bugs.launchpad.net/bugs/1924997 > > [Impact] > > On a few CS8409 installed platforms, there are crack sounds when playing > audio with output volume set to 100%. > > [Fix] > > The hardware is not capable of generating smooth audio output at the > maximum volume that codec chip can be configured. A fix proposed to lower > the maximum output volume using CS8409 equalizer. > > [Test Case] > > Use GNOME Settings / Sound Settings, set volume to 100%, play test > audio for both right and left channels; set volume back to 70%, and > repeat the same to compare to differences. While we don't have acoustic > lab to perform precise measurements, the result was confirmed by > partner. > > [Where problems could occur] > > This is to add a preconfigured, equalizer driver default values. This > will introduce non-uniformed frequency response in comparison to that in > the hardware preset. The net effect observable to general users is a > lower maximum output volume. For those Hi-Fi users, audio output always > takes additional calibration via extra software like ALSAEqual and/or > hardware. > > [Other Info] > > By SRU we skipped a couple of refactoring changes in asound upstream > tree, so additional changes to the original patch are required to > backport. > > Stefan Binding (1): > UBUNTU: SAUCE: ALSA: hda/cirrus: Use CS8409 Equalizer to fix abnormal > sounds on Bullseye > > sound/pci/hda/patch_cirrus.c | 33 +++++++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > Applied to hirsute:linux/master-next after updating the commit message to match the upstream patch (Note the header changed to "ALSA: hda/cirrus: Use CS8409 filter to fix abnormal sounds on Bullseye"). Thanks. -Stefan
On 26.4.2021 6.54, You-Sheng Yang wrote: > BugLink: https://bugs.launchpad.net/bugs/1924997 > > [Impact] > > On a few CS8409 installed platforms, there are crack sounds when playing > audio with output volume set to 100%. > > [Fix] > > The hardware is not capable of generating smooth audio output at the > maximum volume that codec chip can be configured. A fix proposed to lower > the maximum output volume using CS8409 equalizer. > > [Test Case] > > Use GNOME Settings / Sound Settings, set volume to 100%, play test > audio for both right and left channels; set volume back to 70%, and > repeat the same to compare to differences. While we don't have acoustic > lab to perform precise measurements, the result was confirmed by > partner. > > [Where problems could occur] > > This is to add a preconfigured, equalizer driver default values. This > will introduce non-uniformed frequency response in comparison to that in > the hardware preset. The net effect observable to general users is a > lower maximum output volume. For those Hi-Fi users, audio output always > takes additional calibration via extra software like ALSAEqual and/or > hardware. > > [Other Info] > > By SRU we skipped a couple of refactoring changes in asound upstream > tree, so additional changes to the original patch are required to > backport. > > Stefan Binding (1): > UBUNTU: SAUCE: ALSA: hda/cirrus: Use CS8409 Equalizer to fix abnormal > sounds on Bullseye > > sound/pci/hda/patch_cirrus.c | 33 +++++++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > this was applied earlier, marking as such
BugLink: https://bugs.launchpad.net/bugs/1924997 [Impact] On a few CS8409 installed platforms, there are crack sounds when playing audio with output volume set to 100%. [Fix] The hardware is not capable of generating smooth audio output at the maximum volume that codec chip can be configured. A fix proposed to lower the maximum output volume using CS8409 equalizer. [Test Case] Use GNOME Settings / Sound Settings, set volume to 100%, play test audio for both right and left channels; set volume back to 70%, and repeat the same to compare to differences. While we don't have acoustic lab to perform precise measurements, the result was confirmed by partner. [Where problems could occur] This is to add a preconfigured, equalizer driver default values. This will introduce non-uniformed frequency response in comparison to that in the hardware preset. The net effect observable to general users is a lower maximum output volume. For those Hi-Fi users, audio output always takes additional calibration via extra software like ALSAEqual and/or hardware. [Other Info] By SRU we skipped a couple of refactoring changes in asound upstream tree, so additional changes to the original patch are required to backport. Stefan Binding (1): UBUNTU: SAUCE: ALSA: hda/cirrus: Use CS8409 Equalizer to fix abnormal sounds on Bullseye sound/pci/hda/patch_cirrus.c | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+)