| Message ID | 20210422165709.414669-1-andrea.righi@canonical.com |
|---|---|
| Headers | show |
| Series | Fix ftrace synthetic_events selftests failure in 5.11 | expand |
On 22/04/2021 17:57, Andrea Righi wrote: > BugLink: https://bugs.launchpad.net/bugs/1925539 > > [Impact] > > The synthetic_events ftrace test is failing in 5.11: > > 01:58:54 DEBUG| [stdout] # [68] event trigger - test synthetic_events syntax parser errors [FAIL] > > This happens because the synthetic_event parser/syntax has been reworked > in 5.12 and the selftest has been also updated. However, in 5.11 we got > only the commit that updates the test without the corresponding rework > in the kernel, therefore the test is failing. > > [Fix] > > Revert the commit that updates the ftrace synthetic_events selftest. > > [Test plan] > > Run the linux ftrace selftest to trigger the problem (e.g., make > TARGETS=ftrace kselftests). > > [Where problems could occur] > > This fix reverts a test case, if the kernel receives the ftrace rework > via stable updates in the future we may see failures with the same test. > > --- > > Andrea Righi (1): > UBUNTU: SAUCE: Revert "selftests/ftrace: Update synthetic event syntax errors" > > tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic_event_syntax_errors.tc | 35 ++++++++--------------------------- > 1 file changed, 8 insertions(+), 27 deletions(-) > > Urgh, so the self tests are ahead of the kernel. That's a bit crazy. Acked-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Tim Gardner <tim.gardner@canonical.com> On 4/22/21 10:57 AM, Andrea Righi wrote: > BugLink: https://bugs.launchpad.net/bugs/1925539 > > [Impact] > > The synthetic_events ftrace test is failing in 5.11: > > 01:58:54 DEBUG| [stdout] # [68] event trigger - test synthetic_events syntax parser errors [FAIL] > > This happens because the synthetic_event parser/syntax has been reworked > in 5.12 and the selftest has been also updated. However, in 5.11 we got > only the commit that updates the test without the corresponding rework > in the kernel, therefore the test is failing. > > [Fix] > > Revert the commit that updates the ftrace synthetic_events selftest. > > [Test plan] > > Run the linux ftrace selftest to trigger the problem (e.g., make > TARGETS=ftrace kselftests). > > [Where problems could occur] > > This fix reverts a test case, if the kernel receives the ftrace rework > via stable updates in the future we may see failures with the same test. > > --- > > Andrea Righi (1): > UBUNTU: SAUCE: Revert "selftests/ftrace: Update synthetic event syntax errors" > > tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic_event_syntax_errors.tc | 35 ++++++++--------------------------- > 1 file changed, 8 insertions(+), 27 deletions(-) > >
On 22.04.21 18:57, Andrea Righi wrote: > BugLink: https://bugs.launchpad.net/bugs/1925539 > > [Impact] > > The synthetic_events ftrace test is failing in 5.11: > > 01:58:54 DEBUG| [stdout] # [68] event trigger - test synthetic_events syntax parser errors [FAIL] > > This happens because the synthetic_event parser/syntax has been reworked > in 5.12 and the selftest has been also updated. However, in 5.11 we got > only the commit that updates the test without the corresponding rework > in the kernel, therefore the test is failing. > > [Fix] > > Revert the commit that updates the ftrace synthetic_events selftest. > > [Test plan] > > Run the linux ftrace selftest to trigger the problem (e.g., make > TARGETS=ftrace kselftests). > > [Where problems could occur] > > This fix reverts a test case, if the kernel receives the ftrace rework > via stable updates in the future we may see failures with the same test. > > --- > > Andrea Righi (1): > UBUNTU: SAUCE: Revert "selftests/ftrace: Update synthetic event syntax errors" > > tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic_event_syntax_errors.tc | 35 ++++++++--------------------------- > 1 file changed, 8 insertions(+), 27 deletions(-) > > Applied to hirsute:linux/master-next. Thanks. -Stefan
BugLink: https://bugs.launchpad.net/bugs/1925539 [Impact] The synthetic_events ftrace test is failing in 5.11: 01:58:54 DEBUG| [stdout] # [68] event trigger - test synthetic_events syntax parser errors [FAIL] This happens because the synthetic_event parser/syntax has been reworked in 5.12 and the selftest has been also updated. However, in 5.11 we got only the commit that updates the test without the corresponding rework in the kernel, therefore the test is failing. [Fix] Revert the commit that updates the ftrace synthetic_events selftest. [Test plan] Run the linux ftrace selftest to trigger the problem (e.g., make TARGETS=ftrace kselftests). [Where problems could occur] This fix reverts a test case, if the kernel receives the ftrace rework via stable updates in the future we may see failures with the same test. --- Andrea Righi (1): UBUNTU: SAUCE: Revert "selftests/ftrace: Update synthetic event syntax errors" tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic_event_syntax_errors.tc | 35 ++++++++--------------------------- 1 file changed, 8 insertions(+), 27 deletions(-)