mbox series

[SRU,H/U/OEM-5.10,0/1] Enable mute/micmute LEDs and limit mic boost on EliteBook 845 G8

Message ID 20210422043443.117325-1-kai.heng.feng@canonical.com
Headers show
Series Enable mute/micmute LEDs and limit mic boost on EliteBook 845 G8 | expand

Message

Kai-Heng Feng April 22, 2021, 4:34 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1925415

[Impact]
Mute/micmute LEDs don't work.
In addition, the internal mic can only capture lots of noises.

[Fix]
Use Realtek specific coef to enable LEDs and limit mic boost on the
platform.

[Test]
With the patch applied, the both LEDs start to work, and audio recording
becomes crystal clear.

[Where problems could occur]
It's a trivial change to a brand new device, so no existing device is
affected.

Kai-Heng Feng (1):
  ALSA: hda/realtek: Enable mute/micmute LEDs and limit mic boost on
    EliteBook 845 G8

 sound/pci/hda/patch_realtek.c | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Stefan Bader April 23, 2021, 9:45 a.m. UTC | #1 
On 22.04.21 06:34, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1925415
> 
> [Impact]
> Mute/micmute LEDs don't work.
> In addition, the internal mic can only capture lots of noises.
> 
> [Fix]
> Use Realtek specific coef to enable LEDs and limit mic boost on the
> platform.
> 
> [Test]
> With the patch applied, the both LEDs start to work, and audio recording
> becomes crystal clear.
> 
> [Where problems could occur]
> It's a trivial change to a brand new device, so no existing device is
> affected.
> 
> Kai-Heng Feng (1):
>    ALSA: hda/realtek: Enable mute/micmute LEDs and limit mic boost on
>      EliteBook 845 G8
> 
>   sound/pci/hda/patch_realtek.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
Applied to hirsute:linux/master-next. Thanks.

-Stefan
Paolo Pisati May 4, 2021, 9:30 a.m. UTC | #2 
On Thu, Apr 22, 2021 at 12:34:42PM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1925415
Timo Aaltonen May 10, 2021, 10:36 a.m. UTC | #3 
On 22.4.2021 7.34, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1925415
> 
> [Impact]
> Mute/micmute LEDs don't work.
> In addition, the internal mic can only capture lots of noises.
> 
> [Fix]
> Use Realtek specific coef to enable LEDs and limit mic boost on the
> platform.
> 
> [Test]
> With the patch applied, the both LEDs start to work, and audio recording
> becomes crystal clear.
> 
> [Where problems could occur]
> It's a trivial change to a brand new device, so no existing device is
> affected.
> 
> Kai-Heng Feng (1):
>    ALSA: hda/realtek: Enable mute/micmute LEDs and limit mic boost on
>      EliteBook 845 G8
> 
>   sound/pci/hda/patch_realtek.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
>