mbox series

[SRU,H/U/OEM-5.10,0/1] Fix kernel panic on non-PCI efifb

Message ID 20210414150124.1090303-1-kai.heng.feng@canonical.com
Headers show
Series Fix kernel panic on non-PCI efifb | expand

Message

Kai-Heng Feng April 14, 2021, 3:01 p.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1922403

[Impact]
Kernel panic at boot time on RPi4 UEFI and Hyper-V.

[Fix]
efifb isn't neccessarily a PCI device, so check that before using it.

[Test]
Boot Hirsute kernel on Hyper-V.
With the fix applied, no more kernel panic at boot.

[Where problems could occur]
Nothing really. The NULL check should've done in the first place.

Kai-Heng Feng (1):
  UBUNTU: SAUCE: efifb: Check efifb_pci_dev before using it

 drivers/video/fbdev/efifb.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Tim Gardner April 15, 2021, 11:22 a.m. UTC | #1 
Acked-by: Tim Gardner <tim.gardner@canonical.com>

On 4/14/21 9:01 AM, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1922403
> 
> [Impact]
> Kernel panic at boot time on RPi4 UEFI and Hyper-V.
> 
> [Fix]
> efifb isn't neccessarily a PCI device, so check that before using it.
> 
> [Test]
> Boot Hirsute kernel on Hyper-V.
> With the fix applied, no more kernel panic at boot.
> 
> [Where problems could occur]
> Nothing really. The NULL check should've done in the first place.
> 
> Kai-Heng Feng (1):
>    UBUNTU: SAUCE: efifb: Check efifb_pci_dev before using it
> 
>   drivers/video/fbdev/efifb.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
Seth Forshee April 16, 2021, 6:29 p.m. UTC | #2 
On Wed, Apr 14, 2021 at 11:01:23PM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1922403
> 
> [Impact]
> Kernel panic at boot time on RPi4 UEFI and Hyper-V.
> 
> [Fix]
> efifb isn't neccessarily a PCI device, so check that before using it.
> 
> [Test]
> Boot Hirsute kernel on Hyper-V.
> With the fix applied, no more kernel panic at boot.
> 
> [Where problems could occur]
> Nothing really. The NULL check should've done in the first place.

This was included in linux 5.11.0-16.17 for hirsute, and in all
derivative versions based on that version. Thanks!
Timo Aaltonen April 20, 2021, 9:41 a.m. UTC | #3 
On 14.4.2021 18.01, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1922403
> 
> [Impact]
> Kernel panic at boot time on RPi4 UEFI and Hyper-V.
> 
> [Fix]
> efifb isn't neccessarily a PCI device, so check that before using it.
> 
> [Test]
> Boot Hirsute kernel on Hyper-V.
> With the fix applied, no more kernel panic at boot.
> 
> [Where problems could occur]
> Nothing really. The NULL check should've done in the first place.
> 
> Kai-Heng Feng (1):
>    UBUNTU: SAUCE: efifb: Check efifb_pci_dev before using it
> 
>   drivers/video/fbdev/efifb.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>