mbox series

[SRU,F:linux-bluefield,0/5] offload support for ct state invalid and reply

Message ID 20210411114602.2003649-1-roid@nvidia.com
Headers show
Series offload support for ct state invalid and reply | expand

Message

Roi Dayan April 11, 2021, 11:45 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1922682


SRU Justification:

The patches are adding offload support for ct_state invalid and
ct_state reply.

* Explain the bug(s)

tc doesn't support matching on ct_state invalid and reply.

* brief explanation of fixes

Add tc support for ct_state invalid and reply which will allow supported drivers
to offload such to hw.

* How to test

Add tc rule with match on ct_state invalid or reply.

* What it could break.

Offloading of such tc rules. will continue to be handled in ovs dp.


Marcelo Ricardo Leitner (1):
  net/sched: act_ct: clear post_ct if doing ct_clear

Paul Blakey (2):
  net/sched: cls_flower: Add match on the ct_state reply flag
  net: flow_offload: Add original direction flag to ct_metadata

wenxu (2):
  net/sched: cls_flower add CT_FLAGS_INVALID flag support
  net/sched: act_api: fix miss set post_ct for ovs after do conntrack in
    act_ct

 include/linux/skbuff.h       |  5 +++--
 include/net/flow_offload.h   |  1 +
 include/net/sch_generic.h    |  1 +
 include/uapi/linux/pkt_cls.h |  2 ++
 net/core/dev.c               |  2 ++
 net/core/flow_dissector.c    | 13 +++++++++----
 net/openvswitch/conntrack.c  |  8 +++++---
 net/openvswitch/conntrack.h  |  6 ++++--
 net/openvswitch/flow.c       |  4 +++-
 net/sched/act_ct.c           |  6 +++++-
 net/sched/cls_api.c          |  1 +
 net/sched/cls_flower.c       | 10 +++++++---
 12 files changed, 43 insertions(+), 16 deletions(-)

Comments

Tim Gardner April 12, 2021, 12:03 p.m. UTC | #1
Acked-by: Tim Gardner <tim.gardner@canonical.com>

The backports look good. You need to update the SRU info in the bug report.

On 4/11/21 5:45 AM, Roi Dayan wrote:
> BugLink: https://bugs.launchpad.net/bugs/1922682
> 
> 
> SRU Justification:
> 
> The patches are adding offload support for ct_state invalid and
> ct_state reply.
> 
> * Explain the bug(s)
> 
> tc doesn't support matching on ct_state invalid and reply.
> 
> * brief explanation of fixes
> 
> Add tc support for ct_state invalid and reply which will allow supported drivers
> to offload such to hw.
> 
> * How to test
> 
> Add tc rule with match on ct_state invalid or reply.
> 
> * What it could break.
> 
> Offloading of such tc rules. will continue to be handled in ovs dp.
> 
> 
> Marcelo Ricardo Leitner (1):
>    net/sched: act_ct: clear post_ct if doing ct_clear
> 
> Paul Blakey (2):
>    net/sched: cls_flower: Add match on the ct_state reply flag
>    net: flow_offload: Add original direction flag to ct_metadata
> 
> wenxu (2):
>    net/sched: cls_flower add CT_FLAGS_INVALID flag support
>    net/sched: act_api: fix miss set post_ct for ovs after do conntrack in
>      act_ct
> 
>   include/linux/skbuff.h       |  5 +++--
>   include/net/flow_offload.h   |  1 +
>   include/net/sch_generic.h    |  1 +
>   include/uapi/linux/pkt_cls.h |  2 ++
>   net/core/dev.c               |  2 ++
>   net/core/flow_dissector.c    | 13 +++++++++----
>   net/openvswitch/conntrack.c  |  8 +++++---
>   net/openvswitch/conntrack.h  |  6 ++++--
>   net/openvswitch/flow.c       |  4 +++-
>   net/sched/act_ct.c           |  6 +++++-
>   net/sched/cls_api.c          |  1 +
>   net/sched/cls_flower.c       | 10 +++++++---
>   12 files changed, 43 insertions(+), 16 deletions(-)
>
Stefan Bader April 20, 2021, 6:25 a.m. UTC | #2
On 11.04.21 13:45, Roi Dayan wrote:
> BugLink: https://bugs.launchpad.net/bugs/1922682
> 
> 
> SRU Justification:
> 
> The patches are adding offload support for ct_state invalid and
> ct_state reply.
> 
> * Explain the bug(s)
> 
> tc doesn't support matching on ct_state invalid and reply.
> 
> * brief explanation of fixes
> 
> Add tc support for ct_state invalid and reply which will allow supported drivers
> to offload such to hw.
> 
> * How to test
> 
> Add tc rule with match on ct_state invalid or reply.
> 
> * What it could break.
> 
> Offloading of such tc rules. will continue to be handled in ovs dp.
> 
> 
> Marcelo Ricardo Leitner (1):
>    net/sched: act_ct: clear post_ct if doing ct_clear
> 
> Paul Blakey (2):
>    net/sched: cls_flower: Add match on the ct_state reply flag
>    net: flow_offload: Add original direction flag to ct_metadata
> 
> wenxu (2):
>    net/sched: cls_flower add CT_FLAGS_INVALID flag support
>    net/sched: act_api: fix miss set post_ct for ovs after do conntrack in
>      act_ct
> 
>   include/linux/skbuff.h       |  5 +++--
>   include/net/flow_offload.h   |  1 +
>   include/net/sch_generic.h    |  1 +
>   include/uapi/linux/pkt_cls.h |  2 ++
>   net/core/dev.c               |  2 ++
>   net/core/flow_dissector.c    | 13 +++++++++----
>   net/openvswitch/conntrack.c  |  8 +++++---
>   net/openvswitch/conntrack.h  |  6 ++++--
>   net/openvswitch/flow.c       |  4 +++-
>   net/sched/act_ct.c           |  6 +++++-
>   net/sched/cls_api.c          |  1 +
>   net/sched/cls_flower.c       | 10 +++++++---
>   12 files changed, 43 insertions(+), 16 deletions(-)
> 
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Stefan Bader April 20, 2021, 2:31 p.m. UTC | #3
On 11.04.21 13:45, Roi Dayan wrote:
> BugLink: https://bugs.launchpad.net/bugs/1922682
> 
> 
> SRU Justification:
> 
> The patches are adding offload support for ct_state invalid and
> ct_state reply.
> 
> * Explain the bug(s)
> 
> tc doesn't support matching on ct_state invalid and reply.
> 
> * brief explanation of fixes
> 
> Add tc support for ct_state invalid and reply which will allow supported drivers
> to offload such to hw.
> 
> * How to test
> 
> Add tc rule with match on ct_state invalid or reply.
> 
> * What it could break.
> 
> Offloading of such tc rules. will continue to be handled in ovs dp.
> 
> 
> Marcelo Ricardo Leitner (1):
>    net/sched: act_ct: clear post_ct if doing ct_clear
> 
> Paul Blakey (2):
>    net/sched: cls_flower: Add match on the ct_state reply flag
>    net: flow_offload: Add original direction flag to ct_metadata
> 
> wenxu (2):
>    net/sched: cls_flower add CT_FLAGS_INVALID flag support
>    net/sched: act_api: fix miss set post_ct for ovs after do conntrack in
>      act_ct
> 
>   include/linux/skbuff.h       |  5 +++--
>   include/net/flow_offload.h   |  1 +
>   include/net/sch_generic.h    |  1 +
>   include/uapi/linux/pkt_cls.h |  2 ++
>   net/core/dev.c               |  2 ++
>   net/core/flow_dissector.c    | 13 +++++++++----
>   net/openvswitch/conntrack.c  |  8 +++++---
>   net/openvswitch/conntrack.h  |  6 ++++--
>   net/openvswitch/flow.c       |  4 +++-
>   net/sched/act_ct.c           |  6 +++++-
>   net/sched/cls_api.c          |  1 +
>   net/sched/cls_flower.c       | 10 +++++++---
>   12 files changed, 43 insertions(+), 16 deletions(-)
> 
Applied to focal:linux-bluefield/master-next. Thanks.

-Stefan