mbox series

[SRU,Bionic,0/3] (LP: #1920995) selftests: bpf verifier fails after sanitize_ptr_alu fixes

Message ID 20210324004337.170117-1-cascardo@canonical.com
Headers show
Series (LP: #1920995) selftests: bpf verifier fails after sanitize_ptr_alu fixes | expand

Message

Thadeu Lima de Souza Cascardo March 24, 2021, 12:43 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1920995

[Impact]
bpf selftests will fail after applying fixes from 4.15.0-140.

[Fix]
Apply selftests fixes and bpf verifier simplification and hardening.

[Test Plan]
Ran the verifier test and other tests for the latest BPF fixes.

[Potential regression]
BPF programs that worked before may stop working or, worse, programs that
should not be allowed may start working.

Piotr Krysiuk (3):
  bpf: Simplify alu_limit masking for pointer arithmetic
  bpf: Add sanity check for upper ptr_limit
  bpf, selftests: Fix up some test_verifier cases for unprivileged

 kernel/bpf/verifier.c                       | 21 ++++++++++------
 tools/testing/selftests/bpf/test_verifier.c | 27 +++++++++++++++------
 2 files changed, 32 insertions(+), 16 deletions(-)

Comments

Kelsey Skunberg March 24, 2021, 2:11 a.m. UTC | #1
Acked-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>

On 2021-03-23 21:43:34 , Thadeu Lima de Souza Cascardo wrote:
> BugLink: https://bugs.launchpad.net/bugs/1920995
> 
> [Impact]
> bpf selftests will fail after applying fixes from 4.15.0-140.
> 
> [Fix]
> Apply selftests fixes and bpf verifier simplification and hardening.
> 
> [Test Plan]
> Ran the verifier test and other tests for the latest BPF fixes.
> 
> [Potential regression]
> BPF programs that worked before may stop working or, worse, programs that
> should not be allowed may start working.
> 
> Piotr Krysiuk (3):
>   bpf: Simplify alu_limit masking for pointer arithmetic
>   bpf: Add sanity check for upper ptr_limit
>   bpf, selftests: Fix up some test_verifier cases for unprivileged
> 
>  kernel/bpf/verifier.c                       | 21 ++++++++++------
>  tools/testing/selftests/bpf/test_verifier.c | 27 +++++++++++++++------
>  2 files changed, 32 insertions(+), 16 deletions(-)
> 
> -- 
> 2.27.0
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Stefan Bader March 24, 2021, 7:57 a.m. UTC | #2
On 24.03.21 01:43, Thadeu Lima de Souza Cascardo wrote:
> BugLink: https://bugs.launchpad.net/bugs/1920995
> 
> [Impact]
> bpf selftests will fail after applying fixes from 4.15.0-140.
> 
> [Fix]
> Apply selftests fixes and bpf verifier simplification and hardening.
> 
> [Test Plan]
> Ran the verifier test and other tests for the latest BPF fixes.
> 
> [Potential regression]
> BPF programs that worked before may stop working or, worse, programs that
> should not be allowed may start working.
> 
> Piotr Krysiuk (3):
>    bpf: Simplify alu_limit masking for pointer arithmetic
>    bpf: Add sanity check for upper ptr_limit
>    bpf, selftests: Fix up some test_verifier cases for unprivileged
> 
>   kernel/bpf/verifier.c                       | 21 ++++++++++------
>   tools/testing/selftests/bpf/test_verifier.c | 27 +++++++++++++++------
>   2 files changed, 32 insertions(+), 16 deletions(-)
> 
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Tim Gardner March 24, 2021, 2:57 p.m. UTC | #3
Applied to bionic/master-next. Thanks.

-rtg

On 3/23/21 6:43 PM, Thadeu Lima de Souza Cascardo wrote:
> BugLink: https://bugs.launchpad.net/bugs/1920995
> 
> [Impact]
> bpf selftests will fail after applying fixes from 4.15.0-140.
> 
> [Fix]
> Apply selftests fixes and bpf verifier simplification and hardening.
> 
> [Test Plan]
> Ran the verifier test and other tests for the latest BPF fixes.
> 
> [Potential regression]
> BPF programs that worked before may stop working or, worse, programs that
> should not be allowed may start working.
> 
> Piotr Krysiuk (3):
>    bpf: Simplify alu_limit masking for pointer arithmetic
>    bpf: Add sanity check for upper ptr_limit
>    bpf, selftests: Fix up some test_verifier cases for unprivileged
> 
>   kernel/bpf/verifier.c                       | 21 ++++++++++------
>   tools/testing/selftests/bpf/test_verifier.c | 27 +++++++++++++++------
>   2 files changed, 32 insertions(+), 16 deletions(-)
>